Skip to content

Consider running with fixes explicitly disabled #1342

@scop

Description

@scop

Welcome

  • Yes, I understand that the GitHub action repository is not the repository of golangci-lint itself.
  • Yes, I've searched similar issues on GitHub and didn't find any.

Your feature request related to a problem? Please describe.

If the golangci-lint config to be used specifies fix: true, the action will exit with success and no output besides "0 issues" in case golangci-lint managed to autofix all its findings.

Describe the solution you'd like.

The action should disable fix mode explicitly.

This should be easily doable by defaulting args to --fix=false. It would be a bit of an annoyance for setups that pass other options in args as they would have to remember to include --fix=false in the ones they pass. So changing the default would not help them to avoid inadvertent successes.

This would be a breaking change in a sense.

Describe alternatives you've considered.

Documenting the issue and the workaround.

Additional context.

Example affected repo and the workaround for it in home-assistant/cli#633

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions