Merge pull request #188 from google/gorrila/mux/core

RequestTags interface

Author: kapv89

go/core/README.md

@@ -17,12 +17,14 @@ Users are given control over what tags they want to append by using `core.Commen
 ```go
 type CommenterOptions struct {
 	EnableDBDriver    bool
-	EnableTraceparent bool  // OpenTelemetry trace information
-	EnableRoute       bool  // applicable for web frameworks
-	EnableFramework   bool  // applicable for web frameworks
-	EnableController  bool  // applicable for web frameworks
-	EnableAction      bool  // applicable for web frameworks
-	}
+	EnableTraceparent bool   // OpenTelemetry trace information
+	EnableRoute       bool   // applicable for web frameworks
+	EnableFramework   bool   // applicable for web frameworks
+	EnableController  bool   // applicable for web frameworks
+	EnableAction      bool   // applicable for web frameworks
+	EnableApplication bool
+	Application       string // user-provided application-name. optional
+}
 ```
 
 

go/core/core.go

@@ -88,13 +88,13 @@ func ExtractTraceparent(ctx context.Context) propagation.MapCarrier {
 	return carrier
 }
 
-type RequestExtractor interface {
+type RequestTagsProvider interface {
 	Route() string
 	Action() string
 	Framework() string
 }
 
-func ContextInject(ctx context.Context, h RequestExtractor) context.Context {
+func ContextInject(ctx context.Context, h RequestTagsProvider) context.Context {
 	ctx = context.WithValue(ctx, Route, h.Route())
 	ctx = context.WithValue(ctx, Action, h.Action())
 	ctx = context.WithValue(ctx, Framework, h.Framework())

go/core/go.mod

@@ -2,6 +2,6 @@ module github.com/google/sqlcommenter/go/core
 
 go 1.19
 
-require go.opentelemetry.io/otel v1.10.0
+require go.opentelemetry.io/otel v1.11.1
 
-require go.opentelemetry.io/otel/trace v1.10.0 // indirect
+require go.opentelemetry.io/otel/trace v1.11.1 // indirect

go/core/go.sum

@@ -6,6 +6,10 @@ github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZb
 github.com/stretchr/testify v1.7.1 h1:5TQK59W5E3v0r2duFAb7P95B6hEeOyEnHRa8MjYSMTY=
 go.opentelemetry.io/otel v1.10.0 h1:Y7DTJMR6zs1xkS/upamJYk0SxxN4C9AqRd77jmZnyY4=
 go.opentelemetry.io/otel v1.10.0/go.mod h1:NbvWjCthWHKBEUMpf0/v8ZRZlni86PpGFEMA9pnQSnQ=
+go.opentelemetry.io/otel v1.11.1 h1:4WLLAmcfkmDk2ukNXJyq3/kiz/3UzCaYq6PskJsaou4=
+go.opentelemetry.io/otel v1.11.1/go.mod h1:1nNhXBbWSD0nsL38H6btgnFN2k4i0sNLHNNMZMSbUGE=
 go.opentelemetry.io/otel/trace v1.10.0 h1:npQMbR8o7mum8uF95yFbOEJffhs1sbCOfDh8zAJiH5E=
 go.opentelemetry.io/otel/trace v1.10.0/go.mod h1:Sij3YYczqAdz+EhmGhE6TpTxUO5/F/AzrK+kxfGqySM=
+go.opentelemetry.io/otel/trace v1.11.1 h1:ofxdnzsNrGBYXbP7t7zpUK281+go5rF7dvdIZXF8gdQ=
+go.opentelemetry.io/otel/trace v1.11.1/go.mod h1:f/Q9G7vzk5u91PhbmKbg1Qn0rzH1LJ4vbPHFGkTPtOk=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c h1:dUUwHk2QECo/6vqA44rthZ8ie2QXMNeKRTHCNY2nXvo=