Skip to content

Commit 2981629

Browse files
authored
Replace resource name parameters with IDs (#420)
Change-Id: I3cfc8d78cf0208c8103736c98e6e4ac32b9222aa
1 parent 313f9f1 commit 2981629

2 files changed

Lines changed: 18 additions & 14 deletions

File tree

google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/AddSmartDisplayAd.java

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import com.google.ads.googleads.examples.utils.ArgumentNames;
2121
import com.google.ads.googleads.examples.utils.CodeSampleParams;
2222
import com.google.ads.googleads.lib.GoogleAdsClient;
23+
import com.google.ads.googleads.v6.utils.ResourceNames;
2324
import com.google.ads.googleads.v6.common.AdImageAsset;
2425
import com.google.ads.googleads.v6.common.AdTextAsset;
2526
import com.google.ads.googleads.v6.common.ImageAsset;
@@ -88,11 +89,11 @@ private static class AddSmartDisplayAdParams extends CodeSampleParams {
8889
@Parameter(names = ArgumentNames.CUSTOMER_ID, required = true)
8990
private Long customerId;
9091

91-
@Parameter(names = ArgumentNames.MARKETING_IMAGE_ASSET_RESOURCE_NAME, required = false)
92-
private String marketingImageAssetResourceName;
92+
@Parameter(names = ArgumentNames.MARKETING_IMAGE_ASSET_ID, required = false)
93+
private Long marketingImageAssetResourceName;
9394

94-
@Parameter(names = ArgumentNames.SQUARE_MARKETING_IMAGE_ASSET_RESOURCE_NAME, required = false)
95-
private String squareMarketingImageAssetResourceName;
95+
@Parameter(names = ArgumentNames.SQUARE_MARKETING_IMAGE_ID, required = false)
96+
private Long squareMarketingImageAssetResourceName;
9697
}
9798

9899
public static void main(String[] args) throws IOException {
@@ -148,26 +149,31 @@ public static void main(String[] args) throws IOException {
148149
*
149150
* @param googleAdsClient the Google Ads API client.
150151
* @param customerId the client customer ID.
151-
* @param marketingImageAssetResourceName
152-
* @param squareMarketingImageAssetResourceName
152+
* @param marketingImageAssetId
153+
* @param squareMarketingImageAssetId
153154
* @throws GoogleAdsException if an API request failed with one or more service errors.
154155
*/
155156
private void runExample(
156157
GoogleAdsClient googleAdsClient,
157158
long customerId,
158-
String marketingImageAssetResourceName,
159-
String squareMarketingImageAssetResourceName)
159+
Long marketingImageAssetId,
160+
Long squareMarketingImageAssetId)
160161
throws IOException {
161162
String budgetResourceName = createCampaignBudget(googleAdsClient, customerId);
162163
String campaignResourceName =
163164
createSmartDisplayCampaign(googleAdsClient, customerId, budgetResourceName);
164165
String adGroupResourceName = createAdGroup(googleAdsClient, customerId, campaignResourceName);
166+
165167
createResponsiveDisplayAd(
166168
googleAdsClient,
167169
customerId,
168170
adGroupResourceName,
169-
marketingImageAssetResourceName,
170-
squareMarketingImageAssetResourceName);
171+
marketingImageAssetId == null
172+
? null
173+
: ResourceNames.asset(customerId, marketingImageAssetId),
174+
squareMarketingImageAssetId == null
175+
? null
176+
: ResourceNames.asset(customerId, squareMarketingImageAssetId));
171177
}
172178

173179
/**

google-ads-examples/src/main/java/com/google/ads/googleads/examples/utils/ArgumentNames.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ public final class ArgumentNames {
7878
public static final String LOGIN_CUSTOMER_ID = "--loginCustomerId";
7979
public static final String MANAGER_CUSTOMER_ID = "--managerCustomerId";
8080
public static final String MANAGER_ID = "--managerId";
81-
public static final String MARKETING_IMAGE_ASSET_RESOURCE_NAME =
82-
"--marketingImageAssetResourceName";
81+
public static final String MARKETING_IMAGE_ASSET_ID = "--marketingImageAssetId";
8382
public static final String MERCHANT_CENTER_ACCOUNT_ID = "--merchantCenterAccountId";
8483
public static final String OFFLINE_USER_DATA_JOB_TYPE = "--offlineUserDataJobType";
8584
public static final String PAGE_URL = "--pageUrl";
@@ -91,8 +90,7 @@ public final class ArgumentNames {
9190
public static final String REPLACE_EXISTING_TREE = "--replaceExistingTree";
9291
public static final String RESTATEMENT_VALUE = "--restatementValue";
9392
public static final String SITELINK_TEXT = "--sitelinkText";
94-
public static final String SQUARE_MARKETING_IMAGE_ASSET_RESOURCE_NAME =
95-
"--squareMarketingImageAssetResourceName";
93+
public static final String SQUARE_MARKETING_IMAGE_ID = "--squareMarketingImageAssetId";
9694
public static final String USER_LIST_ID = "--userListId";
9795
public static final String USER_LIST_IDS = "--userListIds";
9896
}

0 commit comments

Comments
 (0)