Skip to content

Commit 3c94c7b

Browse files
authored
Update dependency versions for consistency (#268)
* Update dependency versions for consistency * Minimized protobuf and grpc dependencies to use versions from gax instead
1 parent 0e640f2 commit 3c94c7b

3 files changed

Lines changed: 21 additions & 25 deletions

File tree

google-ads-examples/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
<groupId>org.apache.logging.log4j</groupId>
6868
<artifactId>log4j-slf4j-impl</artifactId>
6969
<version>2.11.1</version>
70+
<scope>runtime</scope>
7071
</dependency>
7172
<!-- Test dependencies -->
7273
<dependency>

google-ads-migration-examples/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,13 @@
7777
<groupId>org.apache.logging.log4j</groupId>
7878
<artifactId>log4j-slf4j-impl</artifactId>
7979
<version>2.11.1</version>
80+
<scope>runtime</scope>
8081
</dependency>
8182
<dependency>
8283
<groupId>log4j</groupId>
8384
<artifactId>log4j</artifactId>
8485
<version>1.2.16</version>
86+
<scope>runtime</scope>
8587
</dependency>
8688
<!-- Test dependencies -->
8789
<dependency>

google-ads/pom.xml

Lines changed: 18 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,12 @@
3333
</description>
3434

3535
<properties>
36-
<auto-value.version>1.4</auto-value.version>
36+
<auto-value.version>1.6.6</auto-value.version>
37+
<!-- Keep all versions below consistent with the io.netty version. -->
38+
<netty.version>2.0.26.Final</netty.version>
3739
<gax.version>1.50.1</gax.version>
3840
<grpc.version>1.25.0</grpc.version>
39-
<protobuf.version>3.5.1</protobuf.version>
41+
<protobuf.version>3.10.0</protobuf.version>
4042
</properties>
4143

4244
<dependencies>
@@ -50,39 +52,19 @@
5052
<artifactId>gax-grpc</artifactId>
5153
<version>${gax.version}</version>
5254
</dependency>
53-
<dependency>
54-
<groupId>com.google.api.grpc</groupId>
55-
<artifactId>grpc-google-common-protos</artifactId>
56-
<version>1.0.0</version>
57-
</dependency>
58-
<dependency>
59-
<groupId>com.google.api.grpc</groupId>
60-
<artifactId>proto-google-common-protos</artifactId>
61-
<version>1.16.0</version>
62-
</dependency>
6355
<dependency>
6456
<groupId>com.google.auto.value</groupId>
6557
<artifactId>auto-value</artifactId>
6658
<version>${auto-value.version}</version>
6759
<scope>provided</scope>
6860
</dependency>
69-
<dependency>
70-
<groupId>com.google.protobuf</groupId>
71-
<artifactId>protobuf-java</artifactId>
72-
<version>${protobuf.version}</version>
73-
</dependency>
74-
<dependency>
75-
<groupId>io.grpc</groupId>
76-
<artifactId>grpc-all</artifactId>
77-
<version>${grpc.version}</version>
78-
</dependency>
7961
<dependency>
8062
<groupId>io.netty</groupId>
8163
<artifactId>netty-tcnative-boringssl-static</artifactId>
8264
<!--
8365
See https://github.com/grpc/grpc-java/blob/master/SECURITY.md#troubleshooting
8466
-->
85-
<version>2.0.7.Final</version>
67+
<version>${netty.version}</version>
8668
</dependency>
8769
<dependency>
8870
<groupId>org.slf4j</groupId>
@@ -116,6 +98,17 @@
11698
<version>${gax.version}</version>
11799
<scope>test</scope>
118100
</dependency>
101+
<dependency>
102+
<!--
103+
Without this dependency, gax will add io.grpc:grpc-context:jar:1.22.1 to
104+
the classpath instead of io.grpc:grpc-context:jar:1.25.0, and tests will
105+
fail due to changes to io.grpc.Deadline.
106+
-->
107+
<groupId>io.grpc</groupId>
108+
<artifactId>grpc-context</artifactId>
109+
<version>${grpc.version}</version>
110+
<scope>test</scope>
111+
</dependency>
119112
<dependency>
120113
<groupId>com.google.truth</groupId>
121114
<artifactId>truth</artifactId>
@@ -136,7 +129,7 @@
136129
<plugin>
137130
<groupId>com.github.os72</groupId>
138131
<artifactId>protoc-jar-maven-plugin</artifactId>
139-
<version>3.7.0</version>
132+
<version>3.11.1</version>
140133
<executions>
141134
<execution>
142135
<id>generate-test-protos</id>
@@ -145,7 +138,7 @@
145138
<goal>run</goal>
146139
</goals>
147140
<configuration>
148-
<protocArtifact>com.google.protobuf:protoc:3.7.0</protocArtifact>
141+
<protocArtifact>com.google.protobuf:protoc:${protobuf.version}</protocArtifact>
149142
<inputDirectories>
150143
<include>src/test/resources/protos</include>
151144
</inputDirectories>

0 commit comments

Comments
 (0)