Remove dependency on org.reflections:reflections (#654)

Author: jradcliff

google-ads-codegen/build.gradle

@@ -25,7 +25,6 @@ dependencies {
     api project(":google-ads-stubs-lib")
     implementation 'org.slf4j:slf4j-api:1.7.25'
     implementation 'com.squareup:javapoet:1.11.1'
-    implementation 'org.reflections:reflections:0.9.11'
     testImplementation 'com.google.api:gax-grpc:1.65.1:testlib'
     testImplementation 'org.hamcrest:java-hamcrest:2.0.0.0'
     testImplementation 'org.mockito:mockito-all:1.9.5'
@@ -64,4 +63,4 @@ publishing {
                     "Generated code (stus) and generators for library")
         }
     }
-}
+}

google-ads-codegen/src/main/java/com/google/ads/googleads/codegen/RunCodeGenerators.java

@@ -15,18 +15,17 @@
 package com.google.ads.googleads.codegen;
 
 import com.google.ads.googleads.lib.stubs.annotations.VersionDescriptor;
+import com.google.common.base.Preconditions;
 import com.google.common.collect.ImmutableList;
 import com.google.common.collect.ImmutableMap;
+import com.google.common.reflect.ClassPath;
+import com.google.common.reflect.ClassPath.ClassInfo;
 import java.io.File;
+import java.io.IOException;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
 import java.util.stream.Collectors;
-import org.reflections.Reflections;
-import org.reflections.scanners.SubTypesScanner;
-import org.reflections.scanners.TypeAnnotationsScanner;
-import org.reflections.util.ClasspathHelper;
-import org.reflections.util.ConfigurationBuilder;
 
 /**
  * Generates various classes which require knowing the available Google Ads API major versions.
@@ -56,12 +55,24 @@ public static void main(String[] args) {
    * major version by the GAPIC generator pipeline.
    */
   private static Set<Class<?>> loadAnnotatedClasses() {
-    Reflections reflections =
-        new Reflections(
-            new ConfigurationBuilder()
-                .addUrls(ClasspathHelper.forPackage("com.google.ads.googleads"))
-                .addScanners(new TypeAnnotationsScanner(), new SubTypesScanner()));
-    return reflections.getTypesAnnotatedWith(VersionDescriptor.class);
+    try {
+      Set<Class<?>> annotatedClasses =
+          ClassPath.from(ClassLoader.getSystemClassLoader())
+              .getTopLevelClassesRecursive("com.google.ads.googleads")
+              .stream()
+              .map(ClassInfo::load)
+              .filter(c -> c.getAnnotation(VersionDescriptor.class) != null)
+              .collect(Collectors.toSet());
+      // Verifies annotated classes were found.
+      Preconditions.checkState(
+          !annotatedClasses.isEmpty(),
+          "No types found with annotation: %s",
+          VersionDescriptor.class);
+      return annotatedClasses;
+    } catch (IOException e) {
+      throw new RuntimeException(
+          "Failed to find classes annotated with " + VersionDescriptor.class.getSimpleName(), e);
+    }
   }
 
   /** Pulls the @VersionDescriptor instance from annotated classes. */

google-ads-examples/build.gradle

@@ -46,7 +46,6 @@ dependencies {
   implementation 'com.beust:jcommander:1.72'
   implementation 'joda-time:joda-time:2.8.2'
   runtimeOnly 'org.apache.logging.log4j:log4j-slf4j-impl:2.16.0'
-  testImplementation 'org.reflections:reflections:0.9.11'
   testImplementation 'org.mockito:mockito-core:2.27.0'
   testImplementation 'org.hamcrest:hamcrest:2.2'
 }

google-ads-examples/src/test/java/com/google/ads/googleads/examples/utils/ValidateParametersTest.java

@@ -20,25 +20,45 @@
 import static org.junit.Assert.assertEquals;
 
 import com.beust.jcommander.Parameter;
+import com.google.common.collect.ImmutableList;
+import com.google.common.reflect.ClassPath;
+import com.google.common.reflect.ClassPath.ClassInfo;
+import java.io.IOException;
 import java.lang.reflect.Field;
 import java.lang.reflect.Modifier;
+import java.util.Arrays;
 import java.util.Set;
+import java.util.stream.Collectors;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
-import org.reflections.Reflections;
-import org.reflections.scanners.FieldAnnotationsScanner;
 
 @RunWith(JUnit4.class)
 public class ValidateParametersTest {
 
   @Test
-  public void ensure_no_final_parmeters() {
+  public void ensure_no_final_parameters() throws IOException {
     // Avoids silent failures from JCommander when parsing flags if the field is final.
-    Reflections reflections =
-        new Reflections("com.google.ads.googleads.examples", new FieldAnnotationsScanner());
-    Set<Field> annotatedFields = reflections.getFieldsAnnotatedWith(Parameter.class);
-    assertThat("parameters", annotatedFields.size(), is(greaterThan(0)));
+    Set<Field> annotatedFields =
+        ClassPath.from(getClass().getClassLoader())
+            .getTopLevelClassesRecursive("com.google.ads.googleads.examples")
+            .stream()
+            .map(ClassInfo::load)
+            .flatMap(
+                c ->
+                    ImmutableList.<Class<?>>builder()
+                        .add(c)
+                        .addAll(Arrays.asList(c.getDeclaredClasses()))
+                        .build()
+                        .stream())
+            .flatMap(c -> Arrays.stream(c.getDeclaredFields()))
+            .filter(f -> f.getAnnotation(Parameter.class) != null)
+            .collect(Collectors.toSet());
+
+    // Asserts that the above discovered at least 300 annotated fields. Examples contain closer to
+    // 400 such fields as of the writing of this test, but this leaves some room in case we decide
+    // to remove some examples.
+    assertThat("parameters", annotatedFields.size(), is(greaterThan(300)));
     for (Field field : annotatedFields) {
       assertEquals("field is final: " + field, 0, field.getModifiers() & Modifier.FINAL);
     }

third_party/LICENSES.html

@@ -121,30 +121,6 @@ <h3>License text URL</h3>
           <a href='http://www.apache.org/licenses/LICENSE-2.0.txt'>Show license agreement</a>
         </td>
       </tr>
-      <tr>
-        <td class='dependencies'>org.javassist:javassist:3.21.0-GA</td>
-        <td class='licenseName'>javassist-3.21.0-GA.jar</td>
-        <td class='licenseName'>MPL 1.1</td>
-        <td class='license'>
-          <a href='http://www.mozilla.org/MPL/MPL-1.1.html'>Show license agreement</a>
-        </td>
-      </tr>
-      <tr>
-        <td class='dependencies'>org.javassist:javassist:3.21.0-GA</td>
-        <td class='licenseName'>javassist-3.21.0-GA.jar</td>
-        <td class='licenseName'>LGPL 2.1</td>
-        <td class='license'>
-          <a href='http://www.gnu.org/licenses/lgpl-2.1.html'>Show license agreement</a>
-        </td>
-      </tr>
-      <tr>
-        <td class='dependencies'>org.javassist:javassist:3.21.0-GA</td>
-        <td class='licenseName'>javassist-3.21.0-GA.jar</td>
-        <td class='licenseName'>Apache License 2.0</td>
-        <td class='license'>
-          <a href='http://www.apache.org/licenses/'>Show license agreement</a>
-        </td>
-      </tr>
       <tr>
         <td class='dependencies'>com.google.protobuf:protobuf-java-util:3.18.1</td>
         <td class='licenseName'>protobuf-java-util-3.18.1.jar</td>
@@ -201,22 +177,6 @@ <h3>License text URL</h3>
           <a href='https://raw.githubusercontent.com/ThreeTen/threetenbp/master/LICENSE.txt'>Show license agreement</a>
         </td>
       </tr>
-      <tr>
-        <td class='dependencies'>org.reflections:reflections:0.9.11</td>
-        <td class='licenseName'>reflections-0.9.11.jar</td>
-        <td class='licenseName'>WTFPL</td>
-        <td class='license'>
-          <a href='http://www.wtfpl.net/'>Show license agreement</a>
-        </td>
-      </tr>
-      <tr>
-        <td class='dependencies'>org.reflections:reflections:0.9.11</td>
-        <td class='licenseName'>reflections-0.9.11.jar</td>
-        <td class='licenseName'>The New BSD License</td>
-        <td class='license'>
-          <a href='http://www.opensource.org/licenses/bsd-license.html'>Show license agreement</a>
-        </td>
-      </tr>
       <tr>
         <td class='dependencies'>com.google.guava:failureaccess:1.0.1</td>
         <td class='licenseName'>failureaccess-1.0.1.jar</td>

third_party/LICENSES.json

@@ -35,12 +35,6 @@
     <file>auto-service-1.0-rc2.jar</file>
     <license name='Apache 2.0' url='http://www.apache.org/licenses/LICENSE-2.0.txt' />
   </dependency>
-  <dependency name='org.javassist:javassist:3.21.0-GA'>
-    <file>javassist-3.21.0-GA.jar</file>
-    <license name='MPL 1.1' url='http://www.mozilla.org/MPL/MPL-1.1.html' />
-    <license name='LGPL 2.1' url='http://www.gnu.org/licenses/lgpl-2.1.html' />
-    <license name='Apache License 2.0' url='http://www.apache.org/licenses/' />
-  </dependency>
   <dependency name='com.google.protobuf:protobuf-java-util:3.18.1'>
     <file>protobuf-java-util-3.18.1.jar</file>
     <license name='3-Clause BSD License' url='https://opensource.org/licenses/BSD-3-Clause' />
@@ -69,11 +63,6 @@
     <file>threetenbp-1.5.1.jar</file>
     <license name='BSD 3-clause' url='https://raw.githubusercontent.com/ThreeTen/threetenbp/master/LICENSE.txt' />
   </dependency>
-  <dependency name='org.reflections:reflections:0.9.11'>
-    <file>reflections-0.9.11.jar</file>
-    <license name='WTFPL' url='http://www.wtfpl.net/' />
-    <license name='The New BSD License' url='http://www.opensource.org/licenses/bsd-license.html' />
-  </dependency>
   <dependency name='com.google.guava:failureaccess:1.0.1'>
     <file>failureaccess-1.0.1.jar</file>
     <license name='The Apache Software License, Version 2.0' url='http://www.apache.org/licenses/LICENSE-2.0.txt' />