Skip to content

Commit 85f5596

Browse files
PierrickVouletPierrickVoulet
authored
Use readable DateTime instead of milliseconds when generating names in examples
1 parent 40c384d commit 85f5596

44 files changed

Lines changed: 198 additions & 71 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/AddAdCustomizer.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package com.google.ads.googleads.examples.advancedoperations;
1616

17+
import static com.google.ads.googleads.examples.utils.CodeSampleHelper.getShortPrintableDateTime;
18+
1719
import com.beust.jcommander.Parameter;
1820
import com.google.ads.googleads.examples.utils.ArgumentNames;
1921
import com.google.ads.googleads.examples.utils.CodeSampleParams;
@@ -141,7 +143,7 @@ private void runExample(GoogleAdsClient googleAdsClient, AddAdCustomizerParams p
141143
"Please pass exactly two ad group IDs in the adGroupId parameter.");
142144
}
143145

144-
String feedName = "Ad Customizer example feed " + System.currentTimeMillis();
146+
String feedName = "Ad Customizer example feed " + getShortPrintableDateTime();
145147

146148
// Create a feed to be used as the ad customizer.
147149
String adCustomizerFeedResourceName =

‎google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/AddAppCampaign.java‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package com.google.ads.googleads.examples.advancedoperations;
1616

17+
import static com.google.ads.googleads.examples.utils.CodeSampleHelper.getPrintableDateTime;
18+
1719
import com.beust.jcommander.Parameter;
1820
import com.google.ads.googleads.examples.utils.ArgumentNames;
1921
import com.google.ads.googleads.examples.utils.CodeSampleParams;
@@ -141,7 +143,7 @@ private String createBudget(GoogleAdsClient googleAdsClient, long customerId) {
141143
// Creates a campaign budget.
142144
CampaignBudget campaignBudget =
143145
CampaignBudget.newBuilder()
144-
.setName("Interplanetary Cruise #" + System.currentTimeMillis())
146+
.setName("Interplanetary Cruise #" + getPrintableDateTime())
145147
.setAmountMicros(50_000_000)
146148
.setDeliveryMethod(BudgetDeliveryMethod.STANDARD)
147149
// An App campaign cannot use a shared campaign budget.
@@ -180,7 +182,7 @@ private String createCampaign(
180182
// Creates a campaign.
181183
Campaign campaign =
182184
Campaign.newBuilder()
183-
.setName("Interplanetary Cruise App #" + System.currentTimeMillis())
185+
.setName("Interplanetary Cruise App #" + getPrintableDateTime())
184186
.setCampaignBudget(budgetResourceName)
185187
// Recommendation: Set the campaign to PAUSED when creating it to prevent
186188
// the ads from immediately serving. Set to ENABLED once you've added
@@ -339,7 +341,7 @@ private String createAdGroup(
339341
// 2. you cannot add ad group criteria.
340342
AdGroup adGroup =
341343
AdGroup.newBuilder()
342-
.setName("Earth to Mars cruises #" + System.currentTimeMillis())
344+
.setName("Earth to Mars cruises #" + getPrintableDateTime())
343345
.setStatus(AdGroupStatus.ENABLED)
344346
.setCampaign(campaignResourceName)
345347
.build();

‎google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/AddDynamicPageFeed.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package com.google.ads.googleads.examples.advancedoperations;
1616

17+
import static com.google.ads.googleads.examples.utils.CodeSampleHelper.getPrintableDateTime;
18+
1719
import com.beust.jcommander.Parameter;
1820
import com.google.ads.googleads.examples.utils.ArgumentNames;
1921
import com.google.ads.googleads.examples.utils.CodeSampleParams;
@@ -173,7 +175,7 @@ private static String createFeed(GoogleAdsClient googleAdsClient, long customerI
173175
// Creates the feed.
174176
Feed feed =
175177
Feed.newBuilder()
176-
.setName("DSA Feed #" + System.currentTimeMillis())
178+
.setName("DSA Feed #" + getPrintableDateTime())
177179
.addAllAttributes(ImmutableList.of(urlAttribute, labelAttribute))
178180
.build();
179181

‎google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/AddDynamicSearchAds.java‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package com.google.ads.googleads.examples.advancedoperations;
1616

17+
import static com.google.ads.googleads.examples.utils.CodeSampleHelper.getPrintableDateTime;
18+
1719
import com.beust.jcommander.Parameter;
1820
import com.google.ads.googleads.examples.utils.ArgumentNames;
1921
import com.google.ads.googleads.examples.utils.CodeSampleParams;
@@ -131,7 +133,7 @@ private static String addCampaignBudget(GoogleAdsClient googleAdsClient, long cu
131133
// Creates the budget.
132134
CampaignBudget campaignBudget =
133135
CampaignBudget.newBuilder()
134-
.setName("Interplanetary Cruise Budget #" + System.currentTimeMillis())
136+
.setName("Interplanetary Cruise Budget #" + getPrintableDateTime())
135137
.setAmountMicros(3_000_000)
136138
.setDeliveryMethod(BudgetDeliveryMethod.STANDARD)
137139
.build();
@@ -168,7 +170,7 @@ private static String addCampaign(
168170
// Creates the campaign.
169171
Campaign campaign =
170172
Campaign.newBuilder()
171-
.setName("Interplanetary Cruise #" + System.currentTimeMillis())
173+
.setName("Interplanetary Cruise #" + getPrintableDateTime())
172174
.setAdvertisingChannelType(AdvertisingChannelType.SEARCH)
173175
.setStatus(CampaignStatus.PAUSED)
174176
.setManualCpc(ManualCpc.newBuilder().build())
@@ -216,7 +218,7 @@ private static String addAdGroup(
216218
// Creates the ad group.
217219
AdGroup adGroup =
218220
AdGroup.newBuilder()
219-
.setName("Earth to Mars Cruises #" + System.currentTimeMillis())
221+
.setName("Earth to Mars Cruises #" + getPrintableDateTime())
220222
.setCampaign(campaignResourceName)
221223
.setType(AdGroupType.SEARCH_DYNAMIC_ADS)
222224
.setStatus(AdGroupStatus.PAUSED)

‎google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/AddGmailAd.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package com.google.ads.googleads.examples.advancedoperations;
1616

17+
import static com.google.ads.googleads.examples.utils.CodeSampleHelper.getPrintableDateTime;
18+
1719
import com.beust.jcommander.Parameter;
1820
import com.google.ads.googleads.examples.utils.ArgumentNames;
1921
import com.google.ads.googleads.examples.utils.CodeSampleParams;
@@ -214,7 +216,7 @@ private void addGmailAd(
214216
// Creates the ad.
215217
Ad ad =
216218
Ad.newBuilder()
217-
.setName("Gmail Ad #" + System.currentTimeMillis())
219+
.setName("Gmail Ad #" + getPrintableDateTime())
218220
.addFinalUrls("http://www.example.com")
219221
.setGmailAd(gmailAdInfo)
220222
.build();

‎google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/AddLocalCampaign.java‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package com.google.ads.googleads.examples.advancedoperations;
1616

17+
import static com.google.ads.googleads.examples.utils.CodeSampleHelper.getPrintableDateTime;
18+
1719
import com.beust.jcommander.Parameter;
1820
import com.google.ads.googleads.examples.utils.ArgumentNames;
1921
import com.google.ads.googleads.examples.utils.CodeSampleParams;
@@ -146,7 +148,7 @@ private String createCampaignBudget(GoogleAdsClient googleAdsClient, long custom
146148
CampaignBudget budget =
147149
CampaignBudget.newBuilder()
148150
.setAmountMicros(50000000)
149-
.setName("Interplanetary Cruise Budget #" + System.currentTimeMillis())
151+
.setName("Interplanetary Cruise Budget #" + getPrintableDateTime())
150152
.setDeliveryMethod(BudgetDeliveryMethod.STANDARD)
151153
// A Local campaign cannot use a shared campaign budget.
152154
.setExplicitlyShared(false)
@@ -177,7 +179,7 @@ private String createLocalCampaign(
177179
// Creates a Campaign object.
178180
Campaign campaign =
179181
Campaign.newBuilder()
180-
.setName("Interplanetary Cruise Budget #" + System.currentTimeMillis())
182+
.setName("Interplanetary Cruise Budget #" + getPrintableDateTime())
181183
.setCampaignBudget(budgetResourceName)
182184
// Recommendation: Set the campaign to PAUSED when creating it to prevent the ads from
183185
// immediately serving. Set to ENABLED once you've added targeting and the ads are ready
@@ -241,7 +243,7 @@ private String createAdGroup(
241243
// 2. you cannot add ad group criteria.
242244
AdGroup adGroup =
243245
AdGroup.newBuilder()
244-
.setName("Earth to Mars Cruises #" + System.currentTimeMillis())
246+
.setName("Earth to Mars Cruises #" + getPrintableDateTime())
245247
.setStatus(AdGroupStatus.ENABLED)
246248
.setCampaign(campaignResourceName)
247249
.build();

‎google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/AddSmartDisplayAd.java‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package com.google.ads.googleads.examples.advancedoperations;
1616

17+
import static com.google.ads.googleads.examples.utils.CodeSampleHelper.getPrintableDateTime;
18+
1719
import com.beust.jcommander.Parameter;
1820
import com.google.ads.googleads.examples.utils.ArgumentNames;
1921
import com.google.ads.googleads.examples.utils.CodeSampleParams;
@@ -180,7 +182,7 @@ private static String createCampaignBudget(GoogleAdsClient googleAdsClient, long
180182
// Creates the budget.
181183
CampaignBudget campaignBudget =
182184
CampaignBudget.newBuilder()
183-
.setName("Interplanetary Cruise Budget #" + System.currentTimeMillis())
185+
.setName("Interplanetary Cruise Budget #" + getPrintableDateTime())
184186
.setAmountMicros(5_000_000)
185187
.setDeliveryMethod(BudgetDeliveryMethod.STANDARD)
186188
.build();
@@ -218,7 +220,7 @@ private static String createSmartDisplayCampaign(
218220
// Creates the campaign.
219221
Campaign campaign =
220222
Campaign.newBuilder()
221-
.setName("Smart Display Campaign #" + System.currentTimeMillis())
223+
.setName("Smart Display Campaign #" + getPrintableDateTime())
222224
// Smart Display campaign requires the advertising channel type as 'DISPLAY'.
223225
.setAdvertisingChannelType(AdvertisingChannelType.DISPLAY)
224226
// Smart Display campaign requires the advertising channel sub type as
@@ -267,7 +269,7 @@ private static String createAdGroup(
267269
// Creates the ad group.
268270
AdGroup adGroup =
269271
AdGroup.newBuilder()
270-
.setName("Earth to Mars Cruises #" + System.currentTimeMillis())
272+
.setName("Earth to Mars Cruises #" + getPrintableDateTime())
271273
.setCampaign(campaignResourceName)
272274
.setStatus(AdGroupStatus.PAUSED)
273275
.build();

‎google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/CreateAndAttachSharedKeywordSet.java‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package com.google.ads.googleads.examples.advancedoperations;
1616

17+
import static com.google.ads.googleads.examples.utils.CodeSampleHelper.getPrintableDateTime;
18+
1719
import com.beust.jcommander.Parameter;
1820
import com.google.ads.googleads.examples.utils.ArgumentNames;
1921
import com.google.ads.googleads.examples.utils.CodeSampleParams;
@@ -113,7 +115,7 @@ private void runExample(GoogleAdsClient googleAdsClient, long customerId, long c
113115
// Creates shared negative keyword set.
114116
SharedSet sharedSet =
115117
SharedSet.newBuilder()
116-
.setName("API Negative keyword list - " + System.currentTimeMillis())
118+
.setName("API Negative keyword list - " + getPrintableDateTime())
117119
.setType(SharedSetType.NEGATIVE_KEYWORDS)
118120
.build();
119121

‎google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/UsePortfolioBiddingStrategy.java‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package com.google.ads.googleads.examples.advancedoperations;
1616

17+
import static com.google.ads.googleads.examples.utils.CodeSampleHelper.getPrintableDateTime;
18+
1719
import com.beust.jcommander.Parameter;
1820
import com.google.ads.googleads.examples.utils.ArgumentNames;
1921
import com.google.ads.googleads.examples.utils.CodeSampleParams;
@@ -139,7 +141,7 @@ private String createBiddingStrategy(GoogleAdsClient googleAdsClient, long custo
139141
TargetSpend targetSpend = TargetSpend.newBuilder().setCpcBidCeilingMicros(2_000_000L).build();
140142
BiddingStrategy portfolioBiddingStrategy =
141143
BiddingStrategy.newBuilder()
142-
.setName("Maximize Clicks #" + System.currentTimeMillis())
144+
.setName("Maximize Clicks #" + getPrintableDateTime())
143145
.setTargetSpend(targetSpend)
144146
.build();
145147
// Constructs an operation that will create a portfolio bidding strategy.
@@ -175,7 +177,7 @@ private String createSharedCampaignBudget(GoogleAdsClient googleAdsClient, long
175177
// Creates a shared budget.
176178
CampaignBudget budget =
177179
CampaignBudget.newBuilder()
178-
.setName("Shared Interplanetary Budget #" + System.currentTimeMillis())
180+
.setName("Shared Interplanetary Budget #" + getPrintableDateTime())
179181
.setAmountMicros(50_000_000L)
180182
.setDeliveryMethod(BudgetDeliveryMethod.STANDARD)
181183
.setExplicitlyShared(true)
@@ -225,7 +227,7 @@ private String createCampaignWithBiddingStrategy(
225227
// [START UsePortfolioBiddingStrategy_2]
226228
Campaign campaign =
227229
Campaign.newBuilder()
228-
.setName("Interplanetary Cruise #" + System.currentTimeMillis())
230+
.setName("Interplanetary Cruise #" + getPrintableDateTime())
229231
.setStatus(CampaignStatus.PAUSED)
230232
.setCampaignBudget(campaignBudgetResourceName)
231233
.setBiddingStrategy(biddingStrategyResourceName)

‎google-ads-examples/src/main/java/com/google/ads/googleads/examples/basicoperations/AddAdGroups.java‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@
1414

1515
package com.google.ads.googleads.examples.basicoperations;
1616

17+
import static com.google.ads.googleads.examples.utils.CodeSampleHelper.getPrintableDateTime;
18+
1719
import com.beust.jcommander.Parameter;
1820
import com.google.ads.googleads.examples.utils.ArgumentNames;
1921
import com.google.ads.googleads.examples.utils.CodeSampleParams;
@@ -99,7 +101,7 @@ private void runExample(GoogleAdsClient googleAdsClient, long customerId, long c
99101
// Creates an ad group, setting an optional CPC value.
100102
AdGroup adGroup1 =
101103
AdGroup.newBuilder()
102-
.setName("Earth to Mars Cruises #" + System.currentTimeMillis())
104+
.setName("Earth to Mars Cruises #" + getPrintableDateTime())
103105
.setStatus(AdGroupStatus.ENABLED)
104106
.setCampaign(campaignResourceName)
105107
.setType(AdGroupType.SEARCH_STANDARD)
@@ -109,7 +111,7 @@ private void runExample(GoogleAdsClient googleAdsClient, long customerId, long c
109111
// You may add as many additional ad groups as you need.
110112
AdGroup adGroup2 =
111113
AdGroup.newBuilder()
112-
.setName("Earth to Venus Cruises #" + System.currentTimeMillis())
114+
.setName("Earth to Venus Cruises #" + getPrintableDateTime())
113115
.setStatus(AdGroupStatus.ENABLED)
114116
.setCampaign(campaignResourceName)
115117
.setType(AdGroupType.SEARCH_STANDARD)

0 commit comments

Comments
 (0)