Skip to content

Commit a2d9e7b

Browse files
authored
Modify customer negative criterion resource name methods to use singular form, deprecate the method that uses plural form (#288)
1 parent c92175d commit a2d9e7b

3 files changed

Lines changed: 33 additions & 2 deletions

File tree

google-ads/src/main/java/com/google/ads/googleads/v1/utils/ResourceNames.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,12 +407,23 @@ public static String customerManagerLink(
407407
String.valueOf(customerId), concatIdentifiers(managerCustomerId, managerLinkId));
408408
}
409409

410-
/** Returns the customer negative criterion for the specified components. */
410+
/**
411+
* Returns the customer negative criterion for the specified components.
412+
*
413+
* @deprecated use {@link #customerNegativeCriterion(long, long)} instead.
414+
*/
415+
@Deprecated
411416
public static String customerNegativeCriteria(long customerId, long criterionId) {
412417
return CustomerNegativeCriteriaName.format(
413418
String.valueOf(customerId), String.valueOf(criterionId));
414419
}
415420

421+
/** Returns the customer negative criterion for the specified components. */
422+
public static String customerNegativeCriterion(long customerId, long criterionId) {
423+
return CustomerNegativeCriteriaName.format(
424+
String.valueOf(customerId), String.valueOf(criterionId));
425+
}
426+
416427
/** Returns the detail placement view for the specified components. */
417428
public static String detailPlacementView(
418429
long customerId, long adGroupId, String placementBase64) {

google-ads/src/main/java/com/google/ads/googleads/v2/utils/ResourceNames.java

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,12 +423,23 @@ public static String customerManagerLink(
423423
String.valueOf(customerId), concatIdentifiers(managerCustomerId, managerLinkId));
424424
}
425425

426-
/** Returns the customer negative criterion for the specified components. */
426+
/**
427+
* Returns the customer negative criterion for the specified components.
428+
*
429+
* @deprecated use {@link #customerNegativeCriterion(long, long)} instead.
430+
*/
431+
@Deprecated
427432
public static String customerNegativeCriteria(long customerId, long criterionId) {
428433
return CustomerNegativeCriteriaName.format(
429434
String.valueOf(customerId), String.valueOf(criterionId));
430435
}
431436

437+
/** Returns the customer negative criterion for the specified components. */
438+
public static String customerNegativeCriterion(long customerId, long criterionId) {
439+
return CustomerNegativeCriteriaName.format(
440+
String.valueOf(customerId), String.valueOf(criterionId));
441+
}
442+
432443
/** Returns the detail placement view for the specified components. */
433444
public static String detailPlacementView(
434445
long customerId, long adGroupId, String placementBase64) {

google-ads/src/main/java/com/google/ads/googleads/v3/utils/ResourceNames.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -529,12 +529,21 @@ public static String customerManagerLink(
529529

530530
/**
531531
* Returns the customer negative criterion for the specified components.
532+
*
533+
* @deprecated use {@link #customerNegativeCriterion(long, long)} instead.
532534
*/
535+
@Deprecated
533536
public static String customerNegativeCriteria(long customerId, long criterionId) {
534537
return CustomerNegativeCriteriaName.format(
535538
String.valueOf(customerId), String.valueOf(criterionId));
536539
}
537540

541+
/** Returns the customer negative criterion for the specified components. */
542+
public static String customerNegativeCriterion(long customerId, long criterionId) {
543+
return CustomerNegativeCriteriaName.format(
544+
String.valueOf(customerId), String.valueOf(criterionId));
545+
}
546+
538547
/**
539548
* Returns the detail placement view for the specified components.
540549
*/

0 commit comments

Comments
 (0)