Skip to content

Commit b5440de

Browse files
authored
Gen lib with new generator, method signature changes (#310)
The library is now generated with a new build system. A side effect of that change is that certain overloaded method signatures containing boolean flags for making requests have been removed.
1 parent 1456d89 commit b5440de

11,412 files changed

Lines changed: 397922 additions & 495468 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

google-ads-examples/src/main/java/com/google/ads/googleads/examples/accountmanagement/GetAccountHierarchy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import com.google.ads.googleads.v4.errors.GoogleAdsError;
2222
import com.google.ads.googleads.v4.errors.GoogleAdsException;
2323
import com.google.ads.googleads.v4.resources.CustomerClient;
24-
import com.google.ads.googleads.v4.resources.CustomerName;
24+
import com.google.ads.googleads.v4.services.CustomerName;
2525
import com.google.ads.googleads.v4.services.CustomerServiceClient;
2626
import com.google.ads.googleads.v4.services.GoogleAdsRow;
2727
import com.google.ads.googleads.v4.services.GoogleAdsServiceClient;

google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/AddAdGroupBidModifier.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
import com.google.ads.googleads.v4.errors.GoogleAdsError;
2424
import com.google.ads.googleads.v4.errors.GoogleAdsException;
2525
import com.google.ads.googleads.v4.resources.AdGroupBidModifier;
26-
import com.google.ads.googleads.v4.resources.AdGroupName;
2726
import com.google.ads.googleads.v4.services.AdGroupBidModifierOperation;
2827
import com.google.ads.googleads.v4.services.AdGroupBidModifierServiceClient;
28+
import com.google.ads.googleads.v4.services.AdGroupName;
2929
import com.google.ads.googleads.v4.services.MutateAdGroupBidModifierResult;
3030
import com.google.ads.googleads.v4.services.MutateAdGroupBidModifiersResponse;
3131
import com.google.common.collect.ImmutableList;

google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/CreateAndAttachSharedKeywordSet.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323
import com.google.ads.googleads.v4.enums.SharedSetTypeEnum.SharedSetType;
2424
import com.google.ads.googleads.v4.errors.GoogleAdsError;
2525
import com.google.ads.googleads.v4.errors.GoogleAdsException;
26-
import com.google.ads.googleads.v4.resources.CampaignName;
2726
import com.google.ads.googleads.v4.resources.CampaignSharedSet;
2827
import com.google.ads.googleads.v4.resources.SharedCriterion;
2928
import com.google.ads.googleads.v4.resources.SharedSet;
29+
import com.google.ads.googleads.v4.services.CampaignName;
3030
import com.google.ads.googleads.v4.services.CampaignSharedSetOperation;
3131
import com.google.ads.googleads.v4.services.CampaignSharedSetServiceClient;
3232
import com.google.ads.googleads.v4.services.MutateCampaignSharedSetsResponse;

google-ads-examples/src/main/java/com/google/ads/googleads/examples/advancedoperations/UsePortfolioBiddingStrategy.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@
2828
import com.google.ads.googleads.v4.resources.Campaign;
2929
import com.google.ads.googleads.v4.resources.Campaign.NetworkSettings;
3030
import com.google.ads.googleads.v4.resources.CampaignBudget;
31-
import com.google.ads.googleads.v4.resources.CampaignBudgetName;
3231
import com.google.ads.googleads.v4.services.BiddingStrategyOperation;
3332
import com.google.ads.googleads.v4.services.BiddingStrategyServiceClient;
33+
import com.google.ads.googleads.v4.services.CampaignBudgetName;
3434
import com.google.ads.googleads.v4.services.CampaignBudgetOperation;
3535
import com.google.ads.googleads.v4.services.CampaignBudgetServiceClient;
3636
import com.google.ads.googleads.v4.services.CampaignOperation;

google-ads-examples/src/main/java/com/google/ads/googleads/examples/campaignmanagement/ValidateTextAd.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
import com.google.ads.googleads.v4.resources.AdGroupAd;
2929
import com.google.ads.googleads.v4.services.AdGroupAdOperation;
3030
import com.google.ads.googleads.v4.services.AdGroupAdServiceClient;
31+
import com.google.ads.googleads.v4.services.MutateAdGroupAdsRequest;
3132
import com.google.ads.googleads.v4.services.MutateAdGroupAdsResponse;
3233
import com.google.ads.googleads.v4.utils.ResourceNames;
3334
import com.google.common.collect.ImmutableList;
@@ -133,8 +134,11 @@ private void runExample(GoogleAdsClient googleAdsClient, long customerId, long a
133134
// Issues the mutate request setting validateOnly=true.
134135
MutateAdGroupAdsResponse response =
135136
adGroupAdServiceClient.mutateAdGroupAds(
136-
Long.toString(customerId), ImmutableList.of(operation), false, true);
137-
137+
MutateAdGroupAdsRequest.newBuilder()
138+
.setCustomerId(Long.toString(customerId))
139+
.addOperations(operation)
140+
.setValidateOnly(true)
141+
.build());
138142
// Since validation is ON, result will be null.
139143
System.out.println("Expanded text ad validated successfully.");
140144
} catch (GoogleAdsException e) {

google-ads-examples/src/main/java/com/google/ads/googleads/examples/errorhandling/HandlePartialFailure.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.google.ads.googleads.v4.services.AdGroupOperation;
2525
import com.google.ads.googleads.v4.services.AdGroupServiceClient;
2626
import com.google.ads.googleads.v4.services.MutateAdGroupResult;
27+
import com.google.ads.googleads.v4.services.MutateAdGroupsRequest;
2728
import com.google.ads.googleads.v4.services.MutateAdGroupsResponse;
2829
import com.google.ads.googleads.v4.utils.ErrorUtils;
2930
import com.google.ads.googleads.v4.utils.ResourceNames;
@@ -142,12 +143,11 @@ private MutateAdGroupsResponse createAdGroups(
142143
googleAdsClient.getLatestVersion().createAdGroupServiceClient()) {
143144
// Issues the mutate request, setting partialFailure=true.
144145
return service.mutateAdGroups(
145-
String.valueOf(customerId),
146-
Arrays.asList(op1, op2, op3),
147-
// Sets partial failure to true.
148-
true,
149-
// Sets validate only to false.
150-
false);
146+
MutateAdGroupsRequest.newBuilder()
147+
.setCustomerId(Long.toString(customerId))
148+
.addAllOperations(Arrays.asList(op1, op2, op3))
149+
.setPartialFailure(true)
150+
.build());
151151
}
152152
}
153153

google-ads-examples/src/main/java/com/google/ads/googleads/examples/remarketing/AddCustomerMatchUserList.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
import com.google.ads.googleads.v4.errors.GoogleAdsException;
3030
import com.google.ads.googleads.v4.resources.OfflineUserDataJob;
3131
import com.google.ads.googleads.v4.resources.UserList;
32+
import com.google.ads.googleads.v4.services.AddOfflineUserDataJobOperationsRequest;
3233
import com.google.ads.googleads.v4.services.AddOfflineUserDataJobOperationsResponse;
3334
import com.google.ads.googleads.v4.services.CreateOfflineUserDataJobResponse;
3435
import com.google.ads.googleads.v4.services.GoogleAdsRow;
@@ -222,10 +223,11 @@ private void addUsersToCustomerMatchUserList(
222223
List<OfflineUserDataJobOperation> userDataJobOperations = buildOfflineUserDataJobOperations();
223224
AddOfflineUserDataJobOperationsResponse response =
224225
offlineUserDataJobServiceClient.addOfflineUserDataJobOperations(
225-
offlineUserDataJobResourceName,
226-
// Enables partial failure.
227-
BoolValue.of(true),
228-
userDataJobOperations);
226+
AddOfflineUserDataJobOperationsRequest.newBuilder()
227+
.setResourceName(offlineUserDataJobResourceName)
228+
.setEnablePartialFailure(BoolValue.of(true))
229+
.addAllOperations(userDataJobOperations)
230+
.build());
229231

230232
// Prints the status message if any partial failure error is returned.
231233
// NOTE: The details of each partial failure error are not printed here, you can refer to

google-ads-examples/src/main/java/com/google/ads/googleads/examples/remarketing/UploadCallConversion.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.google.ads.googleads.v4.services.CallConversion;
2424
import com.google.ads.googleads.v4.services.CallConversionResult;
2525
import com.google.ads.googleads.v4.services.ConversionUploadServiceClient;
26+
import com.google.ads.googleads.v4.services.UploadCallConversionsRequest;
2627
import com.google.ads.googleads.v4.services.UploadCallConversionsResponse;
2728
import com.google.common.collect.ImmutableList;
2829
import com.google.protobuf.DoubleValue;
@@ -145,7 +146,11 @@ private void runExample(
145146
// Partial failure MUST be enabled for this request.
146147
UploadCallConversionsResponse response =
147148
conversionUploadServiceClient.uploadCallConversions(
148-
String.valueOf(customerId), ImmutableList.of(conversion), true, false);
149+
UploadCallConversionsRequest.newBuilder()
150+
.setCustomerId(Long.toString(customerId))
151+
.addConversions(conversion)
152+
.setPartialFailure(true)
153+
.build());
149154

150155
// Prints any partial failure errors returned.
151156
if (response.hasPartialFailureError()) {

google-ads-examples/src/main/java/com/google/ads/googleads/examples/remarketing/UploadConversionAdjustment.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import com.google.ads.googleads.v4.services.ConversionAdjustmentUploadServiceClient;
2727
import com.google.ads.googleads.v4.services.GclidDateTimePair;
2828
import com.google.ads.googleads.v4.services.RestatementValue;
29+
import com.google.ads.googleads.v4.services.UploadConversionAdjustmentsRequest;
2930
import com.google.ads.googleads.v4.services.UploadConversionAdjustmentsResponse;
3031
import com.google.ads.googleads.v4.utils.ResourceNames;
3132
import com.google.common.collect.ImmutableList;
@@ -197,12 +198,12 @@ private void runExample(
197198
// Uploads the click conversion. Partial failure should always be set to true.
198199
UploadConversionAdjustmentsResponse response =
199200
conversionUploadServiceClient.uploadConversionAdjustments(
200-
Long.toString(customerId),
201-
ImmutableList.of(conversionAdjustment),
202-
// Enables partial failure (must be true).
203-
true,
204-
// Disables validate only.
205-
false);
201+
UploadConversionAdjustmentsRequest.newBuilder()
202+
.setCustomerId(Long.toString(customerId))
203+
.addConversionAdjustments(conversionAdjustment)
204+
// Enables partial failure (must be true).
205+
.setPartialFailure(true)
206+
.build());
206207

207208
// Prints any partial errors returned.
208209
if (response.hasPartialFailureError()) {

google-ads-examples/src/main/java/com/google/ads/googleads/examples/remarketing/UploadOfflineConversion.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import com.google.ads.googleads.v4.services.ClickConversion;
2525
import com.google.ads.googleads.v4.services.ClickConversionResult;
2626
import com.google.ads.googleads.v4.services.ConversionUploadServiceClient;
27+
import com.google.ads.googleads.v4.services.UploadClickConversionsRequest;
2728
import com.google.ads.googleads.v4.services.UploadClickConversionsResponse;
2829
import com.google.common.collect.ImmutableList;
2930
import com.google.protobuf.DoubleValue;
@@ -143,12 +144,12 @@ private void runExample(
143144
// Uploads the click conversion. Partial failure should always be set to true.
144145
UploadClickConversionsResponse response =
145146
conversionUploadServiceClient.uploadClickConversions(
146-
Long.toString(customerId),
147-
ImmutableList.of(clickConversion),
148-
// Enables partial failure (must be true).
149-
true,
150-
// Disables validate only.
151-
false);
147+
UploadClickConversionsRequest.newBuilder()
148+
.setCustomerId(Long.toString(customerId))
149+
.addConversions(clickConversion)
150+
// Enables partial failure (must be true).
151+
.setPartialFailure(true)
152+
.build());
152153

153154
// Prints any partial errors returned.
154155
if (response.hasPartialFailureError()) {

0 commit comments

Comments
 (0)