Skip to content

Commit f47c001

Browse files
authored
Bump GAX to 1.63.0 (#428)
1 parent ad27411 commit f47c001

3 files changed

Lines changed: 7 additions & 8 deletions

File tree

buildSrc/src/main/groovy/com.google.api-ads.java-conventions.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,9 @@ tasks.withType(JavaCompile) {
5050
dependencies {
5151
implementation 'com.google.guava:guava:30.0-android'
5252
implementation 'com.google.auto.service:auto-service:1.0-rc2'
53-
implementation 'com.google.api:gax:1.60.1'
54-
implementation 'com.google.api:gax-grpc:1.60.1'
55-
implementation 'com.google.protobuf:protobuf-java:3.12.0'
53+
implementation 'com.google.api:gax:1.63.0'
54+
implementation 'com.google.api:gax-grpc:1.63.0'
55+
implementation 'com.google.protobuf:protobuf-java:3.14.0'
5656
annotationProcessor 'com.google.auto.service:auto-service:1.0-rc2'
5757
testImplementation 'junit:junit:4.13.1'
5858
}

google-ads-examples/src/main/java/com/google/ads/googleads/examples/extensions/AddSitelinksUsingFeeds.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
import java.util.ArrayList;
6161
import java.util.List;
6262
import java.util.stream.Collectors;
63-
import org.apache.commons.lang3.StringUtils;
6463

6564
/**
6665
* Adds sitelinks to a campaign using feed services. To create a campaign, run AddCampaigns.java.
@@ -379,11 +378,11 @@ private FeedItemOperation createFeedItemOperation(
379378
private void createCampaignFeed(
380379
GoogleAdsClient googleAdsClient, long customerId, Feed feed, long campaignId) {
381380
// Creates a comma separated list of feed attribute IDs for the matching function.
382-
List<Long> feedAttributesIds =
381+
List<String> feedAttributesIds =
383382
feed.getAttributesList().stream()
384-
.map(feedAttribute -> feedAttribute.getId())
383+
.map(feedAttribute -> String.valueOf(feedAttribute.getId()))
385384
.collect(Collectors.toList());
386-
String feedAttributesString = StringUtils.join(feedAttributesIds, ",");
385+
String feedAttributesString = String.join( ",", feedAttributesIds);
387386

388387
// Creates the campaign feed.
389388
CampaignFeed campaignFeed =

google-ads/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<auto-value.version>1.7.3</auto-value.version>
3737
<!-- Keep all versions below consistent with the io.netty version. -->
3838
<netty.version>2.0.26.Final</netty.version>
39-
<gax.version>1.60.1</gax.version>
39+
<gax.version>1.63.0</gax.version>
4040
<grpc.version>1.30.0</grpc.version>
4141
<protobuf.version>3.12.2</protobuf.version>
4242
</properties>

0 commit comments

Comments
 (0)