The following code:
|
if (count($methodSignatureArguments) !== $requiredFields->count()) { |
|
throw new \LogicException(sprintf( |
|
'missing method signature arguments (Expected "%s", found %s)', |
|
$methodSignature, |
|
implode(',', $requiredFields->map(fn ($f) => $f->name)->toArray()) ?: 'none' |
|
)); |
|
} |
Does not account for a signature like "foo.a,foo.b" where foo is a google.api.field_behavior = REQUIRED field. The presence of foo.a should be sufficient.
Furthermore, we need to make sure that build fragment generation can handle a dot-notation signature!
The following code:
gapic-generator-php/src/Generation/BuildMethodFragmentGenerator.php
Lines 135 to 141 in 277c703
Does not account for a signature like
"foo.a,foo.b"wherefoois agoogle.api.field_behavior = REQUIREDfield. The presence offoo.ashould be sufficient.Furthermore, we need to make sure that
buildfragment generation can handle a dot-notation signature!