fix(firestore): respect ignoreUndefinedProperties in subpipelines (#8089)

Author: dlarocque

handwritten/firestore/dev/src/pipelines/expression.ts

@@ -10885,10 +10885,10 @@ class PipelineValueExpression extends Expression {
   /**
    * @internal
    */
-  _validateUserData(_ignoreUndefinedProperties: boolean): void {
+  _validateUserData(ignoreUndefinedProperties: boolean): void {
     // Casting to bypass type checking becuase _validateUserData does not exist in the public types
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    (this.pipeline as any)._validateUserData('PipelineValueExpression');
+    (this.pipeline as any)._validateUserData(ignoreUndefinedProperties);
   }
 }
 

handwritten/firestore/dev/system-test/pipeline.ts

@@ -6216,6 +6216,30 @@ describe.skipClassic('Pipeline class', () => {
       });
     });
 
+    it('PipelineValueExpression respects ignoreUndefinedProperties', async () => {
+      const firestore_2 = getTestDb({ignoreUndefinedProperties: false});
+
+      const subWithUndefined = firestore_2
+        .pipeline()
+        .collection('test')
+        .where(equal(field('title'), {title: undefined}));
+
+      try {
+        await firestore_2
+          .pipeline()
+          .collection(randomCol.path)
+          .addFields(subWithUndefined.toArrayExpression().as('reviewsData'))
+          .execute();
+
+        expect(false).to.be.true('should have thrown an error');
+      } catch (e: unknown) {
+        const err: Error = e as Error;
+        expect(err.message).to.contain(
+          'Cannot use "undefined" as a Firestore value',
+        );
+      }
+    });
+
     it('multiple array subqueries', async () => {
       const reviewsCollectionName = `reviews_multi_${Date.now()}`;
       const authorsCollectionName = `authors_multi_${Date.now()}`;