Skip to content

Commit fbb093c

Browse files
committed
fix scenario 4
1 parent 3528095 commit fbb093c

1 file changed

Lines changed: 2 additions & 17 deletions

File tree

handwritten/storage/conformance-test/libraryMethods.ts

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -416,16 +416,7 @@ export async function bucketMakePrivate(options: ConformanceTestOptions) {
416416
export async function bucketMakePublic(options: ConformanceTestOptions) {
417417
const requestOptions: StorageRequestOptions = {
418418
method: 'POST',
419-
url: `storage/v1/b/${encodeURIComponent(options.bucket!.name)}/acl`,
420-
body: JSON.stringify({
421-
entity: 'allUsers',
422-
role: 'READER',
423-
}),
424-
headers: {
425-
'Content-Type': 'application/json',
426-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
427-
'x-retry-test-id': (options as any).retryTestId,
428-
},
419+
url: `storage/v1/b/${encodeURIComponent(options.bucket!.name)}`,
429420
};
430421

431422
return await options.storageTransport!.makeRequest(requestOptions);
@@ -855,13 +846,8 @@ export async function fileMakePrivate(options: ConformanceTestOptions) {
855846
export async function fileMakePublic(options: ConformanceTestOptions) {
856847
const fileName = encodeURIComponent(options.file!.name);
857848
const requestOptions: StorageRequestOptions = {
858-
method: 'POST',
849+
method: 'PATCH',
859850
url: `storage/v1/b/${encodeURIComponent(options.bucket!.name)}/o/${fileName}/acl`,
860-
body: JSON.stringify({
861-
entity: 'allUsers',
862-
role: 'READER',
863-
}),
864-
headers: {'Content-Type': 'application/json'},
865851
};
866852

867853
return await options.storageTransport!.makeRequest(requestOptions);
@@ -1226,7 +1212,6 @@ export async function notificationCreate(options: ConformanceTestOptions) {
12261212
url: `storage/v1/b/${encodeURIComponent(options.bucket!.name)}/notificationConfigs`,
12271213
body: JSON.stringify({
12281214
topic: 'my-topic',
1229-
payload_format: 'JSON_API_V1',
12301215
}),
12311216
headers: {'Content-Type': 'application/json'},
12321217
};

0 commit comments

Comments
 (0)