Skip to content

Commit 0f996fc

Browse files
authored
chore: remove private key from fixture (#8675)
1 parent 81a39cc commit 0f996fc

2 files changed

Lines changed: 10 additions & 3 deletions

File tree

Core/tests/Unit/ClientTraitTest.php

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,11 @@ public function testConfigureAuthenticationWithKeyFilePath()
168168

169169
public function testIgnoreKeyFileWhenUsingCredentialsFetcher()
170170
{
171-
$credentials = new ServiceAccountCredentials([], Fixtures::SERVICE_ACCOUNT_FIXTURE());
171+
$keyFilePath = Fixtures::SERVICE_ACCOUNT_FIXTURE();
172+
$key = json_decode(file_get_contents($keyFilePath), true);
173+
$key['private_key'] = 'xxx';
174+
175+
$credentials = new ServiceAccountCredentials([], $key);
172176

173177
$conf = $this->impl->call('configureAuthentication', [[
174178
'credentialsFetcher' => $credentials,
@@ -179,7 +183,11 @@ public function testIgnoreKeyFileWhenUsingCredentialsFetcher()
179183

180184
public function testGetProjectIdFromCredentialsFetcher()
181185
{
182-
$credentials = new ServiceAccountCredentials([], Fixtures::SERVICE_ACCOUNT_FIXTURE());
186+
$keyFilePath = Fixtures::SERVICE_ACCOUNT_FIXTURE();
187+
$key = json_decode(file_get_contents($keyFilePath), true);
188+
$key['private_key'] = 'xxx';
189+
190+
$credentials = new ServiceAccountCredentials([], $key);
183191

184192
$this->impl->call('configureAuthentication', [[
185193
'credentialsFetcher' => $credentials,

Core/tests/Unit/fixtures/service-account-fixture.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
"type": "service_account",
33
"project_id": "example-project-12345",
44
"private_key_id": "1a2b3c4d5e6f7a8b9c0d1e2f3a4b5c6d7e8f9a0b",
5-
"private_key": "-----BEGIN PRIVATE KEY-----\nMIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQC4ziPSL1C/RTMN\nEUen4AyKlQf/W/X4XOtdOP0kBtrhwvFnCdWIc1mb4UjTE/vCCI94VHnDaktuQoFx\nQbMV3USDKYLtIf0wfEtBkucDBZLBDdBAhNCC5aWZWLAXJKw1lPofe8W5088WWjVs\n8Wl4Q6YooZeEYt1DNMnIqEAes4ftBW4V0WUf26YVye9z2p8R7tsI51Z0x0O3fb33\n4oqxmlyP2L/qeyjofFFFNHn25sbENUgO/2r5/qbIWZvlSK3UeHrBbfC3yBuq2wp+\nhHTVwKAgXVt0W5sJ9nw9tVvzoo1NjtSz/Suw83/0/lp1WnY6/qdnXSNXnAqKeP5Y\nMXZS7pM1AgMBAAECggEAL/dBEOK7AIoDcBbWFFpwpt97jenec7IaXL3X5ivpT8N7\nSJUi2SGnVnAoqLB9HaV/J2o1mGTUYy/bzPuScdBWYfy6QLYbsyPvnHt2fjBKINVn\nAff27qKQUrbULY2VLOsX6GgFr++rxk9vonEeQNq+G7mlS/UlHLZs0SnqSo2qb/gR\n1d7Q8lSa3U/5lEQkm7sSUmTUBSkFGSO1I9/1/TjbZ7RTirl3HHNlvdRsu0CiesRx\nPt0utn028cvkJYB0DvDNDqoRIfI6rgf1UPu4UtvFBiubv+eAr8qWc2+Abv0Gobow\nh9SsEJGgBUhiE/lvkilUBeHINUEdwmz/vpCKU15PmQKBgQDiH7HCQbDoZP9FTAOw\nF0gNttFyl/jfr/VR4gB00dPBa2s+SCcTakzw6US57ozQ5CsDpLYEzRvvPYm0z+zh\nuKKxvQsvVwVbyZFDXRn/fMit8eWt4A3yDeMd7Gn/PaiAnMRoOTeY8XgjB74ES9bR\nNDjTIvxbr1rmrb+APBr2B8/IbwKBgQDROOfRkNEdj2Xv1Vb+36/UyyFSY8I5+jdy\n/BIoN5/ywTju4Y2jNGcHPq1H8E+j5FSdKQYKtODURcASKmOwqq0uMOqwlP5l7/9Z\nu7FLQlT8mNTHQwt2IFtk2VEVRrxKSzidoennyq8JJRxYvtE4Ehte1DqFgxdYmqyE\nWNNGSs9ImwKBgQCgn3TskS8yFTQDLHjeJ9uF6lwjM3KUqm/vZ0N9t+LcXQqD5krj\njrny0zB/hsU+SSWI5AJrrKrwKV1dM+mHeVkQOkHssbrbtXXbTRH/mssOTGsjNKmT\nTGwNQHcW2NyN503Y3vPwT25QK9q9QIXqe1b2G774/bnrbHZAh/F63JerPwKBgD59\n58gRoFRa+5CaQWTZfVRq4+YPA/l7Qkqm/eljS/QfQJkhZ8PiqA9i6jD9l1wVnCxh\nD3vtMOZWexsx7Brdr+KHG+JobmAWQkgUJs2a33WfVJa78NV0rre9rVlUinMKaruy\nnAHu6T8rBX+AZ09/IQu/CkfMsxF1CahyO5DYUXeXAoGASocxulMRKaa3NbcsDl0t\nRK89ZgBxii6SgwvARpODTmsnGex5pNI6XVNCPcevyAhuWpoXPeEeg9Qj3FpyGTtz\nZUfKfFtFAAb3TU2C5PF0mTn+4vEL55YBXD4tfeimXzMhg/t2d6FP38g7wN2ejJPr\nBbFaAE9VZFi2OcxtIysoxek=\n-----END PRIVATE KEY-----\n",
65
"client_email": "test-service-account@example-project-12345.iam.gserviceaccount.com",
76
"client_id": "123456789012345678901",
87
"auth_uri": "https://accounts.google.com/o/oauth2/auth",

0 commit comments

Comments
 (0)