feat(Bigtable): validate row order (#8228)

Author: bshaffer

Bigtable/src/ChunkFormatter.php

@@ -17,6 +17,7 @@
 
 namespace Google\Cloud\Bigtable;
 
+use Google\ApiCore\ApiException;
 use Google\ApiCore\ArrayTrait;
 use Google\Cloud\Bigtable\Exception\BigtableDataOperationException;
 use Google\Cloud\Bigtable\V2\Client\BigtableClient as GapicClient;
@@ -25,6 +26,7 @@
 use Google\Cloud\Bigtable\V2\RowRange;
 use Google\Cloud\Bigtable\V2\RowSet;
 use Google\Protobuf\Internal\Message;
+use Google\Rpc\Code;
 
 /**
  * Converts cell chunks into an easily digestable format. Please note this class
@@ -370,6 +372,23 @@ private function reset()
     private function commit()
     {
         $rowKey = $this->rowKey;
+        if ($this->prevRowKey) {
+            // Validate that row keys are in ascending order
+            $cmp = strcmp($this->prevRowKey, $rowKey);
+            if ($this->request->getReversed()) {
+                $cmp *= -1;
+            }
+            if ($cmp >= 0) {
+                throw new ApiException(
+                    sprintf(
+                        'last scanned key must be strictly %s. New last scanned key=%s',
+                        $this->request->getReversed() ? 'decreasing' : 'increasing',
+                        $rowKey
+                    ),
+                    Code::INTERNAL
+                );
+            }
+        }
         $this->reset();
         $this->prevRowKey = $rowKey;
     }

Bigtable/tests/Conformance/proxy/known_failures.txt

@@ -2,7 +2,6 @@ _Retry_WithRoutingCookie
 _Retry_WithRetryInfo
 TestMutateRows_Generic_DeadlineExceeded
 TestReadRow_Generic_DeadlineExceeded
-TestReadRows_NoRetry_OutOfOrderError
 TestReadRows_Retry_StreamReset
 TestReadRows_Retry_PausedScan
 TestReadRows_Retry_LastScannedRow

Bigtable/tests/Conformance/proxy/src/ProxyService.php

@@ -200,19 +200,27 @@ public function ReadRows(GRPC\ContextInterface $ctx, Testproxy\ReadRowsRequest $
             'rowRanges' => $ranges,
             'filter' => $request->getFilter(),
             'rowsLimit' => $request->getRowsLimit(),
+            'reversed' => $request->getReversed(),
             'timeoutMillis' => $this->getTimeoutMillis($config->getPerOperationTimeout()),
         ]);
 
         $rows = [];
         $rowCount = 0;
         $cancelAfterRows = $in->getCancelAfterRows();
-        foreach ($stream as $key => $rowData) {
-            $row = $this->arrayToRowProto($rowData);
-            $row->setKey($key);
-            $rows[] = $row;
-            if ($cancelAfterRows && ++$rowCount >= $cancelAfterRows) {
-                break;
+        try {
+            foreach ($stream as $key => $rowData) {
+                $row = $this->arrayToRowProto($rowData);
+                $row->setKey($key);
+                $rows[] = $row;
+                if ($cancelAfterRows && ++$rowCount >= $cancelAfterRows) {
+                    break;
+                }
             }
+        } catch (\Google\ApiCore\ApiException $e) {
+            return $out->setStatus(new Status([
+                'code' => $e->getCode(),
+                'message' => $e->getMessage(),
+            ]));
         }
 
         $out->setRows($rows);