add typehints

Author: bshaffer

Spanner/src/ArrayType.php

@@ -69,7 +69,7 @@ class ArrayType
     /**
      * @var StructType|null
      */
-    private StringType|null $structType;
+    private StructType|null $structType;
 
     /**
      * @param int|string|null|StructType $type A value type code or nested struct

Spanner/src/Batch/BatchClient.php

@@ -173,7 +173,7 @@ public function __construct(Operation $operation, $databaseName, array $options
      * }
      * @return BatchSnapshot
      */
-    public function snapshot(array $options = [])
+    public function snapshot(array $options = []): BatchSnapshot
     {
         $options += [
             'transactionOptions' => [],
@@ -219,7 +219,7 @@ public function snapshot(array $options = [])
      * @param string $identifier A stringified representation of {@see \Google\Cloud\Spanner\Batch\BatchSnapshot}.
      * @return BatchSnapshot
      */
-    public function snapshotFromString($identifier)
+    public function snapshotFromString(string $identifier): BatchSnapshot
     {
         $data = json_decode(base64_decode($identifier), true);
         $missing = array_diff(
@@ -254,7 +254,7 @@ public function snapshotFromString($identifier)
      * @param string $partition Partition data
      * @return PartitionInterface
      */
-    public function partitionFromString($partition)
+    public function partitionFromString(string $partition): PartitionInterface
     {
         $data = json_decode(base64_decode($partition), true);
         if (!isset($data[self::PARTITION_TYPE_KEY])) {

Spanner/src/Batch/BatchSnapshot.php

@@ -131,7 +131,7 @@ public function close(array $options = [])
      * }
      * @return ReadPartition[]
      */
-    public function partitionRead($table, KeySet $keySet, array $columns, array $options = [])
+    public function partitionRead(string $table, KeySet $keySet, array $columns, array $options = []): array
     {
         return $this->operation->partitionRead(
             $this->session,
@@ -194,7 +194,7 @@ public function partitionRead($table, KeySet $keySet, array $columns, array $opt
      * }
      * @return QueryPartition[]
      */
-    public function partitionQuery($sql, array $options = [])
+    public function partitionQuery(string $sql, array $options = []): array
     {
         return $this->operation->partitionQuery(
             $this->session,
@@ -222,7 +222,7 @@ public function partitionQuery($sql, array $options = [])
      * @return Result
      * @throws \BadMethodCallException If an invalid partition type is given.
      */
-    public function executePartition(PartitionInterface $partition, array $options = [])
+    public function executePartition(PartitionInterface $partition, array $options = []): Result
     {
         if ($partition instanceof QueryPartition) {
             return $this->executeQuery($partition);
@@ -243,7 +243,7 @@ public function executePartition(PartitionInterface $partition, array $options =
      *
      * @return string
      */
-    public function serialize()
+    public function serialize(): string
     {
         return base64_encode(json_encode([
             'sessionName' => $this->session->name(),
@@ -269,7 +269,7 @@ public function __toString()
      * @param QueryPartition $partition The partition.
      * @return Result
      */
-    private function executeQuery(QueryPartition $partition)
+    private function executeQuery(QueryPartition $partition): Result
     {
         return $this->execute($partition->sql(), [
             'partitionToken' => $partition->token()
@@ -282,7 +282,7 @@ private function executeQuery(QueryPartition $partition)
      * @param ReadPartition $partition The partition.
      * @return Result
      */
-    private function executeRead(ReadPartition $partition)
+    private function executeRead(ReadPartition $partition): Result
     {
         return $this->read($partition->table(), $partition->keySet(), $partition->columns(), [
             'partitionToken' => $partition->token()

Spanner/src/Batch/PartitionTrait.php

@@ -25,12 +25,12 @@ trait PartitionTrait
     /**
      * @var string
      */
-    private $token;
+    private string $token;
 
     /**
      * @var array
      */
-    private $options;
+    private array $options;
 
     /**
      * Returns the partition token.
@@ -42,7 +42,7 @@ trait PartitionTrait
      *
      * @return string
      */
-    public function token()
+    public function token(): string
     {
         return $this->token;
     }
@@ -57,7 +57,7 @@ public function token()
      *
      * @return array
      */
-    public function options()
+    public function options(): array
     {
         return $this->options;
     }

Spanner/src/Batch/QueryPartition.php

@@ -65,7 +65,7 @@ class QueryPartition implements PartitionInterface
     /**
      * @var string
      */
-    private $sql;
+    private string $sql;
 
     /**
      * @param string $token The token identifying the partition.
@@ -100,7 +100,7 @@ class QueryPartition implements PartitionInterface
      *           array type, for instance `[Database::TYPE_ARRAY, Database::TYPE_INT64]`.
      * }
      */
-    public function __construct($token, $sql, $options)
+    public function __construct(string $token, string $sql, array $options)
     {
         $this->token = $token;
         $this->sql = $sql;

Spanner/src/Batch/ReadPartition.php

@@ -62,17 +62,17 @@ class ReadPartition implements PartitionInterface
     /**
      * @var string
      */
-    private $table;
+    private string $table;
 
     /**
      * @var KeySet
      */
-    private $keySet;
+    private KeySet $keySet;
 
     /**
      * @var array
      */
-    private $columns;
+    private array $columns;
 
     /**
      * @param string $token The token identifying the partition.
@@ -95,8 +95,8 @@ class ReadPartition implements PartitionInterface
      * }
      */
     public function __construct(
-        $token,
-        $table,
+        string $token,
+        string $table,
         KeySet $keySet,
         array $columns,
         array $options

Spanner/src/Database.php

@@ -35,7 +35,6 @@
 use Google\Cloud\Spanner\Admin\Database\V1\CreateDatabaseRequest;
 use Google\Cloud\Spanner\Admin\Database\V1\Database as DatabaseProto;
 use Google\Cloud\Spanner\Admin\Database\V1\Database\State;
-use Google\Cloud\Spanner\Admin\Database\V1\DatabaseAdminClient;
 use Google\Cloud\Spanner\Admin\Database\V1\DatabaseDialect;
 use Google\Cloud\Spanner\Admin\Database\V1\DropDatabaseRequest;
 use Google\Cloud\Spanner\Admin\Database\V1\GetDatabaseDdlRequest;