feat(Spanner): multiplexed sessions

Author: bshaffer

.github/workflows/emulator-system-tests-spanner.yaml

@@ -44,7 +44,7 @@ jobs:
           php-version: '8.1'
           ini-values: grpc.enable_fork_support=1
           tools: pecl
-          extensions: bcmath, grpc
+          extensions: bcmath, grpc, pcntl
 
       - name: Install dependencies
         run: |

Core/src/Testing/Snippet/SnippetTestCase.php

@@ -32,6 +32,8 @@
  */
 class SnippetTestCase extends TestCase
 {
+    const PROJECT = 'my-awesome-project';
+
     use CheckForClassTrait;
 
     private static $coverage;

Core/src/Testing/System/SystemTestCase.php

@@ -28,6 +28,7 @@
 use Google\Cloud\Storage\StorageClient;
 use Google\Cloud\Core\Testing\System\DeletionQueue;
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Cache\Adapter\FilesystemAdapter;
 
 /**
  * SystemTestCase can be extended to implement system tests
@@ -286,4 +287,11 @@ public static function skipIfEmulatorUsed($reason = null)
             self::markTestSkipped($reason ?: 'This test is not supported by the emulator.');
         }
     }
+
+    protected static function getCacheItemPool()
+    {
+        return new FilesystemAdapter(
+            directory: __DIR__ . '/../../../../.cache'
+        );
+    }
 }

Core/tests/Unit/Batch/OpisClosureSerializerTest.php

@@ -25,12 +25,13 @@
 /**
  * @group core
  * @group batch
+ * @runTestsInSeparateProcesses
  */
 class OpisClosureSerializerTest extends TestCase
 {
     public function testWrapAndUnwrapClosures()
     {
-        if (!method_exists(SerializableClosure::class, 'enterContext')) {
+        if (!@method_exists(SerializableClosure::class, 'enterContext')) {
             $this->markTestSkipped('Requires ops/serializer:v3');
         }
 
@@ -49,8 +50,8 @@ public function testWrapAndUnwrapClosures()
 
     public function testWrapAndUnwrapClosuresV4()
     {
-        if (!function_exists('Opis\Closure\serialize')) {
-            $this->markTestSkipped('Requires ops/serializer:v3');
+        if (@method_exists(SerializableClosure::class, 'enterContext')) {
+            $this->markTestSkipped('Requires ops/serializer:v4');
         }
 
         $data['closure'] = function () {

Core/tests/Unit/Lock/FlockLockTest.php

@@ -25,6 +25,7 @@
 /**
  * @group core
  * @group lock
+ * @runTestsInSeparateProcesses
  */
 class FlockLockTest extends TestCase
 {

Core/tests/Unit/Lock/SemaphoreLockTest.php

@@ -26,6 +26,7 @@
 /**
  * @group core
  * @group lock
+ * @runTestsInSeparateProcesses
  */
 class SemaphoreLockTest extends TestCase
 {

Datastore/tests/Snippet/FilterTest.php

@@ -24,7 +24,7 @@ class FilterTest extends SnippetTestCase
     use ProphecyTrait;
     use ProtoEncodeTrait;
 
-    private const PROJECT = 'alpha-project';
+    const PROJECT = 'alpha-project';
     private $gapicClient;
     private $datastore;
     private $operation;

PubSub/tests/Snippet/PubSubClientTest.php

@@ -43,7 +43,7 @@ class PubSubClientTest extends SnippetTestCase
 {
     use ProphecyTrait;
 
-    private const PROJECT_ID = 'my-awesome-project';
+    const PROJECT_ID = 'my-awesome-project';
     private const TOPIC = 'projects/my-awesome-project/topics/my-new-topic';
     private const SUBSCRIPTION = 'projects/my-awesome-project/subscriptions/my-new-subscription';
     private const SNAPSHOT = 'projects/my-awesome-project/snapshots/my-snapshot';

PubSub/tests/Snippet/SnapshotTest.php

@@ -38,7 +38,7 @@ class SnapshotTest extends SnippetTestCase
     use ProphecyTrait;
     use ApiHelperTrait;
 
-    private const PROJECT = 'my-awesome-project';
+    const PROJECT = 'my-awesome-project';
     private const SNAPSHOT = 'projects/my-awesome-project/snapshots/my-snapshot';
     private const PROJECT_ID = 'my-awesome-project';
 

Spanner/MIGRATING.md

@@ -117,4 +117,20 @@ $lro->delete();
 ### Removed Methods
 
  - `Operation::createTransaction` => use `Operation::transaction` instead
- - `Operation::createSnapshot` => use `Operation::snapshot` instead
+ - `Operation::createSnapshot` => use `Operation::snapshot` instead
+ - `Database::close` => obsolete
+ - `Database::sessionPool` => obsolete
+ - `Database::batchCreateSessions` => obsolete
+ - `Database::deleteSessionAsync` => obsolete
+ - `BatchSnapshot::close` => obsolete
+ - `Operation::session` => obsolete
+ - `Operation::createSession` => (obsolete)
+ - `Operation::commitWithResponse`  (obsolete) => use `Operation::commit` instead
+
+### Removed Classes
+
+ - `Session\Session` => removed in favor of `SessionCache`
+ - `Session\CacheSessionPool` => removed in favor of `SessionCache`
+ - `Session\SessionPoolInterface` => removed in favor of `SessionCache`
+ - `Operation` - this class is marked `@internal`, and should not be used directly.
+