googleapis
diff --git a/‎AccessApproval/src/V1/Client/AccessApprovalClient.php‎
Lines changed: 40 additions & 48 deletions b/‎AccessApproval/src/V1/Client/AccessApprovalClient.php‎
Lines changed: 40 additions & 48 deletions
@@ -27,6 +27,7 @@
 use Google\ApiCore\ApiException;
 use Google\ApiCore\CredentialsWrapper;
 use Google\ApiCore\GapicClientTrait;
+use Google\ApiCore\Options\ClientOptions;
 use Google\ApiCore\PagedListResponse;
 use Google\ApiCore\ResourceHelperTrait;
 use Google\ApiCore\RetrySettings;
@@ -126,7 +127,9 @@ final class AccessApprovalClient
     private const CODEGEN_NAME = 'gapic';
 
     /** The default scopes required by the service. */
-    public static $serviceScopes = ['https://www.googleapis.com/auth/cloud-platform'];
+    public static $serviceScopes = [
+        'https://www.googleapis.com/auth/cloud-platform',
+    ];
 
     private static function getClientDefaults()
     {
@@ -357,25 +360,28 @@ public static function parseName(string $formattedName, ?string $template = null
     /**
      * Constructor.
      *
-     * @param array $options {
+     * @param array|ClientOptions $options {
      *     Optional. Options for configuring the service API wrapper.
      *
      *     @type string $apiEndpoint
      *           The address of the API remote host. May optionally include the port, formatted
      *           as "<uri>:<port>". Default 'accessapproval.googleapis.com:443'.
-     *     @type string|array|FetchAuthTokenInterface|CredentialsWrapper $credentials
-     *           The credentials to be used by the client to authorize API calls. This option
-     *           accepts either a path to a credentials file, or a decoded credentials file as a
-     *           PHP array.
-     *           *Advanced usage*: In addition, this option can also accept a pre-constructed
-     *           {@see \Google\Auth\FetchAuthTokenInterface} object or
-     *           {@see \Google\ApiCore\CredentialsWrapper} object. Note that when one of these
-     *           objects are provided, any settings in $credentialsConfig will be ignored.
-     *           *Important*: If you accept a credential configuration (credential
-     *           JSON/File/Stream) from an external source for authentication to Google Cloud
-     *           Platform, you must validate it before providing it to any Google API or library.
-     *           Providing an unvalidated credential configuration to Google APIs can compromise
-     *           the security of your systems and data. For more information {@see
+     *     @type FetchAuthTokenInterface|CredentialsWrapper $credentials
+     *           This option should only be used with a pre-constructed
+     *           {@see FetchAuthTokenInterface} or {@see CredentialsWrapper} object. Note that
+     *           when one of these objects are provided, any settings in $credentialsConfig will
+     *           be ignored.
+     *           **Important**: If you are providing a path to a credentials file, or a decoded
+     *           credentials file as a PHP array, this usage is now DEPRECATED. Providing an
+     *           unvalidated credential configuration to Google APIs can compromise the security
+     *           of your systems and data. It is recommended to create the credentials explicitly
+     *           ```
+     *           use Google\Auth\Credentials\ServiceAccountCredentials;
+     *           use Google\Cloud\AccessApproval\V1\AccessApprovalClient;
+     *           $creds = new ServiceAccountCredentials($scopes, $json);
+     *           $options = new AccessApprovalClient(['credentials' => $creds]);
+     *           ```
+     *           {@see
      *           https://cloud.google.com/docs/authentication/external/externally-sourced-credentials}
      *     @type array $credentialsConfig
      *           Options used to configure credentials, including auth token caching, for the
@@ -413,11 +419,13 @@ public static function parseName(string $formattedName, ?string $template = null
      *     @type false|LoggerInterface $logger
      *           A PSR-3 compliant logger. If set to false, logging is disabled, ignoring the
      *           'GOOGLE_SDK_PHP_LOGGING' environment flag
+     *     @type string $universeDomain
+     *           The service domain for the client. Defaults to 'googleapis.com'.
      * }
      *
      * @throws ValidationException
      */
-    public function __construct(array $options = [])
+    public function __construct(array|ClientOptions $options = [])
     {
         $clientOptions = $this->buildClientOptions($options);
         $this->setClientOptions($clientOptions);
@@ -459,10 +467,8 @@ public function __call($method, $args)
      *
      * @throws ApiException Thrown if the API call fails.
      */
-    public function approveApprovalRequest(
-        ApproveApprovalRequestMessage $request,
-        array $callOptions = []
-    ): ApprovalRequest {
+    public function approveApprovalRequest(ApproveApprovalRequestMessage $request, array $callOptions = []): ApprovalRequest
+    {
         return $this->startApiCall('ApproveApprovalRequest', $request, $callOptions)->wait();
     }
 
@@ -491,10 +497,8 @@ public function approveApprovalRequest(
      *
      * @throws ApiException Thrown if the API call fails.
      */
-    public function deleteAccessApprovalSettings(
-        DeleteAccessApprovalSettingsMessage $request,
-        array $callOptions = []
-    ): void {
+    public function deleteAccessApprovalSettings(DeleteAccessApprovalSettingsMessage $request, array $callOptions = []): void
+    {
         $this->startApiCall('DeleteAccessApprovalSettings', $request, $callOptions)->wait();
     }
 
@@ -529,10 +533,8 @@ public function deleteAccessApprovalSettings(
      *
      * @throws ApiException Thrown if the API call fails.
      */
-    public function dismissApprovalRequest(
-        DismissApprovalRequestMessage $request,
-        array $callOptions = []
-    ): ApprovalRequest {
+    public function dismissApprovalRequest(DismissApprovalRequestMessage $request, array $callOptions = []): ApprovalRequest
+    {
         return $this->startApiCall('DismissApprovalRequest', $request, $callOptions)->wait();
     }
 
@@ -559,10 +561,8 @@ public function dismissApprovalRequest(
      *
      * @throws ApiException Thrown if the API call fails.
      */
-    public function getAccessApprovalServiceAccount(
-        GetAccessApprovalServiceAccountMessage $request,
-        array $callOptions = []
-    ): AccessApprovalServiceAccount {
+    public function getAccessApprovalServiceAccount(GetAccessApprovalServiceAccountMessage $request, array $callOptions = []): AccessApprovalServiceAccount
+    {
         return $this->startApiCall('GetAccessApprovalServiceAccount', $request, $callOptions)->wait();
     }
 
@@ -588,10 +588,8 @@ public function getAccessApprovalServiceAccount(
      *
      * @throws ApiException Thrown if the API call fails.
      */
-    public function getAccessApprovalSettings(
-        GetAccessApprovalSettingsMessage $request,
-        array $callOptions = []
-    ): AccessApprovalSettings {
+    public function getAccessApprovalSettings(GetAccessApprovalSettingsMessage $request, array $callOptions = []): AccessApprovalSettings
+    {
         return $this->startApiCall('GetAccessApprovalSettings', $request, $callOptions)->wait();
     }
 
@@ -650,10 +648,8 @@ public function getApprovalRequest(GetApprovalRequestMessage $request, array $ca
      *
      * @throws ApiException Thrown if the API call fails.
      */
-    public function invalidateApprovalRequest(
-        InvalidateApprovalRequestMessage $request,
-        array $callOptions = []
-    ): ApprovalRequest {
+    public function invalidateApprovalRequest(InvalidateApprovalRequestMessage $request, array $callOptions = []): ApprovalRequest
+    {
         return $this->startApiCall('InvalidateApprovalRequest', $request, $callOptions)->wait();
     }
 
@@ -680,10 +676,8 @@ public function invalidateApprovalRequest(
      *
      * @throws ApiException Thrown if the API call fails.
      */
-    public function listApprovalRequests(
-        ListApprovalRequestsMessage $request,
-        array $callOptions = []
-    ): PagedListResponse {
+    public function listApprovalRequests(ListApprovalRequestsMessage $request, array $callOptions = []): PagedListResponse
+    {
         return $this->startApiCall('ListApprovalRequests', $request, $callOptions);
     }
 
@@ -710,10 +704,8 @@ public function listApprovalRequests(
      *
      * @throws ApiException Thrown if the API call fails.
      */
-    public function updateAccessApprovalSettings(
-        UpdateAccessApprovalSettingsMessage $request,
-        array $callOptions = []
-    ): AccessApprovalSettings {
+    public function updateAccessApprovalSettings(UpdateAccessApprovalSettingsMessage $request, array $callOptions = []): AccessApprovalSettings
+    {
         return $this->startApiCall('UpdateAccessApprovalSettings', $request, $callOptions)->wait();
     }
 }