Skip to content

Commit b81f2e4

Browse files
committed
fix snippet and cs tests
1 parent ed9d000 commit b81f2e4

4 files changed

Lines changed: 17 additions & 7 deletions

File tree

Core/src/ApiHelperTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919

2020
use Google\ApiCore\ArrayTrait;
2121
use Google\ApiCore\Options\CallOptions;
22-
use Google\Protobuf\NullValue;
2322
use Google\Protobuf\Internal\Message;
23+
use Google\Protobuf\NullValue;
2424

2525
/**
2626
* @internal

Spanner/src/Operation.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@
3434
use Google\Cloud\Spanner\V1\ReadRequest;
3535
use Google\Cloud\Spanner\V1\RequestOptions;
3636
use Google\Cloud\Spanner\V1\RollbackRequest;
37-
use Google\Cloud\Spanner\V1\TransactionOptions\ReadWrite;
38-
use Google\Cloud\Spanner\V1\Type;
3937
use Google\Cloud\Spanner\V1\TransactionOptions;
38+
use Google\Cloud\Spanner\V1\TransactionOptions\ReadWrite;
4039
use Google\Cloud\Spanner\V1\TransactionSelector;
40+
use Google\Cloud\Spanner\V1\Type;
4141
use Google\Protobuf\Duration;
4242
use Google\Rpc\Code;
4343
use InvalidArgumentException;

Spanner/src/Serializer.php

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,10 @@
22

33
namespace Google\Cloud\Spanner;
44

5-
use Google\ApiCore\GPBType;
65
use Google\ApiCore\Serializer as ApiCoreSerializer;
76
use Google\Cloud\Core\ApiHelperTrait;
87
use Google\Cloud\Spanner\V1\PartialResultSet;
98
use Google\Cloud\Spanner\V1\Type;
10-
use Google\Protobuf\Internal\MapField;
119
use Google\Protobuf\Internal\RepeatedField as DeprecatedRepeatedField;
1210
use Google\Protobuf\RepeatedField;
1311
use Google\Protobuf\Struct;
@@ -71,7 +69,20 @@ public function __construct()
7169
return $v;
7270
},
7371
'google.protobuf.Value' => function ($v) {
74-
if (!is_array($v)) {
72+
if (!is_array($v) || (
73+
!isset($v['nullValue']) &&
74+
!isset($v['null_value']) &&
75+
!isset($v['numberValue']) &&
76+
!isset($v['number_value']) &&
77+
!isset($v['stringValue']) &&
78+
!isset($v['string_value']) &&
79+
!isset($v['boolValue']) &&
80+
!isset($v['bool_value']) &&
81+
!isset($v['structValue']) &&
82+
!isset($v['struct_value']) &&
83+
!isset($v['listValue']) &&
84+
!isset($v['list_value'])
85+
)) {
7586
return $this->formatValueForApi($v);
7687
}
7788
return $v;

Spanner/src/TransactionalReadTrait.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
use Google\Cloud\Spanner\Session\Session;
2121
use Google\Cloud\Spanner\Session\SessionPoolInterface;
2222
use Google\Cloud\Spanner\V1\TransactionOptions;
23-
use Google\Cloud\Spanner\V1\TransactionOptions\PBReadOnly;
2423

2524
/**
2625
* Shared methods for reads inside a transaction.

0 commit comments

Comments
 (0)