Skip to content

Commit fd0c30c

Browse files
feat: [SecureSourceManager] Add CustomHostConfig to configure custom hostnames for private instances (#9053)
* feat: Add CustomHostConfig to configure custom hostnames for private instances feat: Add option to require code owner approval in branch rules feat: Add force option to DeleteInstance request docs: Improve documentation for labels, pagination, and ListLocations PiperOrigin-RevId: 889991858 Source-Link: googleapis/googleapis@10ac207 Source-Link: googleapis/googleapis-gen@26a9c81 Copy-Tag: eyJwIjoiU2VjdXJlU291cmNlTWFuYWdlci8uT3dsQm90LnlhbWwiLCJoIjoiMjZhOWM4MTM3MmI1MGNjNTAwOWYxMjUxNzVjM2M0ZTQzYmJhOGY5NyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
1 parent 4b21892 commit fd0c30c

28 files changed

Lines changed: 540 additions & 191 deletions

SecureSourceManager/metadata/V1/SecureSourceManager.php

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

SecureSourceManager/samples/V1/SecureSourceManagerClient/batch_create_pull_request_comments.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
* Batch creates pull request comments. This function is used to create
3737
* multiple PullRequestComments for code review. There needs to be exactly one
3838
* PullRequestComment of type Review, and at most 100 PullRequestComments of
39-
* type Code per request. The Postition of the code comments must be unique
39+
* type Code per request. The Position of the code comments must be unique
4040
* within the request.
4141
*
4242
* @param string $formattedParent The pull request in which to create the pull request comments.

SecureSourceManager/samples/V1/SecureSourceManagerClient/list_locations.php

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,22 @@
3131

3232
/**
3333
* Lists information about the supported locations for this service.
34+
35+
This method lists locations based on the resource scope provided in
36+
the [ListLocationsRequest.name] field:
37+
38+
* **Global locations**: If `name` is empty, the method lists the
39+
public locations available to all projects. * **Project-specific
40+
locations**: If `name` follows the format
41+
`projects/{project}`, the method lists locations visible to that
42+
specific project. This includes public, private, or other
43+
project-specific locations enabled for the project.
44+
45+
For gRPC and client library implementations, the resource name is
46+
passed as the `name` field. For direct service calls, the resource
47+
name is
48+
incorporated into the request path based on the specific service
49+
implementation and version.
3450
*
3551
* This sample has been automatically generated and should be regarded as a code
3652
* template only. It will require modifications to work:

SecureSourceManager/samples/V1/SecureSourceManagerClient/update_branch_rule.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
use Google\Cloud\SecureSourceManager\V1\BranchRule;
2929
use Google\Cloud\SecureSourceManager\V1\Client\SecureSourceManagerClient;
3030
use Google\Cloud\SecureSourceManager\V1\UpdateBranchRuleRequest;
31-
use Google\Protobuf\FieldMask;
3231
use Google\Rpc\Status;
3332

3433
/**
@@ -47,10 +46,8 @@ function update_branch_rule_sample(): void
4746

4847
// Prepare the request message.
4948
$branchRule = new BranchRule();
50-
$updateMask = new FieldMask();
5149
$request = (new UpdateBranchRuleRequest())
52-
->setBranchRule($branchRule)
53-
->setUpdateMask($updateMask);
50+
->setBranchRule($branchRule);
5451

5552
// Call the API and handle any network failures.
5653
try {

SecureSourceManager/samples/V1/SecureSourceManagerClient/update_hook.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
use Google\Cloud\SecureSourceManager\V1\Client\SecureSourceManagerClient;
2929
use Google\Cloud\SecureSourceManager\V1\Hook;
3030
use Google\Cloud\SecureSourceManager\V1\UpdateHookRequest;
31-
use Google\Protobuf\FieldMask;
3231
use Google\Rpc\Status;
3332

3433
/**
@@ -42,11 +41,9 @@ function update_hook_sample(string $hookTargetUri): void
4241
$secureSourceManagerClient = new SecureSourceManagerClient();
4342

4443
// Prepare the request message.
45-
$updateMask = new FieldMask();
4644
$hook = (new Hook())
4745
->setTargetUri($hookTargetUri);
4846
$request = (new UpdateHookRequest())
49-
->setUpdateMask($updateMask)
5047
->setHook($hook);
5148

5249
// Call the API and handle any network failures.

SecureSourceManager/src/V1/BranchRule.php

Lines changed: 48 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

SecureSourceManager/src/V1/Client/SecureSourceManagerClient.php

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -663,7 +663,7 @@ public function __call($method, $args)
663663
* Batch creates pull request comments. This function is used to create
664664
* multiple PullRequestComments for code review. There needs to be exactly one
665665
* PullRequestComment of type Review, and at most 100 PullRequestComments of
666-
* type Code per request. The Postition of the code comments must be unique
666+
* type Code per request. The Position of the code comments must be unique
667667
* within the request.
668668
*
669669
* The async variant is
@@ -2188,6 +2188,22 @@ public function getLocation(GetLocationRequest $request, array $callOptions = []
21882188

21892189
/**
21902190
* Lists information about the supported locations for this service.
2191+
2192+
This method lists locations based on the resource scope provided in
2193+
the [ListLocationsRequest.name] field:
2194+
2195+
* **Global locations**: If `name` is empty, the method lists the
2196+
public locations available to all projects. * **Project-specific
2197+
locations**: If `name` follows the format
2198+
`projects/{project}`, the method lists locations visible to that
2199+
specific project. This includes public, private, or other
2200+
project-specific locations enabled for the project.
2201+
2202+
For gRPC and client library implementations, the resource name is
2203+
passed as the `name` field. For direct service calls, the resource
2204+
name is
2205+
incorporated into the request path based on the specific service
2206+
implementation and version.
21912207
*
21922208
* The async variant is {@see SecureSourceManagerClient::listLocationsAsync()} .
21932209
*

SecureSourceManager/src/V1/CreateInstanceRequest.php

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

SecureSourceManager/src/V1/DeleteInstanceRequest.php

Lines changed: 37 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

SecureSourceManager/src/V1/Hook.php

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)