Skip to content

Commit a63023b

Browse files
committed
perf: simplify measured start time recording in read microbenchmarks
1 parent 2ea9f6e commit a63023b

1 file changed

Lines changed: 2 additions & 14 deletions

File tree

  • packages/google-cloud-storage/tests/perf/microbenchmarks/time_based/reads

packages/google-cloud-storage/tests/perf/microbenchmarks/time_based/reads/test_reads.py

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,6 @@ def _calculate_average_throughput_mib_s(
7979
return (total_bytes_downloaded / total_elapsed_time) / (1024 * 1024)
8080

8181

82-
def _record_measured_start(
83-
measured_start_time: Optional[float], current_time: float
84-
) -> float:
85-
if measured_start_time is None:
86-
return current_time
87-
return measured_start_time
88-
89-
9082
def _build_download_result(
9183
total_bytes_downloaded: int,
9284
measured_start_time: Optional[float],
@@ -147,9 +139,7 @@ def _download_time_based_json(client, filename, params):
147139
if is_warming_up and current_time >= warmup_end_time:
148140
is_warming_up = False
149141
total_bytes_downloaded = 0 # Reset counter after warmup
150-
measured_start_time = _record_measured_start(
151-
measured_start_time, current_time
152-
)
142+
measured_start_time = current_time
153143

154144
bytes_in_iteration = 0
155145
# For JSON, we can't batch ranges like gRPC, so we download one by one
@@ -199,9 +189,7 @@ async def _worker_coro():
199189
if is_warming_up and current_time >= warmup_end_time:
200190
is_warming_up = False
201191
total_bytes_downloaded = 0 # Reset counter after warmup
202-
measured_start_time = _record_measured_start(
203-
measured_start_time, current_time
204-
)
192+
measured_start_time = current_time
205193

206194
ranges = []
207195
if params.pattern == "rand":

0 commit comments

Comments
 (0)