Skip to content

Commit aaea04c

Browse files
authored
chore: update handwritten noxfiles to use ruff (#15580)
update handwritten noxfiles to use ruff
1 parent fd08f88 commit aaea04c

112 files changed

Lines changed: 404 additions & 116 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

packages/google-cloud-access-context-manager/google/identity/accesscontextmanager/type/device_resources_pb2.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
# source: google/identity/accesscontextmanager/type/device_resources.proto
1919
# Protobuf Python Version: 4.25.3
2020
"""Generated protocol buffer code."""
21+
2122
from google.protobuf import descriptor as _descriptor
2223
from google.protobuf import descriptor_pool as _descriptor_pool
2324
from google.protobuf import symbol_database as _symbol_database

packages/google-cloud-access-context-manager/google/identity/accesscontextmanager/v1/access_context_manager_pb2.py

Lines changed: 6 additions & 4 deletions
Large diffs are not rendered by default.

packages/google-cloud-access-context-manager/google/identity/accesscontextmanager/v1/access_context_manager_pb2.pyi

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,13 @@ from google.api import field_behavior_pb2 as _field_behavior_pb2
2424
from google.api import resource_pb2 as _resource_pb2
2525
from google.iam.v1 import iam_policy_pb2 as _iam_policy_pb2
2626
from google.iam.v1 import policy_pb2 as _policy_pb2
27+
from google.longrunning import operations_pb2 as _operations_pb2
28+
from google.protobuf import descriptor as _descriptor
29+
from google.protobuf import field_mask_pb2 as _field_mask_pb2
30+
from google.protobuf import message as _message
31+
from google.protobuf.internal import containers as _containers
32+
from google.protobuf.internal import enum_type_wrapper as _enum_type_wrapper
33+
2734
from google.identity.accesscontextmanager.v1 import (
2835
access_level_pb2 as _access_level_pb2,
2936
)
@@ -36,12 +43,6 @@ from google.identity.accesscontextmanager.v1 import (
3643
from google.identity.accesscontextmanager.v1 import (
3744
service_perimeter_pb2 as _service_perimeter_pb2,
3845
)
39-
from google.longrunning import operations_pb2 as _operations_pb2
40-
from google.protobuf import descriptor as _descriptor
41-
from google.protobuf import field_mask_pb2 as _field_mask_pb2
42-
from google.protobuf import message as _message
43-
from google.protobuf.internal import containers as _containers
44-
from google.protobuf.internal import enum_type_wrapper as _enum_type_wrapper
4546

4647
DESCRIPTOR: _descriptor.FileDescriptor
4748

packages/google-cloud-access-context-manager/google/identity/accesscontextmanager/v1/access_level_pb2.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
# source: google/identity/accesscontextmanager/v1/access_level.proto
1919
# Protobuf Python Version: 4.25.3
2020
"""Generated protocol buffer code."""
21+
2122
from google.protobuf import descriptor as _descriptor
2223
from google.protobuf import descriptor_pool as _descriptor_pool
2324
from google.protobuf import symbol_database as _symbol_database
@@ -29,11 +30,12 @@
2930

3031

3132
from google.api import resource_pb2 as google_dot_api_dot_resource__pb2
33+
from google.protobuf import timestamp_pb2 as google_dot_protobuf_dot_timestamp__pb2
34+
from google.type import expr_pb2 as google_dot_type_dot_expr__pb2
35+
3236
from google.identity.accesscontextmanager.type import (
3337
device_resources_pb2 as google_dot_identity_dot_accesscontextmanager_dot_type_dot_device__resources__pb2,
3438
)
35-
from google.protobuf import timestamp_pb2 as google_dot_protobuf_dot_timestamp__pb2
36-
from google.type import expr_pb2 as google_dot_type_dot_expr__pb2
3739

3840
DESCRIPTOR = _descriptor_pool.Default().AddSerializedFile(
3941
b'\n:google/identity/accesscontextmanager/v1/access_level.proto\x12\'google.identity.accesscontextmanager.v1\x1a\x19google/api/resource.proto\x1a@google/identity/accesscontextmanager/type/device_resources.proto\x1a\x1fgoogle/protobuf/timestamp.proto\x1a\x16google/type/expr.proto"\xaa\x03\n\x0b\x41\x63\x63\x65ssLevel\x12\x0c\n\x04name\x18\x01 \x01(\t\x12\r\n\x05title\x18\x02 \x01(\t\x12\x13\n\x0b\x64\x65scription\x18\x03 \x01(\t\x12\x44\n\x05\x62\x61sic\x18\x04 \x01(\x0b\x32\x33.google.identity.accesscontextmanager.v1.BasicLevelH\x00\x12\x46\n\x06\x63ustom\x18\x05 \x01(\x0b\x32\x34.google.identity.accesscontextmanager.v1.CustomLevelH\x00\x12/\n\x0b\x63reate_time\x18\x06 \x01(\x0b\x32\x1a.google.protobuf.Timestamp\x12/\n\x0bupdate_time\x18\x07 \x01(\x0b\x32\x1a.google.protobuf.Timestamp:p\xea\x41m\n/accesscontextmanager.googleapis.com/AccessLevel\x12:accessPolicies/{access_policy}/accessLevels/{access_level}B\x07\n\x05level"\xef\x01\n\nBasicLevel\x12\x46\n\nconditions\x18\x01 \x03(\x0b\x32\x32.google.identity.accesscontextmanager.v1.Condition\x12j\n\x12\x63ombining_function\x18\x02 \x01(\x0e\x32N.google.identity.accesscontextmanager.v1.BasicLevel.ConditionCombiningFunction"-\n\x1a\x43onditionCombiningFunction\x12\x07\n\x03\x41ND\x10\x00\x12\x06\n\x02OR\x10\x01"\xc3\x01\n\tCondition\x12\x16\n\x0eip_subnetworks\x18\x01 \x03(\t\x12L\n\rdevice_policy\x18\x02 \x01(\x0b\x32\x35.google.identity.accesscontextmanager.v1.DevicePolicy\x12\x1e\n\x16required_access_levels\x18\x03 \x03(\t\x12\x0e\n\x06negate\x18\x05 \x01(\x08\x12\x0f\n\x07members\x18\x06 \x03(\t\x12\x0f\n\x07regions\x18\x07 \x03(\t".\n\x0b\x43ustomLevel\x12\x1f\n\x04\x65xpr\x18\x01 \x01(\x0b\x32\x11.google.type.Expr"\x89\x03\n\x0c\x44\x65vicePolicy\x12\x1a\n\x12require_screenlock\x18\x01 \x01(\x08\x12\x66\n\x1b\x61llowed_encryption_statuses\x18\x02 \x03(\x0e\x32\x41.google.identity.accesscontextmanager.type.DeviceEncryptionStatus\x12M\n\x0eos_constraints\x18\x03 \x03(\x0b\x32\x35.google.identity.accesscontextmanager.v1.OsConstraint\x12j\n allowed_device_management_levels\x18\x06 \x03(\x0e\x32@.google.identity.accesscontextmanager.type.DeviceManagementLevel\x12\x1e\n\x16require_admin_approval\x18\x07 \x01(\x08\x12\x1a\n\x12require_corp_owned\x18\x08 \x01(\x08"\x8f\x01\n\x0cOsConstraint\x12\x42\n\x07os_type\x18\x01 \x01(\x0e\x32\x31.google.identity.accesscontextmanager.type.OsType\x12\x17\n\x0fminimum_version\x18\x02 \x01(\t\x12"\n\x1arequire_verified_chrome_os\x18\x03 \x01(\x08\x42\xa7\x02\n+com.google.identity.accesscontextmanager.v1B\x10\x41\x63\x63\x65ssLevelProtoP\x01Z\\cloud.google.com/go/accesscontextmanager/apiv1/accesscontextmanagerpb;accesscontextmanagerpb\xa2\x02\x04GACM\xaa\x02\'Google.Identity.AccessContextManager.V1\xca\x02\'Google\\Identity\\AccessContextManager\\V1\xea\x02*Google::Identity::AccessContextManager::V1b\x06proto3'

packages/google-cloud-access-context-manager/google/identity/accesscontextmanager/v1/access_level_pb2.pyi

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,17 @@ from typing import Optional as _Optional
1919
from typing import Union as _Union
2020

2121
from google.api import resource_pb2 as _resource_pb2
22-
from google.identity.accesscontextmanager.type import (
23-
device_resources_pb2 as _device_resources_pb2,
24-
)
2522
from google.protobuf import descriptor as _descriptor
2623
from google.protobuf import message as _message
2724
from google.protobuf import timestamp_pb2 as _timestamp_pb2
2825
from google.protobuf.internal import containers as _containers
2926
from google.protobuf.internal import enum_type_wrapper as _enum_type_wrapper
3027
from google.type import expr_pb2 as _expr_pb2
3128

29+
from google.identity.accesscontextmanager.type import (
30+
device_resources_pb2 as _device_resources_pb2,
31+
)
32+
3233
DESCRIPTOR: _descriptor.FileDescriptor
3334

3435
class AccessLevel(_message.Message):
@@ -73,6 +74,7 @@ class BasicLevel(_message.Message):
7374
__slots__ = ()
7475
AND: _ClassVar[BasicLevel.ConditionCombiningFunction]
7576
OR: _ClassVar[BasicLevel.ConditionCombiningFunction]
77+
7678
AND: BasicLevel.ConditionCombiningFunction
7779
OR: BasicLevel.ConditionCombiningFunction
7880
CONDITIONS_FIELD_NUMBER: _ClassVar[int]

packages/google-cloud-access-context-manager/google/identity/accesscontextmanager/v1/access_policy_pb2.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
# source: google/identity/accesscontextmanager/v1/access_policy.proto
1919
# Protobuf Python Version: 4.25.3
2020
"""Generated protocol buffer code."""
21+
2122
from google.protobuf import descriptor as _descriptor
2223
from google.protobuf import descriptor_pool as _descriptor_pool
2324
from google.protobuf import symbol_database as _symbol_database

packages/google-cloud-access-context-manager/google/identity/accesscontextmanager/v1/gcp_user_access_binding_pb2.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
# source: google/identity/accesscontextmanager/v1/gcp_user_access_binding.proto
1919
# Protobuf Python Version: 4.25.3
2020
"""Generated protocol buffer code."""
21+
2122
from google.protobuf import descriptor as _descriptor
2223
from google.protobuf import descriptor_pool as _descriptor_pool
2324
from google.protobuf import symbol_database as _symbol_database

packages/google-cloud-access-context-manager/google/identity/accesscontextmanager/v1/service_perimeter_pb2.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
# source: google/identity/accesscontextmanager/v1/service_perimeter.proto
1919
# Protobuf Python Version: 4.25.3
2020
"""Generated protocol buffer code."""
21+
2122
from google.protobuf import descriptor as _descriptor
2223
from google.protobuf import descriptor_pool as _descriptor_pool
2324
from google.protobuf import symbol_database as _symbol_database

packages/google-cloud-access-context-manager/google/identity/accesscontextmanager/v1/service_perimeter_pb2.pyi

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ class ServicePerimeter(_message.Message):
4444
__slots__ = ()
4545
PERIMETER_TYPE_REGULAR: _ClassVar[ServicePerimeter.PerimeterType]
4646
PERIMETER_TYPE_BRIDGE: _ClassVar[ServicePerimeter.PerimeterType]
47+
4748
PERIMETER_TYPE_REGULAR: ServicePerimeter.PerimeterType
4849
PERIMETER_TYPE_BRIDGE: ServicePerimeter.PerimeterType
4950
NAME_FIELD_NUMBER: _ClassVar[int]
@@ -93,6 +94,7 @@ class ServicePerimeterConfig(_message.Message):
9394
ANY_IDENTITY: _ClassVar[ServicePerimeterConfig.IdentityType]
9495
ANY_USER_ACCOUNT: _ClassVar[ServicePerimeterConfig.IdentityType]
9596
ANY_SERVICE_ACCOUNT: _ClassVar[ServicePerimeterConfig.IdentityType]
97+
9698
IDENTITY_TYPE_UNSPECIFIED: ServicePerimeterConfig.IdentityType
9799
ANY_IDENTITY: ServicePerimeterConfig.IdentityType
98100
ANY_USER_ACCOUNT: ServicePerimeterConfig.IdentityType
@@ -247,6 +249,7 @@ class ServicePerimeterConfig(_message.Message):
247249
_Union[ServicePerimeterConfig.EgressTo, _Mapping]
248250
] = ...,
249251
) -> None: ...
252+
250253
RESOURCES_FIELD_NUMBER: _ClassVar[int]
251254
ACCESS_LEVELS_FIELD_NUMBER: _ClassVar[int]
252255
RESTRICTED_SERVICES_FIELD_NUMBER: _ClassVar[int]

packages/google-cloud-access-context-manager/noxfile.py

Lines changed: 40 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,12 @@
2222
import pathlib
2323
import re
2424
import shutil
25-
from typing import Dict, List
2625
import warnings
26+
from typing import Dict, List
2727

2828
import nox
2929

30-
BLACK_VERSION = "black[jupyter]==23.7.0"
31-
ISORT_VERSION = "isort==5.11.0"
30+
RUFF_VERSION = "ruff==0.14.14"
3231

3332
LINT_PATHS = ["docs", "google", "tests", "noxfile.py", "setup.py"]
3433

@@ -102,10 +101,15 @@ def lint(session):
102101
Returns a failure if the linters find linting errors or sufficiently
103102
serious code quality issues.
104103
"""
105-
session.install("flake8", BLACK_VERSION)
104+
session.install("flake8", RUFF_VERSION)
105+
106+
# Check formatting
106107
session.run(
107-
"black",
108+
"ruff",
109+
"format",
108110
"--check",
111+
f"--target-version=py{UNIT_TEST_PYTHON_VERSIONS[0].replace('.', '')}",
112+
"--line-length=88",
109113
*LINT_PATHS,
110114
)
111115

@@ -114,30 +118,50 @@ def lint(session):
114118

115119
@nox.session(python=DEFAULT_PYTHON_VERSION)
116120
def blacken(session):
117-
"""Run black. Format code to uniform standard."""
118-
session.install(BLACK_VERSION)
121+
"""(Deprecated) Legacy session. Please use 'nox -s format'."""
122+
session.log(
123+
"WARNING: The 'blacken' session is deprecated and will be removed in a future release. Please use 'nox -s format' in the future."
124+
)
125+
126+
# Just run the ruff formatter (keeping legacy behavior of only formatting, not sorting imports)
127+
session.install(RUFF_VERSION)
119128
session.run(
120-
"black",
129+
"ruff",
130+
"format",
131+
f"--target-version=py{UNIT_TEST_PYTHON_VERSIONS[0].replace('.', '')}",
132+
"--line-length=88",
121133
*LINT_PATHS,
122134
)
123135

124136

125137
@nox.session(python=DEFAULT_PYTHON_VERSION)
126138
def format(session):
127139
"""
128-
Run isort to sort imports. Then run black
129-
to format code to uniform standard.
140+
Run ruff to sort imports and format code.
130141
"""
131-
session.install(BLACK_VERSION, ISORT_VERSION)
132-
# Use the --fss option to sort imports using strict alphabetical order.
133-
# See https://pycqa.github.io/isort/docs/configuration/options.html#force-sort-within-sections
142+
# 1. Install ruff (skipped automatically if you run with --no-venv)
143+
session.install(RUFF_VERSION)
144+
145+
# 2. Run Ruff to fix imports
146+
# check --select I: Enables strict import sorting
147+
# --fix: Applies the changes automatically
134148
session.run(
135-
"isort",
136-
"--fss",
149+
"ruff",
150+
"check",
151+
"--select",
152+
"I",
153+
"--fix",
154+
f"--target-version=py{UNIT_TEST_PYTHON_VERSIONS[0].replace('.', '')}",
155+
"--line-length=88", # Standard Black line length
137156
*LINT_PATHS,
138157
)
158+
159+
# 3. Run Ruff to format code
139160
session.run(
140-
"black",
161+
"ruff",
162+
"format",
163+
f"--target-version=py{UNIT_TEST_PYTHON_VERSIONS[0].replace('.', '')}",
164+
"--line-length=88", # Standard Black line length
141165
*LINT_PATHS,
142166
)
143167

0 commit comments

Comments
 (0)