Skip to content

System tests not running in latest Release PR #16905

@parthea

Description

@parthea

The latest release PR did not include changes to CHANGELOG.md . We have logic here that relies on the CHANGELOG.md to be changed for system tests to run. If CHANGELOG.md won't be changed in release PRs moving forward, we need to fix the script below to look for changes to version files like gapic_version.py.

# Determine if we should skip based on git diff
files_to_check="${package_path}/CHANGELOG.md"
if [[ $package_name == @($packages_with_system_tests_pattern) ]]; then
files_to_check="${package_path}"
fi
echo "checking changes with 'git diff "${KOKORO_GITHUB_PULL_REQUEST_TARGET_BRANCH}...${KOKORO_GITHUB_PULL_REQUEST_COMMIT}" -- ${files_to_check}'"

Metadata

Metadata

Assignees

Labels

priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: processA process-related concern. May include testing, release, or the like.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions