Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.

Commit 0872c92

Browse files
build: only check --engine-strict for production deps (#42)
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/75155c02-9dd0-4bb9-8de5-c6ec245fec71/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5451633
1 parent f55c2bf commit 0872c92

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@ jobs:
1616
with:
1717
node-version: ${{ matrix.node }}
1818
- run: node --version
19-
- run: npm install --engine-strict
19+
# The first installation step ensures that all of our production
20+
# dependencies work on the given Node.js version, this helps us find
21+
# dependencies that don't match our engines field:
22+
- run: npm install --production --engine-strict
23+
- run: npm install
2024
- run: npm test
2125
- name: coverage
2226
uses: codecov/codecov-action@v1

synth.metadata

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"git": {
55
"name": ".",
66
"remote": "https://github.com/googleapis/nodejs-analytics-admin.git",
7-
"sha": "59d3662b492b9379133d8ae32f2df9f1cb82f720"
7+
"sha": "f55c2bfaacb6203bcb31094c61e71a166b0ddeda"
88
}
99
},
1010
{
@@ -19,7 +19,7 @@
1919
"git": {
2020
"name": "synthtool",
2121
"remote": "https://github.com/googleapis/synthtool.git",
22-
"sha": "0c868d49b8e05bc1f299bc773df9eb4ef9ed96e9"
22+
"sha": "5451633881133e5573cc271a18e73b18caca8b1b"
2323
}
2424
}
2525
],

0 commit comments

Comments
 (0)