Skip to content

Commit 51edbaa

Browse files
authored
fix(go): fix 1.17 testing (#164)
Had automerge on last PR which acted before I could apply fix. Fixes suggestions in #163
1 parent 55e6a66 commit 51edbaa

3 files changed

Lines changed: 24 additions & 2 deletions

File tree

go/cloudbuild-test.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ steps:
7979

8080
# Go 1.17 build
8181
- name: gcr.io/cloud-builders/docker
82-
args: ['build', '-t', 'gcr.io/$PROJECT_ID/go116', '.']
82+
args: ['build', '-t', 'gcr.io/$PROJECT_ID/go117', '.']
8383
dir: go/go117
8484
id: go117-build
8585
waitFor: ['-']

go/go117.yaml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Copyright 2021 Google LLC
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# http://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
schemaVersion: 1.0.0
16+
commandTests:
17+
- name: "version"
18+
command: ["go", "version"]
19+
expectedOutput: ["go version go1.17"]
20+
- name: "gcloud"
21+
command: ["gcloud", "version"]
22+
expectedOutput: ["Google Cloud SDK"]

go/go117/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
FROM golang:1.17
15+
FROM golang:1.17-buster
1616

1717
# Install dependencies
1818
RUN set -ex; \

0 commit comments

Comments
 (0)