Skip to content

Commit a8c2f33

Browse files
committed
Abstract ensuring async task is a future
1 parent 650db34 commit a8c2f33

3 files changed

Lines changed: 6 additions & 10 deletions

File tree

graphql_ws/aiohttp.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import json
2-
from asyncio import ensure_future, shield
2+
from asyncio import shield
33

44
from aiohttp import WSMsgType
55

@@ -45,9 +45,7 @@ async def _handle(self, ws, request_context=None):
4545
break
4646

4747
connection_context.remember_task(
48-
ensure_future(
49-
self.on_message(connection_context, message), loop=self.loop
50-
)
48+
self.on_message(connection_context, message), loop=self.loop
5149
)
5250
await self.on_close(connection_context)
5351

graphql_ws/base_async.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ def closed(self):
3535
async def close(self, code):
3636
...
3737

38-
def remember_task(self, task):
39-
self.pending_tasks.add(asyncio.ensure_future(task))
38+
def remember_task(self, task, loop=None):
39+
self.pending_tasks.add(asyncio.ensure_future(task, loop=loop))
4040
# Clear completed tasks
4141
self.pending_tasks -= WeakSet(
4242
task for task in self.pending_tasks if task.done()

graphql_ws/websockets_lib.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import json
2-
from asyncio import ensure_future, shield
2+
from asyncio import shield
33

44
from websockets import ConnectionClosed
55

@@ -41,9 +41,7 @@ async def _handle(self, ws, request_context):
4141
break
4242

4343
connection_context.remember_task(
44-
ensure_future(
45-
self.on_message(connection_context, message), loop=self.loop
46-
)
44+
self.on_message(connection_context, message), loop=self.loop
4745
)
4846
await self.on_close(connection_context)
4947

0 commit comments

Comments
 (0)