Skip to content

Commit eac9fe9

Browse files
authored
xds: fix xDS HTTP CONNECT's transport socket name bug (#12740)
fixes #12739
1 parent 1528f80 commit eac9fe9

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

xds/src/main/java/io/grpc/xds/XdsClusterResource.java

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,6 @@ class XdsClusterResource extends XdsResourceType<CdsUpdate> {
8080
"type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext";
8181
private static final String TYPE_URL_UPSTREAM_TLS_CONTEXT_V2 =
8282
"type.googleapis.com/envoy.api.v2.auth.UpstreamTlsContext";
83-
static final String TRANSPORT_SOCKET_NAME_HTTP11_PROXY =
84-
"type.googleapis.com/envoy.extensions.transport_sockets.http_11_proxy.v3"
85-
+ ".Http11ProxyUpstreamTransport";
8683
private final LoadBalancerRegistry loadBalancerRegistry
8784
= LoadBalancerRegistry.getDefaultRegistry();
8885

@@ -261,14 +258,14 @@ private static StructOrError<CdsUpdate.Builder> parseNonAggregateCluster(
261258
TransportSocket transportSocket = cluster.getTransportSocket();
262259

263260
if (hasTransportSocket && !TRANSPORT_SOCKET_NAME_TLS.equals(transportSocket.getName())
264-
&& !(isEnabledXdsHttpConnect
265-
&& TRANSPORT_SOCKET_NAME_HTTP11_PROXY.equals(transportSocket.getName()))) {
261+
&& !(isEnabledXdsHttpConnect && transportSocket.getTypedConfig().is(
262+
Http11ProxyUpstreamTransport.class))) {
266263
return StructOrError.fromError(
267264
"transport-socket with name " + transportSocket.getName() + " not supported.");
268265
}
269266

270-
if (hasTransportSocket && isEnabledXdsHttpConnect
271-
&& TRANSPORT_SOCKET_NAME_HTTP11_PROXY.equals(transportSocket.getName())) {
267+
if (hasTransportSocket && isEnabledXdsHttpConnect && transportSocket.getTypedConfig().is(
268+
Http11ProxyUpstreamTransport.class)) {
272269
isHttp11ProxyAvailable = true;
273270
try {
274271
Http11ProxyUpstreamTransport wrappedTransportSocket = transportSocket

xds/src/test/java/io/grpc/xds/GrpcXdsClientImplDataTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
import static com.google.common.truth.Truth.assertThat;
2020
import static io.envoyproxy.envoy.config.route.v3.RouteAction.ClusterSpecifierCase.CLUSTER_SPECIFIER_PLUGIN;
21-
import static io.grpc.xds.XdsClusterResource.TRANSPORT_SOCKET_NAME_HTTP11_PROXY;
2221
import static io.grpc.xds.XdsEndpointResource.GRPC_EXPERIMENTAL_XDS_DUALSTACK_ENDPOINTS;
2322
import static org.junit.Assert.assertThrows;
2423
import static org.junit.Assert.fail;
@@ -2615,7 +2614,7 @@ public void parseNonAggregateCluster_withHttp11ProxyTransportSocket() throws Exc
26152614
.build();
26162615

26172616
TransportSocket transportSocket = TransportSocket.newBuilder()
2618-
.setName(TRANSPORT_SOCKET_NAME_HTTP11_PROXY)
2617+
.setName("envoy.transport_sockets.http_11_proxy")
26192618
.setTypedConfig(Any.pack(http11ProxyUpstreamTransport))
26202619
.build();
26212620

0 commit comments

Comments
 (0)