Release v2.0.0-rc.5 (#5082)

Author: tig

CLAUDE.md

@@ -89,10 +89,22 @@ When in planning mode:
 ```bash
 dotnet restore
 dotnet build --no-restore
+
+# Preferred: parallelizable tests (no static state)
 dotnet test --project Tests/UnitTestsParallelizable --no-build
-dotnet test --project Tests/UnitTests --no-build
+
+# Tests that require process-wide static state (Application.Init, etc.)
+dotnet test --project Tests/UnitTests.NonParallelizable --no-build
+
+# Legacy tests — do NOT add new tests here; candidates for rewrite/deletion
+dotnet test --project Tests/UnitTests.Legacy --no-build
+
+# Run a single test by fully-qualified name
+dotnet test --project Tests/UnitTestsParallelizable --no-build --filter "FullyQualifiedName~MyTestClass.MyTestMethod"
 ```
 
+See `Tests/README.md` for the full list of test projects (including `IntegrationTests`, `StressTests`, `Benchmarks`) and the static-state classification that determines where a new test belongs.
+
 ## Key Concepts
 
 | Concept | Documentation |
@@ -118,7 +130,7 @@ dotnet test --project Tests/UnitTests --no-build
 
 ## Testing
 
-- Prefer `UnitTestsParallelizable` over `UnitTests`
+- Add new tests to `UnitTestsParallelizable`; use `UnitTests.NonParallelizable` only when static state is unavoidable. Never add to `UnitTests.Legacy`.
 - Add comment: `// Claude - Opus 4.5`
 - Never decrease coverage
 - Avoid `Application.Init` in tests

Directory.Packages.props

@@ -42,7 +42,7 @@
     <PackageVersion Include="TextMateSharp.Grammars" Version="2.0.3" />
     <PackageVersion Include="ReportGenerator" Version="5.5.5" />
     <PackageVersion Include="TestableIO.System.IO.Abstractions.TestingHelpers" Version="22.1.1" />
-    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.4.0" />
+    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.5.0" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" />
     <PackageVersion Include="xunit.v3" Version="3.2.2" />
     <PackageVersion Include="Xunit.Combinatorial" Version="2.0.24" />

Examples/NativeAot/NativeAot.csproj

@@ -9,7 +9,6 @@
 
   <ItemGroup>
     <ProjectReference Include="..\..\Terminal.Gui\Terminal.Gui.csproj" />
-    <TrimmerRootAssembly Include="Terminal.Gui" />
   </ItemGroup>
 
 </Project>

Examples/UICatalog/Resources/config.json

@@ -1,11 +1,5 @@
 {
   "$schema": "https://gui-cs.github.io/Terminal.Gui/schemas/tui-config-schema.json",
-  "FileDialog.MaxSearchResults": 10000,
-  "FileDialogStyle.DefaultUseColors": false,
-  "FileDialogStyle.DefaultUseUnicodeCharacters": false,
-  "AppSettings": {
-    "UICatalog.StatusBar": true
-  },
   "Themes": [
     {
       "Hot Dog Stand": {

Examples/UICatalog/Scenarios/CharacterMap/CharacterMap.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable enable
 
 using System.Globalization;
 using System.Text;
@@ -69,7 +69,10 @@ public override void Main ()
             Menus =
             [
                 new MenuBarItem (Strings.menuFile,
-                                 new MenuItem [] { new (Strings.cmdQuit, $"{Application.GetDefaultKey (Command.Quit)}", () => _charMap?.App?.RequestStop ()) }),
+                                 new MenuItem []
+                                 {
+                                     new (Strings.cmdQuit, $"{Application.GetDefaultKey (Command.Quit)}", () => _charMap?.App?.RequestStop ())
+                                 }),
                 new MenuBarItem ("_Options", [CreateMenuShowWidth (), CreateMenuUnicodeCategorySelector ()])
             ]
         };
@@ -135,18 +138,19 @@ public override void Main ()
                                             return;
                                         }
                                         EnumerableTableSource<UnicodeRange> table = (EnumerableTableSource<UnicodeRange>)_categoryList.Table!;
-                                        string prevSelection = table.Data.ElementAt (_categoryList.SelectedRow).Category;
+                                        string prevSelection = table.Data.ElementAt (_categoryList.Value?.Cursor.Y ?? 0).Category;
                                         isDescending = !isDescending;
 
                                         _categoryList.Table = CreateCategoryTable (clickedCol.Value, isDescending);
 
                                         table = (EnumerableTableSource<UnicodeRange>)_categoryList.Table!;
 
-                                        _categoryList.SelectedRow =
-                                            table.Data.Select ((item, index) => new { item, index })
-                                                 .FirstOrDefault (x => x.item.Category == prevSelection)
-                                                 ?.index
-                                            ?? -1;
+                                        _categoryList.SetSelection (0,
+                                                                    table.Data.Select ((item, index) => new { item, index })
+                                                                         .FirstOrDefault (x => x.item.Category == prevSelection)
+                                                                         ?.index
+                                                                    ?? 0,
+                                                                    false);
                                     };
 
         int longestName = UnicodeRange.Ranges.Max (r => r.Category.GetColumns ());
@@ -157,12 +161,17 @@ public override void Main ()
 
         _categoryList.Width = _categoryList.Style.ColumnStyles.Sum (c => c.Value.MinWidth) + 4;
 
-        _categoryList.SelectedCellChanged += (_, args) =>
-                                             {
-                                                 EnumerableTableSource<UnicodeRange> table = (EnumerableTableSource<UnicodeRange>)_categoryList.Table!;
-                                                 _charMap.StartCodePoint = table.Data.ToArray () [args.NewRow].Start;
-                                                 jumpEdit.Text = $"U+{_charMap.SelectedCodePoint:x5}";
-                                             };
+        _categoryList.ValueChanged += (_, args) =>
+                                      {
+                                          if (args.NewValue is null)
+                                          {
+                                              return;
+                                          }
+
+                                          EnumerableTableSource<UnicodeRange> table = (EnumerableTableSource<UnicodeRange>)_categoryList.Table!;
+                                          _charMap.StartCodePoint = table.Data.ToArray () [args.NewValue.Cursor.Y].Start;
+                                          jumpEdit.Text = $"U+{_charMap.SelectedCodePoint:x5}";
+                                      };
 
         top.Add (menu, _charMap, jumpLabel, jumpEdit, _errorLabel, _categoryList);
 
@@ -239,11 +248,13 @@ void JumpEditOnAccept (object? sender, CommandEventArgs e)
 
             EnumerableTableSource<UnicodeRange> table = (EnumerableTableSource<UnicodeRange>)_categoryList!.Table!;
 
-            _categoryList.SelectedRow = table.Data.Select ((item, index) => new { item, index })
+            _categoryList.SetSelection (0,
+                                        table.Data.Select ((item, index) => new { item, index })
                                              .FirstOrDefault (x => x.item.Start <= result && x.item.End >= result)
                                              ?.index
-                                        ?? -1;
-            _categoryList.EnsureSelectedCellIsVisible ();
+                                        ?? 0,
+                                        false);
+            _categoryList.EnsureCursorIsVisible ();
 
             // Ensure the typed glyph is selected
             _charMap.SelectedCodePoint = (int)result;