Update docs Makefile, remove old crufts from the recent merge. (#940)

The new latexmk in current TexLive distribution has changed the way
parameters are processed: the file.pdf output should not be part of the
command line anymore.

Author: DimCitus

Makefile

@@ -213,9 +213,12 @@ spellcheck:
 	black --check .
 	ci/banned.h.sh
 
-docs: $(FSM)
+docs: $(FSM) tikz
 	$(MAKE) -C docs html
 
+tikz:
+	$(MAKE) -C docs/tikz all
+
 interactive-test:
 	docker run --name $(CONTAINER_NAME) --rm -ti $(CONTAINER_NAME)
 
@@ -301,7 +304,7 @@ run-installcheck-i386: build-i386
 man:
 	$(MAKE) -C docs man
 
-pdf: $(PDF)
+pdf: $(PDF) ;
 
 $(PDF):
 	$(MAKE) -s -C docs/tikz pdf
@@ -409,7 +412,7 @@ az: all
 azdrop: all
 	$(PG_AUTOCTL) do azure drop
 
-.PHONY: all clean check install docs
+.PHONY: all clean check install docs tikz
 .PHONY: monitor clean-monitor check-monitor install-monitor
 .PHONY: bin clean-bin install-bin
 .PHONY: build-test run-test spellcheck lint linting ci-test

docs/failover-state-machine.rst

@@ -274,33 +274,6 @@ entry. If a node is not reporting anymore, maybe because it's completely
 unavailable, then it's possible to run the ``pg_autoctl drop node --force``
 command, and then the node entry is removed from the monitor.
 
-Failover logic
---------------
-
-This section needs to be expanded further, but below is the failover state
-machine for each node that is implemented by the monitor:
-
-.. figure:: ./fsm/node-state-machine.png
-   :scale: 30%
-   :alt: Node state machine
-
-   Node state machine
-
-Since the state machines of the data nodes always move in tandem, a pair
-(group) of data nodes also implicitly has the following state machine:
-
-.. figure:: ./fsm/group-state-machine.png
-   :scale: 40%
-   :alt: Group state machine
-
-   Group state machine
-
-.. raw:: latex
-
-    \newpage
-
-.. _state_machine_diagram:
-
 pg_auto_failover keeper's State Machine
 ---------------------------------------
 

docs/fsm.png

@@ -16,7 +16,7 @@ clean:
 	rm -rf $(PNG)
 
 %.pdf: %.tex common.tex
-	latexmk -silent -lualatex --interaction=nonstopmode -shell-escape $< $@
+	latexmk -silent -lualatex --interaction=nonstopmode -shell-escape $<
 	latexmk -c
 
 %.png: %.pdf