Refrain from reloading Postgres when we skip HBA editing anyways. (#588)

DimCitus · web-flow · commit 9cd4eebc91e7 · 2021-02-12T12:38:36.000+01:00
diff --git a/src/bin/pg_autoctl/keeper.c b/src/bin/pg_autoctl/keeper.c
@@ -1581,7 +1581,8 @@ keeper_update_group_hba(Keeper *keeper, NodeAddressArray *diffNodesArray)
 	 * edited the HBA and it's going to take effect at next restart of
 	 * Postgres, so we're good here.
 	 */
-	if (pg_setup_is_running(postgresSetup))
+	if (postgresSetup->hbaLevel > HBA_EDIT_SKIP &&
+		pg_setup_is_running(postgresSetup))
 	{
 		if (!pgsql_reload_conf(pgsql))
 		{

Original file line number	Diff line number	Diff line change
`@@ -1581,7 +1581,8 @@ keeper_update_group_hba(Keeper keeper, NodeAddressArray diffNodesArray)`
`1581`	`1581`	`* edited the HBA and it's going to take effect at next restart of`
`1582`	`1582`	`* Postgres, so we're good here.`
`1583`	`1583`	`*/`
`1584`		`- if (pg_setup_is_running(postgresSetup))`
	`1584`	`+ if (postgresSetup->hbaLevel > HBA_EDIT_SKIP &&`
	`1585`	`+ pg_setup_is_running(postgresSetup))`
`1585`	`1586`	`{`
`1586`	`1587`	`if (!pgsql_reload_conf(pgsql))`
`1587`	`1588`	`{`