Skip to content

Commit a7675a7

Browse files
hasura-bot12fahed
andcommitted
[Console] Fix column duplication when deselecting column type in table schema editor
GITHUB_PR_NUMBER: 10809 GITHUB_PR_URL: #10809 PR-URL: hasura/graphql-engine-mono#11384 Co-authored-by: Fahed Khan <127182880+12fahed@users.noreply.github.com> GitOrigin-RevId: f79f7c0a6cc728e05e0529bcf73bba6607befbbf
1 parent b58264a commit a7675a7

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

  • frontend/libs/console/legacy-ce/src/lib/components/Services/Data/Add

frontend/libs/console/legacy-ce/src/lib/components/Services/Data/Add/TableColumn.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ const TableColumn = props => {
4545

4646
const areArrayTypesSupported = isFeatureSupported('tables.create.arrayTypes');
4747

48-
const [colTypeIdentifier, setColTypeIdentifier] = useState(i);
49-
5048
const [colTypeValue, setColTypeValue] = useState(column.type || '');
5149

5250
useEffect(() => {
@@ -60,9 +58,7 @@ const TableColumn = props => {
6058

6159
const newType = getNewType({ oldType: selectedOption.value, isArray });
6260

63-
onColTypeChange(selectedOption.colIdentifier, newType);
64-
65-
setColTypeIdentifier(selectedOption.colIdentifier);
61+
onColTypeChange(i, newType);
6662
setColTypeValue(newType);
6763
};
6864

@@ -73,7 +69,7 @@ const TableColumn = props => {
7369
if (colTypeValue) {
7470
const newType = getNewType({ oldType: colTypeValue, isArray });
7571

76-
onColTypeChange(colTypeIdentifier, newType);
72+
onColTypeChange(i, newType);
7773
setColTypeValue(newType);
7874
}
7975
};

0 commit comments

Comments
 (0)