Skip to content

Commit 4326eef

Browse files
committed
Fixed RedisPubsub bugs on returning sub_id from subscribe method
and bugs in unsubscribe method
1 parent 445b9d9 commit 4326eef

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

graphql_subscriptions/subscription_manager.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ def publish(self, trigger_name, message):
2222
return True
2323

2424
def subscribe(self, trigger_name, on_message_handler, options):
25+
self.sub_id_counter += 1
2526
try:
2627
if trigger_name not in self.subscriptions.values()[0]:
2728
self.pubsub.subscribe(trigger_name)
@@ -31,7 +32,6 @@ def subscribe(self, trigger_name, on_message_handler, options):
3132
trigger_name,
3233
on_message_handler
3334
]
34-
self.sub_id_counter += 1
3535
if not self.greenlet:
3636
self.greenlet = gevent.spawn(
3737
self.wait_and_get_message
@@ -43,9 +43,9 @@ def unsubscribe(self, sub_id):
4343
del self.subscriptions[sub_id]
4444
try:
4545
if trigger_name not in self.subscriptions.values()[0]:
46-
self.pubsub.subscribe(trigger_name)
46+
self.pubsub.unsubscribe(trigger_name)
4747
except IndexError:
48-
self.pubsub.subscribe(trigger_name)
48+
self.pubsub.unsubscribe(trigger_name)
4949
if not self.subscriptions:
5050
self.greenlet = self.greenlet.kill()
5151

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
setup(
1010
name='graphql-subscriptions',
11-
version='0.1.5',
11+
version='0.1.6',
1212
author='Heath Ballard',
1313
author_email='heath.ballard@gmail.com',
1414
description=('A port of apollo-graphql subscriptions for python, using\

0 commit comments

Comments
 (0)