Skip to content

Commit fd48b05

Browse files
committed
Make several minor changes to subcription_transport
Modified "nonlocal" class to "non_local" dict and changed parameter['context'] defination statement
1 parent 895c575 commit fd48b05

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

graphql_subscriptions/subscription_transport_ws.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,11 @@ def on_message(self, msg):
7777
if msg is None:
7878
return
7979

80-
nonlocal = {'on_init_resolve': None, 'on_init_reject': None}
80+
non_local = {'on_init_resolve': None, 'on_init_reject': None}
8181

8282
def init_promise_handler(resolve, reject):
83-
nonlocal['on_init_resolve'] = resolve
84-
nonlocal['on_init_reject'] = reject
83+
non_local['on_init_resolve'] = resolve
84+
non_local['on_init_reject'] = reject
8585

8686
self.connection_context['init_promise'] = Promise(init_promise_handler)
8787

@@ -105,7 +105,7 @@ def on_message_return_handler(message):
105105
self.on_connect(
106106
parsed_message.get('payload'), self.ws))
107107

108-
nonlocal['on_init_resolve'](on_connect_promise)
108+
non_local['on_init_resolve'](on_connect_promise)
109109

110110
def init_success_promise_handler(result):
111111
if not result:
@@ -131,7 +131,8 @@ def subscription_start_promise_handler(init_result):
131131
'callback': None,
132132
'variables': parsed_message.get('variables'),
133133
'context': init_result if isinstance(
134-
init_result, dict) else {},
134+
init_result, dict) else
135+
parsed_message.get('context', {}),
135136
'format_error': None,
136137
'format_response': None
137138
}
@@ -149,8 +150,7 @@ def subscription_start_promise_handler(init_result):
149150
def promised_params_handler(params):
150151
if not isinstance(params, dict):
151152
error = 'Invalid params returned from\
152-
OnSubscribe! Return value must\
153-
be an dict'
153+
OnSubscribe! Return value must be an dict'
154154

155155
self.send_subscription_fail(
156156
sub_id, {'errors': [{
@@ -162,15 +162,15 @@ def params_callback(error, result):
162162
if not error:
163163
self.send_subscription_data(
164164
sub_id, {'data': result.data})
165-
elif error.errors:
166-
self.send_subscription_data(
167-
sub_id, {'errors': error.errors})
168165
elif error.message:
169166
self.send_subscription_data(
170167
sub_id,
171168
{'errors': [{
172169
'message': error.message
173170
}]})
171+
elif error.errors:
172+
self.send_subscription_data(
173+
sub_id, {'errors': error.errors})
174174
else:
175175
self.send_subscription_data(
176176
sub_id,
@@ -216,7 +216,7 @@ def error_catch_handler(e):
216216
# not sure if this behavior is correct or
217217
# not per promises A spec...need to
218218
# investigate
219-
nonlocal['on_init_resolve'](Promise.resolve(True))
219+
non_local['on_init_resolve'](Promise.resolve(True))
220220

221221
self.connection_context['init_promise'].then(
222222
subscription_start_promise_handler)
@@ -229,7 +229,7 @@ def subscription_end_promise_handler(result):
229229
del self.connection_subscriptions[sub_id]
230230

231231
# same rationale as above
232-
nonlocal['on_init_resolve'](Promise.resolve(True))
232+
non_local['on_init_resolve'](Promise.resolve(True))
233233

234234
self.connection_context['init_promise'].then(
235235
subscription_end_promise_handler)

0 commit comments

Comments
 (0)