fix: Ctrl-C cancels login process (#305)

Author: heroku-johnny

src/login.ts

@@ -77,11 +77,7 @@ export class Login {
           process.stdin.setRawMode(false)
           rl.close()
           ux.stdout('')
-          if (key.toLowerCase() === 'q') {
-            ux.error('Login cancelled by user')
-          }
-
-          input = 'browser'
+          input = this.getLoginMethodFromPromptKey(key)
         }
       }
 
@@ -365,4 +361,16 @@ machine, please manually open the URL above in your browser.\n`,
     ux.warn('If browser does not open, visit:')
     ux.stderr(ansis.greenBright(url))
   }
+
+  private getLoginMethodFromPromptKey(key: string): 'browser' {
+    if (key === '\u0003') {
+      ux.error('Login cancelled by user', {exit: 130})
+    }
+
+    if (key.toLowerCase() === 'q') {
+      ux.error('Login cancelled by user')
+    }
+
+    return 'browser'
+  }
 }

test/login.test.ts

@@ -143,4 +143,14 @@ describe('login with browser', () => {
       expect(stderrStub.calledWithExactly(ansis.greenBright(url))).to.equal(true)
       sinon.assert.callOrder(warnStub, stderrStub)
     })
+
+  test
+    .it('treats ctrl-c keypress as cancel', async ctx => {
+      const cmd = new Command([], ctx.config)
+      const login = new Login(ctx.config, cmd.heroku)
+      const errorStub = sinon.stub(ux, 'error').throws(new Error('cancelled'))
+
+      expect(() => (login as any).getLoginMethodFromPromptKey('\u0003')).to.throw('cancelled')
+      expect(errorStub.calledWithExactly('Login cancelled by user', {exit: 130})).to.equal(true)
+    })
 })