feat(datacenter, server_type): move available and recommended to server_type

Author: phm07

hcloud/datacenters/domain.py

@@ -1,5 +1,6 @@
 from __future__ import annotations
 
+import warnings
 from typing import TYPE_CHECKING
 
 from ..core import BaseDomain, DomainIdentityMixin
@@ -25,7 +26,7 @@ class Datacenter(BaseDomain, DomainIdentityMixin):
     """
 
     __api_properties__ = ("id", "name", "description", "location", "server_types")
-    __slots__ = __api_properties__
+    __slots__ = ("id", "name", "description", "location", "_server_types")
 
     def __init__(
         self,
@@ -39,8 +40,29 @@ def __init__(
         self.name = name
         self.description = description
         self.location = location
-        self.server_types = server_types
+        self._server_types = server_types
+
+    @property
+    def server_types(self) -> DatacenterServerTypes | None:
+        """
+        .. deprecated:: 2.18.0
+            The 'server_types' property is deprecated and will not be supported after 2026-10-01.
+            Please use 'server_type.locations[]' instead.
+
+            See https://docs.hetzner.cloud/changelog#2026-04-01-datacenter-deprecations.
+        """
+        warnings.warn(
+            "The 'server_types' property is deprecated and will not be supported after 2026-10-01. "
+            "Please use 'server_type.locations[]' instead. "
+            "See https://docs.hetzner.cloud/changelog#2026-04-01-datacenter-deprecations",
+            DeprecationWarning,
+            stacklevel=2,
+        )
+        return self._server_types
 
+    @server_types.setter
+    def server_types(self, value: DatacenterServerTypes | None) -> None:
+        self._server_types = value
 
 class DatacenterServerTypes(BaseDomain):
     """DatacenterServerTypes Domain

hcloud/server_types/domain.py

@@ -185,11 +185,15 @@ class ServerTypeLocation(BaseDomain):
 
     :param location: Location of the Server Type.
     :param deprecation: Wether the Server Type is deprecated in this Location.
+    :param available: True if the Server Type is currently available in this Location.
+    :param recommended: True if the Server Type is currently recommended in this Location.
     """
 
     __api_properties__ = (
         "location",
         "deprecation",
+        "available",
+        "recommended",
     )
     __slots__ = __api_properties__
 
@@ -198,8 +202,12 @@ def __init__(
         *,
         location: BoundLocation,
         deprecation: dict[str, Any] | None,
+        available: bool | None,
+        recommended: bool | None,
     ):
         self.location = location
         self.deprecation = (
             DeprecationInfo.from_dict(deprecation) if deprecation is not None else None
         )
+        self.available = available
+        self.recommended = recommended

tests/unit/datacenters/test_client.py

@@ -25,36 +25,37 @@ def test_bound_datacenter_init(self, datacenter_response):
         assert bound_datacenter.location.name == "fsn1"
         assert bound_datacenter.location.complete is True
 
-        assert isinstance(bound_datacenter.server_types, DatacenterServerTypes)
-        assert len(bound_datacenter.server_types.supported) == 3
-        assert bound_datacenter.server_types.supported[0].id == 1
-        assert bound_datacenter.server_types.supported[0].complete is False
-        assert bound_datacenter.server_types.supported[1].id == 2
-        assert bound_datacenter.server_types.supported[1].complete is False
-        assert bound_datacenter.server_types.supported[2].id == 3
-        assert bound_datacenter.server_types.supported[2].complete is False
-
-        assert len(bound_datacenter.server_types.available) == 3
-        assert bound_datacenter.server_types.available[0].id == 1
-        assert bound_datacenter.server_types.available[0].complete is False
-        assert bound_datacenter.server_types.available[1].id == 2
-        assert bound_datacenter.server_types.available[1].complete is False
-        assert bound_datacenter.server_types.available[2].id == 3
-        assert bound_datacenter.server_types.available[2].complete is False
-
-        assert len(bound_datacenter.server_types.available_for_migration) == 3
-        assert bound_datacenter.server_types.available_for_migration[0].id == 1
-        assert (
-            bound_datacenter.server_types.available_for_migration[0].complete is False
-        )
-        assert bound_datacenter.server_types.available_for_migration[1].id == 2
-        assert (
-            bound_datacenter.server_types.available_for_migration[1].complete is False
-        )
-        assert bound_datacenter.server_types.available_for_migration[2].id == 3
-        assert (
-            bound_datacenter.server_types.available_for_migration[2].complete is False
-        )
+        with pytest.deprecated_call():
+            assert isinstance(bound_datacenter.server_types, DatacenterServerTypes)
+            assert len(bound_datacenter.server_types.supported) == 3
+            assert bound_datacenter.server_types.supported[0].id == 1
+            assert bound_datacenter.server_types.supported[0].complete is False
+            assert bound_datacenter.server_types.supported[1].id == 2
+            assert bound_datacenter.server_types.supported[1].complete is False
+            assert bound_datacenter.server_types.supported[2].id == 3
+            assert bound_datacenter.server_types.supported[2].complete is False
+
+            assert len(bound_datacenter.server_types.available) == 3
+            assert bound_datacenter.server_types.available[0].id == 1
+            assert bound_datacenter.server_types.available[0].complete is False
+            assert bound_datacenter.server_types.available[1].id == 2
+            assert bound_datacenter.server_types.available[1].complete is False
+            assert bound_datacenter.server_types.available[2].id == 3
+            assert bound_datacenter.server_types.available[2].complete is False
+
+            assert len(bound_datacenter.server_types.available_for_migration) == 3
+            assert bound_datacenter.server_types.available_for_migration[0].id == 1
+            assert (
+                bound_datacenter.server_types.available_for_migration[0].complete is False
+            )
+            assert bound_datacenter.server_types.available_for_migration[1].id == 2
+            assert (
+                bound_datacenter.server_types.available_for_migration[1].complete is False
+            )
+            assert bound_datacenter.server_types.available_for_migration[2].id == 3
+            assert (
+                bound_datacenter.server_types.available_for_migration[2].complete is False
+            )
 
 
 class TestDatacentersClient:

tests/unit/server_types/conftest.py

@@ -41,6 +41,8 @@ def server_type_response():
                     "id": 1,
                     "name": "nbg1",
                     "deprecation": None,
+                    "available": True,
+                    "recommended": False,
                 },
                 {
                     "id": 2,
@@ -49,6 +51,8 @@ def server_type_response():
                         "announced": "2023-06-01T00:00:00Z",
                         "unavailable_after": "2023-09-01T00:00:00Z",
                     },
+                    "available": True,
+                    "recommended": True,
                 },
             ],
         }

tests/unit/server_types/test_client.py

@@ -33,6 +33,8 @@ def test_init(self, server_type_response):
         assert o.locations[0].location.id == 1
         assert o.locations[0].location.name == "nbg1"
         assert o.locations[0].deprecation is None
+        assert o.locations[0].available is True
+        assert o.locations[0].recommended is False
         assert o.locations[1].location.id == 2
         assert o.locations[1].location.name == "fsn1"
         assert (
@@ -43,6 +45,8 @@ def test_init(self, server_type_response):
             o.locations[1].deprecation.unavailable_after.isoformat()
             == "2023-09-01T00:00:00+00:00"
         )
+        assert o.locations[1].available is True
+        assert o.locations[1].recommended is True
 
         with pytest.deprecated_call():
             assert o.deprecated is True