Skip to content

Commit 55d2b20

Browse files
authored
feat(firewalls): add applied_to_resources to FirewallResource (#297)
Add the read-only `applied_to_resources` field to `FirewallResource` https://docs.hetzner.cloud/#firewalls-get-a-firewall
1 parent 951dbf3 commit 55d2b20

3 files changed

Lines changed: 46 additions & 1 deletion

File tree

hcloud/firewalls/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
CreateFirewallResponse,
66
Firewall,
77
FirewallResource,
8+
FirewallResourceAppliedToResources,
89
FirewallResourceLabelSelector,
910
FirewallRule,
1011
)

hcloud/firewalls/client.py

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
CreateFirewallResponse,
99
Firewall,
1010
FirewallResource,
11+
FirewallResourceAppliedToResources,
1112
FirewallResourceLabelSelector,
1213
FirewallRule,
1314
)
@@ -44,6 +45,24 @@ def __init__(self, client: FirewallsClient, data: dict, complete: bool = True):
4445

4546
data_applied_to = []
4647
for firewall_resource in applied_to:
48+
applied_to_resources = None
49+
if firewall_resource.get("applied_to_resources"):
50+
applied_to_resources = [
51+
FirewallResourceAppliedToResources(
52+
type=resource["type"],
53+
server=(
54+
BoundServer(
55+
client._client.servers,
56+
resource.get("server"),
57+
complete=False,
58+
)
59+
if resource.get("server") is not None
60+
else None
61+
),
62+
)
63+
for resource in firewall_resource.get("applied_to_resources")
64+
]
65+
4766
if firewall_resource["type"] == FirewallResource.TYPE_SERVER:
4867
data_applied_to.append(
4968
FirewallResource(
@@ -53,6 +72,7 @@ def __init__(self, client: FirewallsClient, data: dict, complete: bool = True):
5372
firewall_resource["server"],
5473
complete=False,
5574
),
75+
applied_to_resources=applied_to_resources,
5676
)
5777
)
5878
elif firewall_resource["type"] == FirewallResource.TYPE_LABEL_SELECTOR:
@@ -62,8 +82,10 @@ def __init__(self, client: FirewallsClient, data: dict, complete: bool = True):
6282
label_selector=FirewallResourceLabelSelector(
6383
selector=firewall_resource["label_selector"]["selector"]
6484
),
85+
applied_to_resources=applied_to_resources,
6586
)
6687
)
88+
6789
data["applied_to"] = data_applied_to
6890

6991
super().__init__(client, data, complete)

hcloud/firewalls/domain.py

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,11 @@ class FirewallResource:
134134
Server the Firewall is applied to
135135
:param label_selector: Optional[FirewallResourceLabelSelector]
136136
Label Selector for Servers the Firewall should be applied to
137+
:param applied_to_resources: (read-only) List of effective resources the firewall is
138+
applied to.
137139
"""
138140

139-
__slots__ = ("type", "server", "label_selector")
141+
__slots__ = ("type", "server", "label_selector", "applied_to_resources")
140142

141143
TYPE_SERVER = "server"
142144
"""Firewall Used By Type Server"""
@@ -148,10 +150,12 @@ def __init__(
148150
type: str,
149151
server: Server | BoundServer | None = None,
150152
label_selector: FirewallResourceLabelSelector | None = None,
153+
applied_to_resources: list[FirewallResourceAppliedToResources] | None = None,
151154
):
152155
self.type = type
153156
self.server = server
154157
self.label_selector = label_selector
158+
self.applied_to_resources = applied_to_resources
155159

156160
def to_payload(self) -> dict[str, Any]:
157161
"""
@@ -166,6 +170,24 @@ def to_payload(self) -> dict[str, Any]:
166170
return payload
167171

168172

173+
class FirewallResourceAppliedToResources(BaseDomain):
174+
"""Firewall Resource applied to Domain
175+
176+
:param type: Type of resource referenced
177+
:param server: Server the Firewall is applied to
178+
"""
179+
180+
__slots__ = ("type", "server")
181+
182+
def __init__(
183+
self,
184+
type: str,
185+
server: BoundServer | None = None,
186+
):
187+
self.type = type
188+
self.server = server
189+
190+
169191
class FirewallResourceLabelSelector(BaseDomain):
170192
"""FirewallResourceLabelSelector Domain
171193

0 commit comments

Comments
 (0)