feat: rename bound model methods

Author: jooola

hcloud/storage_boxes/client.py

@@ -499,7 +499,7 @@ def _get_self(self) -> BoundStorageBoxSnapshot:
             self.data_model.id,
         )
 
-    def update_snapshot(
+    def update(
         self,
         *,
         description: str | None = None,
@@ -519,7 +519,7 @@ def update_snapshot(
             labels=labels,
         )
 
-    def delete_snapshot(
+    def delete(
         self,
     ) -> DeleteStorageBoxSnapshotResponse:
         """
@@ -559,7 +559,7 @@ def _get_self(self) -> BoundStorageBoxSubaccount:
             self.data_model.id,
         )
 
-    def update_subaccount(
+    def update(
         self,
         *,
         description: str | None = None,
@@ -579,7 +579,7 @@ def update_subaccount(
             labels=labels,
         )
 
-    def delete_subaccount(
+    def delete(
         self,
     ) -> DeleteStorageBoxSubaccountResponse:
         """
@@ -589,7 +589,7 @@ def delete_subaccount(
         """
         return self._client.delete_subaccount(self)
 
-    def change_subaccount_home_directory(
+    def change_home_directory(
         self,
         home_directory: str,
     ) -> BoundAction:
@@ -604,7 +604,7 @@ def change_subaccount_home_directory(
             self, home_directory=home_directory
         )
 
-    def reset_subaccount_password(
+    def reset_password(
         self,
         password: str,
     ) -> BoundAction:
@@ -617,7 +617,7 @@ def reset_subaccount_password(
         """
         return self._client.reset_subaccount_password(self, password=password)
 
-    def update_subaccount_access_settings(
+    def update_access_settings(
         self,
         access_settings: StorageBoxSubaccountAccessSettings,
     ) -> BoundAction:

tests/unit/conftest.py

@@ -170,6 +170,7 @@ def pytest_generate_tests(metafunc: pytest.Metafunc):
 
 class BoundModelTestOptions(TypedDict):
     sub_resource: bool
+    client_method: str
 
 
 class BoundModelTestCase:
@@ -215,14 +216,19 @@ def test_method(
         if isinstance(bound_model_method, tuple):
             bound_model_method, options = bound_model_method
 
+        resource_client_method_name = options.get(
+            "client_method",
+            bound_model_method.__name__,
+        )
+
         # Check if the resource client has a method named after the bound model method.
-        assert hasattr(resource_client, bound_model_method.__name__)
+        assert hasattr(resource_client, resource_client_method_name)
 
         # Mock the resource client method.
         resource_client_method_mock = mock.MagicMock()
         setattr(
             resource_client,
-            bound_model_method.__name__,
+            resource_client_method_name,
             resource_client_method_mock,
         )
 

tests/unit/storage_boxes/test_client.py

@@ -127,8 +127,8 @@ def test_init(self, bound_model: BoundStorageBox, resource_client):
 
 class TestBoundStorageBoxSnapshot(BoundModelTestCase):
     methods = [
-        BoundStorageBoxSnapshot.update_snapshot,
-        BoundStorageBoxSnapshot.delete_snapshot,
+        (BoundStorageBoxSnapshot.update, {"client_method": "update_snapshot"}),
+        (BoundStorageBoxSnapshot.delete, {"client_method": "delete_snapshot"}),
     ]
 
     @pytest.fixture()
@@ -180,11 +180,26 @@ def test_reload(
 
 class TestBoundStorageBoxSubaccount(BoundModelTestCase):
     methods = [
-        BoundStorageBoxSubaccount.update_subaccount,
-        BoundStorageBoxSubaccount.delete_subaccount,
-        BoundStorageBoxSubaccount.change_subaccount_home_directory,
-        BoundStorageBoxSubaccount.reset_subaccount_password,
-        BoundStorageBoxSubaccount.update_subaccount_access_settings,
+        (
+            BoundStorageBoxSubaccount.update,
+            {"client_method": "update_subaccount"},
+        ),
+        (
+            BoundStorageBoxSubaccount.delete,
+            {"client_method": "delete_subaccount"},
+        ),
+        (
+            BoundStorageBoxSubaccount.change_home_directory,
+            {"client_method": "change_subaccount_home_directory"},
+        ),
+        (
+            BoundStorageBoxSubaccount.reset_password,
+            {"client_method": "reset_subaccount_password"},
+        ),
+        (
+            BoundStorageBoxSubaccount.update_access_settings,
+            {"client_method": "update_subaccount_access_settings"},
+        ),
     ]
 
     @pytest.fixture()