Skip to content

Commit a842d38

Browse files
committed
Server Create should use the Server Type object, not just a string
1 parent fd0e121 commit a842d38

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

hcloud/servers/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ def get_all(self, name=None, label_selector=None):
165165

166166
def create(self,
167167
name, # type: str
168-
server_type, # type: str
168+
server_type, # type: ServerType
169169
image, # type: Image
170170
ssh_keys=None, # type: Optional[List[SSHKey]]
171171
volumes=None, # type: Optional[List[Volume]]
@@ -193,7 +193,7 @@ def create(self,
193193
"""
194194
data = {
195195
'name': name,
196-
'server_type': server_type,
196+
'server_type': server_type.id_or_name,
197197
"start_after_create": start_after_create,
198198
"image": image.id_or_name
199199
}

tests/integration/servers/test_servers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ def test_create(self, hetzner_client):
164164

165165
response = hetzner_client.servers.create(
166166
"my-server",
167-
"cx11",
167+
server_type=ServerType(name="cx11"),
168168
image=Image(name="ubuntu-16.04"),
169169
ssh_keys=[SSHKey(name="my-ssh-key")],
170170
volumes=[Volume(id=1)],

tests/unit/servers/test_client.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ def test_create_with_datacenter(self, servers_client, response_create_simple_ser
353353
servers_client._client.request.return_value = response_create_simple_server
354354
response = servers_client.create(
355355
"my-server",
356-
"cx11",
356+
server_type=ServerType(name="cx11"),
357357
image=Image(id=4711),
358358
datacenter=Datacenter(id=1)
359359
)
@@ -379,7 +379,7 @@ def test_create_with_location(self, servers_client, response_create_simple_serve
379379
servers_client._client.request.return_value = response_create_simple_server
380380
response = servers_client.create(
381381
"my-server",
382-
"cx11",
382+
server_type=ServerType(name="cx11"),
383383
image=Image(name="ubuntu-18.04"),
384384
location=Location(name="fsn1")
385385
)
@@ -412,7 +412,7 @@ def test_create_with_volumes(self, servers_client, response_create_simple_server
412412
volumes = [Volume(id=1), BoundVolume(mock.MagicMock(), dict(id=2))]
413413
response = servers_client.create(
414414
"my-server",
415-
"cx11",
415+
server_type=ServerType(name="cx11"),
416416
image=Image(id=4711),
417417
volumes=volumes,
418418
start_after_create=False

0 commit comments

Comments
 (0)