Skip to content

Commit d18d03d

Browse files
committed
Fix creating server with firewall wrong request format
Signed-off-by: Lukas Kämmerling <lukas.kaemmerling@hetzner-cloud.de>
1 parent e74c014 commit d18d03d

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

hcloud/servers/client.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,14 +457,15 @@ def create(self,
457457
if networks is not None:
458458
data['networks'] = [network.id for network in networks]
459459
if firewalls is not None:
460-
data['firewalls'] = [{"id": firewall.id} for firewall in firewalls]
460+
data['firewalls'] = [{"firewall": firewall.id} for firewall in firewalls]
461461
if user_data is not None:
462462
data['user_data'] = user_data
463463
if labels is not None:
464464
data['labels'] = labels
465465
if automount is not None:
466466
data["automount"] = automount
467467

468+
print(data)
468469
response = self._client.request(url="/servers", method="POST", json=data)
469470

470471
result = CreateServerResponse(

tests/unit/servers/test_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,7 @@ def test_create_with_firewalls(self, servers_client, response_create_simple_serv
594594
'name': "my-server",
595595
'server_type': "cx11",
596596
'image': 4711,
597-
'firewalls': [{"id": 1}, {"id": 2}],
597+
'firewalls': [{"firewall": 1}, {"firewall": 2}],
598598
"start_after_create": False
599599
}
600600
)

0 commit comments

Comments
 (0)