fix: details are optional in API errors (#411)

jooola · web-flow · commit f1c6594dee70 · 2024-07-03T13:17:38.000+02:00
The ansible integrations tests for `certificate_info` were silently failing because the `details` was missing from the API error. https://dev.azure.com/ansible/hetzner.hcloud/_build/results?buildId=116526&view=logs&j=790943b1-2131-5e64-166b-e241853dcaf1&t=4ad41445-2459-50a0-f330-095184dc0a34&l=641
diff --git a/hcloud/_client.py b/hcloud/_client.py
@@ -247,7 +247,7 @@ def request(  # type: ignore[no-untyped-def]
             raise APIException(
                 code=error["code"],
                 message=error["message"],
-                details=error["details"],
+                details=error.get("details"),
                 correlation_id=correlation_id,
             )
 
diff --git a/tests/unit/test_client.py b/tests/unit/test_client.py
@@ -110,7 +110,6 @@ def test_request_fails_correlation_id(self, client, response):
                 "error": {
                     "code": "conflict",
                     "message": "some conflict",
-                    "details": None,
                 }
             }
         ).encode("utf-8")

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ def request( # type: ignore[no-untyped-def]`
`247`	`247`	`raise APIException(`
`248`	`248`	`code=error["code"],`
`249`	`249`	`message=error["message"],`
`250`		`- details=error["details"],`
	`250`	`+ details=error.get("details"),`
`251`	`251`	`correlation_id=correlation_id,`
`252`	`252`	`)`
`253`	`253`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,6 @@ def test_request_fails_correlation_id(self, client, response):`
`110`	`110`	`"error": {`
`111`	`111`	`"code": "conflict",`
`112`	`112`	`"message": "some conflict",`
`113`		`- "details": None,`
`114`	`113`	`}`
`115`	`114`	`}`
`116`	`115`	`).encode("utf-8")`