Make placement group type mandatory

Author: Adrian Huber

hcloud/placement_groups/client.py

@@ -111,18 +111,19 @@ def get_by_name(self, name):
 
     def create(self,
                name,  # type: str
+               type,  # type: str
                labels=None,  # type: Optional[Dict[str, str]]
-               type=PlacementGroup.TYPE_SPREAD  # type: Optional[str]
                ):
         # type: (...) -> CreatePlacementGroupResponse
         """Creates a new Placement Group.
 
         :param name: str
                Placement Group Name
+        :param type: str
+               Type of the Placement Group
         :param labels: Dict[str, str] (optional)
                User-defined labels (key-value pairs)
-        :param type: str
-           Type of the Placement Group
+
         :return: :class:`CreatePlacementGroupResponse <hcloud.placement_groups.domain.CreatePlacementGroupResponse>`
         """
         data = {

tests/unit/placement_groups/test_client.py

@@ -124,9 +124,9 @@ def test_get_by_name(self, placement_groups_client, one_placement_group_response
     def test_create(self, placement_groups_client, response_create_placement_group):
         placement_groups_client._client.request.return_value = response_create_placement_group
         response = placement_groups_client.create(
-            response_create_placement_group['placement_group']['name'],
-            response_create_placement_group['placement_group']['labels'],
-            response_create_placement_group['placement_group']['type']
+            name=response_create_placement_group['placement_group']['name'],
+            type=response_create_placement_group['placement_group']['type'],
+            labels=response_create_placement_group['placement_group']['labels'],
         )
 
         json = {