fix: missing sort for list storage boxes

Author: jooola

hcloud/storage_boxes/client.py

@@ -698,6 +698,7 @@ def get_list(
         self,
         name: str | None = None,
         label_selector: str | None = None,
+        sort: list[str] | None = None,
         page: int | None = None,
         per_page: int | None = None,
     ) -> StorageBoxesPageResult:
@@ -708,6 +709,7 @@ def get_list(
 
         :param name: Name of the Storage Box.
         :param label_selector: Filter resources by labels. The response will only contain resources matching the label selector.
+        :param sort: Sort resources by field and direction.
         :param page: Page number to return.
         :param per_page: Maximum number of entries returned per page.
         """
@@ -720,6 +722,8 @@ def get_list(
             params["page"] = page
         if per_page is not None:
             params["per_page"] = per_page
+        if sort is not None:
+            params["sort"] = sort
 
         response = self._client.request(
             method="GET",
@@ -735,6 +739,7 @@ def get_all(
         self,
         name: str | None = None,
         label_selector: str | None = None,
+        sort: list[str] | None = None,
     ) -> list[BoundStorageBox]:
         """
         Returns all Storage Boxes.
@@ -743,11 +748,13 @@ def get_all(
 
         :param name: Name of the Storage Box.
         :param label_selector: Filter resources by labels. The response will only contain resources matching the label selector.
+        :param sort: Sort resources by field and direction.
         """
         return self._iter_pages(
             self.get_list,
             name=name,
             label_selector=label_selector,
+            sort=sort,
         )
 
     def create(

tests/unit/storage_boxes/test_client.py

@@ -266,7 +266,10 @@ def test_get_by_id(
     @pytest.mark.parametrize(
         "params",
         [
-            {"name": "storage-box1", "page": 1, "per_page": 10},
+            {"name": "storage-box1"},
+            {"label_selector": "key=value"},
+            {"page": 1, "per_page": 10},
+            {"sort": ["id:asc"]},
             {},
         ],
     )
@@ -305,7 +308,9 @@ def test_get_list(
     @pytest.mark.parametrize(
         "params",
         [
-            {"name": "bx11"},
+            {"name": "storage-box1"},
+            {"label_selector": "key=value"},
+            {"sort": ["id:asc"]},
             {},
         ],
     )
@@ -662,6 +667,10 @@ def test_get_snapshot_by_id(
         "params",
         [
             {"name": "storage-box-snapshot1"},
+            {"is_automatic": True},
+            {"label_selector": "key=value"},
+            # {"page": 1, "per_page": 10}  # No pagination
+            {"sort": ["id:asc"]},
             {},
         ],
     )
@@ -707,6 +716,9 @@ def test_get_snapshot_list(
         "params",
         [
             {"name": "storage-box-snapshot1"},
+            {"is_automatic": True},
+            {"label_selector": "key=value"},
+            {"sort": ["id:asc"]},
             {},
         ],
     )
@@ -876,6 +888,9 @@ def test_get_subaccount_by_id(
         "params",
         [
             {"username": "u42-sub1"},
+            {"label_selector": "key=value"},
+            # {"page": 1, "per_page": 10}  # No pagination
+            {"sort": ["id:asc"]},
             {},
         ],
     )
@@ -921,6 +936,8 @@ def test_get_subaccount_list(
         "params",
         [
             {"username": "u42-sub1"},
+            {"label_selector": "key=value"},
+            {"sort": ["id:asc"]},
             {},
         ],
     )