refactor: extract warnDuplicatePlugins to @hey-api/shared and apply in openapi-python

Author: inas-sirhan

packages/openapi-python/src/config/plugins.ts

@@ -1,5 +1,9 @@
 import type { AnyPluginName, PluginContext, PluginNames } from '@hey-api/shared';
-import { dependencyFactory, valueToObject } from '@hey-api/shared';
+import {
+  dependencyFactory,
+  valueToObject,
+  warnDuplicatePlugins,
+} from '@hey-api/shared';
 
 import { defaultPluginConfigs } from '../plugins/config';
 import type { Config, UserConfig } from './types';
@@ -143,6 +147,8 @@ export function getPlugins({
     }
   }
 
+  warnDuplicatePlugins(definedPlugins as ReadonlyArray<never>);
+
   const userPlugins = definedPlugins
     .map((plugin) => {
       if (typeof plugin === 'string') {

packages/openapi-ts/src/config/plugins.ts

@@ -1,6 +1,9 @@
-import { log } from '@hey-api/codegen-core';
 import type { AnyPluginName, PluginContext, PluginNames } from '@hey-api/shared';
-import { dependencyFactory, valueToObject } from '@hey-api/shared';
+import {
+  dependencyFactory,
+  valueToObject,
+  warnDuplicatePlugins,
+} from '@hey-api/shared';
 
 import { defaultPluginConfigs } from '../plugins/config';
 import type { Config, UserConfig } from './types';
@@ -147,51 +150,17 @@ export function getPlugins({
     }
   }
 
-  const seenPlugins = new Map<string, string>();
-
-  const stableStringify = (value: unknown): string =>
-    JSON.stringify(value, (_, v) => {
-      if (typeof v === 'function') {
-        return `[function:${(v as () => unknown).toString()}]`;
-      }
-      if (v && typeof v === 'object' && !Array.isArray(v)) {
-        return Object.fromEntries(
-          Object.entries(v as Record<string, unknown>).sort(([a], [b]) =>
-            a.localeCompare(b),
-          ),
-        );
-      }
-      return v;
-    });
-
-  const checkDuplicate = (name: string, config: Record<string, unknown>) => {
-    const serialized = stableStringify(config);
-    const previous = seenPlugins.get(name);
-    if (previous !== undefined && previous !== serialized) {
-      log.warn(
-        `Plugin "${name}" is configured more than once with conflicting options. Only the last occurrence will take effect.`,
-      );
-    }
-    seenPlugins.set(name, serialized);
-  };
+  warnDuplicatePlugins(definedPlugins as ReadonlyArray<never>);
 
   const userPlugins = definedPlugins
     .map((plugin) => {
       if (typeof plugin === 'string') {
-        checkDuplicate(plugin, {});
         return plugin;
       }
 
       const pluginName = plugin.name;
 
       if (pluginName) {
-        const config = Object.fromEntries(
-          Object.entries(plugin as unknown as Record<string, unknown>).filter(
-            ([key]) => key !== 'name',
-          ),
-        );
-        checkDuplicate(pluginName, config);
-
         // @ts-expect-error
         if (plugin.handler) {
           // @ts-expect-error

packages/shared/src/index.ts

@@ -97,6 +97,7 @@ export type {
   OpenApiSchemaObject,
 } from './openApi/types';
 export type { GetNameContext, Hooks } from './parser/hooks';
+export { warnDuplicatePlugins } from './plugins/duplicate';
 export type { SchemaWithType } from './plugins/shared/types/schema';
 export { definePluginConfig, mappers } from './plugins/shared/utils/config';
 export type { PluginInstanceTypes } from './plugins/shared/utils/instance';

packages/shared/src/plugins/duplicate.ts

@@ -0,0 +1,54 @@
+import { log } from '@hey-api/codegen-core';
+
+type PluginEntry = string | ({ name: string } & Record<string, unknown>);
+
+const stableStringify = (value: unknown): string =>
+  JSON.stringify(value, (_, v) => {
+    if (typeof v === 'function') {
+      return `[function:${(v as () => unknown).toString()}]`;
+    }
+    if (v && typeof v === 'object' && !Array.isArray(v)) {
+      return Object.fromEntries(
+        Object.entries(v as Record<string, unknown>).sort(([a], [b]) =>
+          a.localeCompare(b),
+        ),
+      );
+    }
+    return v;
+  });
+
+export const warnDuplicatePlugins = (
+  plugins: ReadonlyArray<PluginEntry>,
+): void => {
+  const seen = new Map<string, string>();
+
+  for (const plugin of plugins) {
+    if (typeof plugin === 'string') {
+      const previous = seen.get(plugin);
+      if (previous !== undefined && previous !== '{}') {
+        log.warn(
+          `Plugin "${plugin}" is configured more than once with conflicting options. Only the last occurrence will take effect.`,
+        );
+      }
+      seen.set(plugin, '{}');
+      continue;
+    }
+
+    const name = plugin.name;
+    if (!name) continue;
+
+    const config = Object.fromEntries(
+      Object.entries(plugin as Record<string, unknown>).filter(
+        ([key]) => key !== 'name',
+      ),
+    );
+    const serialized = stableStringify(config);
+    const previous = seen.get(name);
+    if (previous !== undefined && previous !== serialized) {
+      log.warn(
+        `Plugin "${name}" is configured more than once with conflicting options. Only the last occurrence will take effect.`,
+      );
+    }
+    seen.set(name, serialized);
+  }
+};