refactor: cleaner length syntax

Author: mrlubos

examples/openapi-ts-axios/src/client/client/utils.gen.ts

@@ -130,7 +130,7 @@ export const buildUrl: Client['buildUrl'] = (options) => {
   const instanceBaseUrl = options.axios?.defaults?.baseURL;
 
   const baseUrl =
-    !!options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl;
+    options.baseURL && typeof options.baseURL === 'string' ? options.baseURL : instanceBaseUrl;
 
   return getUrl({
     baseUrl: baseUrl as string,

packages/codegen-core/src/config/load.ts

@@ -28,7 +28,7 @@ export async function loadConfigFile<T extends AnyObject>({
 
   const fileConfigs = fileConfig instanceof Array ? fileConfig : [fileConfig];
   const mergedConfigs = fileConfigs.map((config) => mergeConfigs<T>(config, userConfig));
-  const foundConfig = fileConfigs.some((config) => Object.keys(config).length > 0);
+  const foundConfig = fileConfigs.some((config) => Object.keys(config).length);
 
   return { configFile: loadedConfigFile, configs: mergedConfigs, foundConfig };
 }

packages/codegen-core/src/logger.ts

@@ -77,7 +77,7 @@ export class Logger {
       if (!event.end) {
         event.end = performance.mark(idEnd(event.id));
       }
-      if (event.events.length > 0) {
+      if (event.events.length) {
         this.endAllEvents(event.events);
       }
     }

packages/json-schema-ref-parser/src/bundle.ts

@@ -445,8 +445,8 @@ function remap(parser: $RefParser, inventory: Array<InventoryEntry>) {
   const ensureContainer = (
     type: 'schemas' | 'parameters' | 'requestBodies' | 'responses' | 'headers',
   ) => {
-    const isOas3 = !!(root && typeof root === 'object' && typeof root.openapi === 'string');
-    const isOas2 = !!(root && typeof root === 'object' && typeof root.swagger === 'string');
+    const isOas3 = Boolean(root && typeof root === 'object' && typeof root.openapi === 'string');
+    const isOas2 = Boolean(root && typeof root === 'object' && typeof root.swagger === 'string');
 
     if (isOas3) {
       if (!root.components || typeof root.components !== 'object') {

packages/json-schema-ref-parser/src/index.ts

@@ -117,12 +117,12 @@ export class $RefParser {
 
     await resolveExternal(this, this.options);
     const errors = JSONParserErrorGroup.getParserErrors(this);
-    if (errors.length > 0) {
+    if (errors.length) {
       throw new JSONParserErrorGroup(this);
     }
     _bundle(this, this.options);
     const errors2 = JSONParserErrorGroup.getParserErrors(this);
-    if (errors2.length > 0) {
+    if (errors2.length) {
       throw new JSONParserErrorGroup(this);
     }
     return this.schema!;
@@ -148,14 +148,14 @@ export class $RefParser {
 
     await resolveExternal(this, this.options);
     const errors = JSONParserErrorGroup.getParserErrors(this);
-    if (errors.length > 0) {
+    if (errors.length) {
       throw new JSONParserErrorGroup(this);
     }
     _bundle(this, this.options);
     // Merged root is ready for bundling
 
     const errors2 = JSONParserErrorGroup.getParserErrors(this);
-    if (errors2.length > 0) {
+    if (errors2.length) {
       throw new JSONParserErrorGroup(this);
     }
     return this.schema!;
@@ -297,7 +297,7 @@ export class $RefParser {
 
   public mergeMany(): JSONSchema {
     const schemas = this.schemaMany || [];
-    if (schemas.length === 0) {
+    if (!schemas.length) {
       throw ono('mergeMany called with no schemas. Did you run parseMany?');
     }
 
@@ -335,7 +335,7 @@ export class $RefParser {
         }
       }
     }
-    if (Object.keys(infoAccumulator).length > 0) {
+    if (Object.keys(infoAccumulator).length) {
       merged.info = infoAccumulator;
     }
 
@@ -356,7 +356,7 @@ export class $RefParser {
         }
       }
     }
-    if (servers.length > 0) {
+    if (servers.length) {
       merged.servers = servers;
     }
 
@@ -568,7 +568,7 @@ export class $RefParser {
       }
     }
 
-    if (tags.length > 0) {
+    if (tags.length) {
       merged.tags = tags;
     }
 

packages/json-schema-ref-parser/src/pointer.ts

@@ -140,7 +140,7 @@ class Pointer<S extends object = JSONSchema> {
       }
     }
 
-    if (errors.length > 0) {
+    if (errors.length) {
       throw errors.length === 1
         ? errors[0]
         : new AggregateError(errors, 'Multiple missing pointer errors');
@@ -171,7 +171,7 @@ class Pointer<S extends object = JSONSchema> {
     const tokens = Pointer.parse(this.path);
     let token;
 
-    if (tokens.length === 0) {
+    if (!tokens.length) {
       // There are no tokens, replace the entire object with the new value
       this.value = value;
       return value;

packages/json-schema-ref-parser/src/ref.ts

@@ -152,7 +152,7 @@ class $Ref<S extends object = JSONSchema> {
       value !== null &&
       '$ref' in value &&
       typeof value.$ref === 'string' &&
-      value.$ref.length > 0
+      Boolean(value.$ref.length)
     );
   }
 

packages/json-schema-ref-parser/src/refs.ts

@@ -224,7 +224,7 @@ function getPaths<S extends object = JSONSchema>($refs: $RefsMap<S>, types: stri
 
   // Filter the paths by type
   types = Array.isArray(types[0]) ? types[0] : Array.prototype.slice.call(types);
-  if (types.length > 0 && types[0]) {
+  if (types.length && types[0]) {
     paths = paths.filter((key) => types.includes($refs[key]!.pathType as string));
   }
 

packages/openapi-python/src/cli/adapter.ts

@@ -12,11 +12,11 @@ export const cliToConfig = (cli: CliOptions): Partial<UserConfig> => {
   if (cli.dryRun !== undefined) config.dryRun = cli.dryRun;
 
   const plugins: ToArray<UserConfig['plugins']> = [];
-  if (cli.plugins instanceof Array && cli.plugins.length > 0) {
+  if (cli.plugins instanceof Array && cli.plugins.length) {
     plugins.push(...cli.plugins);
   }
   // if (cli.client) plugins.push(cli.client);
-  if (plugins.length > 0) config.plugins = plugins;
+  if (plugins.length) config.plugins = plugins;
 
   if (cli.debug || cli.silent || cli.logs || cli.logFile !== undefined) {
     config.logs = {

packages/openapi-python/src/generate.ts

@@ -63,7 +63,7 @@ export async function createClient(
     const configErrors = jobs.flatMap((job) =>
       job.errors.map((error) => ({ error, jobIndex: job.index })),
     );
-    if (configErrors.length > 0) {
+    if (configErrors.length) {
       throw new ConfigValidationError(configErrors);
     }