fix: symbolOnce now correctly handles multiple symbols from same external source

Author: Copilot

packages/codegen-core/src/__tests__/symbols.test.ts

@@ -106,4 +106,22 @@ describe('SymbolRegistry', () => {
     const result = r.query(meta({ a: { b: { c: 123 } } }));
     expect(result).toEqual([a]);
   });
+
+  it('query() returns all symbols sharing the same meta but with different names', () => {
+    const r = new SymbolRegistry();
+
+    const sharedMeta = meta({ category: 'external', resource: '@shared/types' });
+
+    const a = r.register({ meta: sharedMeta, name: 'CustomNumber' });
+    const b = r.register({ meta: sharedMeta, name: 'FlakeIdString' });
+
+    const results = r.query(sharedMeta);
+    expect(results).toHaveLength(2);
+    expect(results).toContain(a);
+    expect(results).toContain(b);
+
+    // filtering by name correctly identifies each symbol independently
+    expect(results.find((s) => s.name === 'CustomNumber')).toBe(a);
+    expect(results.find((s) => s.name === 'FlakeIdString')).toBe(b);
+  });
 });

packages/shared/src/plugins/shared/utils/instance.ts

@@ -399,7 +399,8 @@ export class PluginInstance<T extends Plugin.Types = Plugin.Types> {
 
   /**
    * Registers a symbol only if it does not already exist based on the provided
-   * metadata. This prevents duplicate symbols from being created in the project.
+   * name and metadata. This prevents duplicate symbols from being created in
+   * the project.
    */
   symbolOnce(name: SymbolIn['name'], symbol?: Omit<SymbolIn, 'name'>): Symbol {
     const meta = {
@@ -409,7 +410,7 @@ export class PluginInstance<T extends Plugin.Types = Plugin.Types> {
       meta.category = 'external';
       meta.resource = symbol.external;
     }
-    const existing = this.querySymbol(meta);
+    const existing = this.gen.symbols.query(meta).find((s) => s.name === name);
     if (existing) return existing;
     return this.symbol(name, { ...symbol, meta });
   }