fix required params in function signature

Author: vincentcombey-design

packages/openapi-ts/src/plugins/@hey-api/sdk/shared/__tests__/signature.test.ts

@@ -0,0 +1,39 @@
+import { describe, expect, it } from 'vitest';
+
+import { getSignatureParameters } from '../signature';
+
+const createOperation = (requestBodyRequired: boolean): any => ({
+  body: {
+    required: requestBodyRequired,
+    schema: {
+      properties: {
+        bar: { type: 'string' },
+        foo: { type: 'string' },
+      },
+      required: ['foo'],
+      type: 'object',
+    },
+  },
+});
+
+describe('getSignatureParameters', () => {
+  it('marks required body properties as required when request body is required', () => {
+    const signature = getSignatureParameters({
+      operation: createOperation(true),
+      plugin: {} as any,
+    });
+
+    expect(signature?.parameters.foo?.isRequired).toBe(true);
+    expect(signature?.parameters.bar?.isRequired).toBe(false);
+  });
+
+  it('keeps body properties optional when request body is optional', () => {
+    const signature = getSignatureParameters({
+      operation: createOperation(false),
+      plugin: {} as any,
+    });
+
+    expect(signature?.parameters.foo?.isRequired).toBe(false);
+    expect(signature?.parameters.bar?.isRequired).toBe(false);
+  });
+});

packages/openapi-ts/src/plugins/@hey-api/sdk/shared/signature.ts

@@ -126,12 +126,14 @@ export function getSignatureParameters({
       operation.body.schema.type === 'object' &&
       operation.body.schema.properties
     ) {
+      const requiredBodyProperties = new Set(operation.body.schema.required ?? []);
       const properties = operation.body.schema.properties;
       for (const originalName in properties) {
         const property = properties[originalName]!;
         const name = conflicts.has(originalName) ? `${location}_${originalName}` : originalName;
         const signatureParameter: SignatureParameter = {
-          isRequired: property.required?.includes(originalName) ?? false,
+          isRequired:
+            (operation.body.required ?? false) && requiredBodyProperties.has(originalName),
           name,
           schema: property,
         };