Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Commit 7f73d1b

Browse files
committed
Use definition-finder v2.0
1 parent 38b0c26 commit 7f73d1b

8 files changed

Lines changed: 112 additions & 110 deletions

File tree

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"hhvm": "^3.23.0",
88
"facebook/hack-router": ">=0.14",
99
"facebook/hack-codegen": "^3.0.1",
10-
"facebook/definition-finder": "^1.5.3",
10+
"facebook/definition-finder": "^2.0",
1111
"hhvm/type-assert": "^3.0"
1212
},
1313
"require-dev": {

composer.lock

Lines changed: 79 additions & 78 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/Codegen.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,8 @@ public static function forTree(
9595
string $source_root,
9696
self::TCodegenConfig $config,
9797
): Codegen {
98-
return new self(TreeParser::FromPath($source_root), $config);
98+
return
99+
new self(\HH\Asio\join(TreeParser::fromPathAsync($source_root)), $config);
99100
}
100101

101102
<<__Memoize>>

src/privateimpl/ClassFacts.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
namespace Facebook\HackRouter\PrivateImpl;
1212

1313
use type Facebook\DefinitionFinder\BaseParser;
14-
use type Facebook\DefinitionFinder\ScannedBasicClass;
1514
use type Facebook\DefinitionFinder\ScannedClass;
15+
use type Facebook\DefinitionFinder\ScannedClassish;
1616

1717
final class ClassFacts {
18-
private ImmMap<string, ScannedClass> $classes;
18+
private ImmMap<string, ScannedClassish> $classes;
1919

2020
public function __construct(
2121
BaseParser $parser,
@@ -36,10 +36,10 @@ public function __construct(
3636

3737
public function getSubclassesOf<T>(
3838
classname<T> $wanted,
39-
): ImmMap<classname<T>, ScannedBasicClass> {
39+
): ImmMap<classname<T>, ScannedClass> {
4040
$mappable = Map { };
4141
foreach ($this->classes as $class) {
42-
if (!$class instanceof ScannedBasicClass) {
42+
if (!$class instanceof ScannedClass) {
4343
continue;
4444
}
4545
$name = $this->asClassname($wanted, $class->getName());

src/privateimpl/ControllerFacts.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010

1111
namespace Facebook\HackRouter\PrivateImpl;
1212

13-
use type \Facebook\DefinitionFinder\ScannedBasicClass;
1413
use type \Facebook\DefinitionFinder\ScannedClass;
14+
use type \Facebook\DefinitionFinder\ScannedClassish;
1515
use type \Facebook\HackRouter\{
1616
HttpMethod,
1717
IncludeInUriMap,
@@ -41,9 +41,9 @@ public function getControllers(
4141

4242
<<TestsBypassVisibility>>
4343
private function isUriMappable(
44-
ScannedClass $class
44+
ScannedClassish $class
4545
): bool {
46-
if (!$class instanceof ScannedBasicClass) {
46+
if (!$class instanceof ScannedClass) {
4747
return false;
4848
}
4949
if ($class->isAbstract()) {

0 commit comments

Comments
 (0)