Notification Channel Name Should Be Unique (#292)

* Notification Channel Name Should Be Unique

Author: Deepanshu0703

notification-channel-config-service-impl/src/main/java/org/hypertrace/notification/config/service/NotificationChannelConfigServiceImpl.java

@@ -51,8 +51,10 @@ public void createNotificationChannel(
       StreamObserver<CreateNotificationChannelResponse> responseObserver) {
     try {
       RequestContext requestContext = RequestContext.CURRENT.get();
+      List<NotificationChannel> existingNotificationChannels =
+          notificationChannelStore.getAllConfigData(requestContext);
       validator.validateCreateNotificationChannelRequest(
-          requestContext, request, notificationChannelConfig);
+          requestContext, request, notificationChannelConfig, existingNotificationChannels);
       NotificationChannel.Builder builder =
           NotificationChannel.newBuilder()
               .setId(UUID.randomUUID().toString())
@@ -75,8 +77,10 @@ public void updateNotificationChannel(
       StreamObserver<UpdateNotificationChannelResponse> responseObserver) {
     try {
       RequestContext requestContext = RequestContext.CURRENT.get();
+      List<NotificationChannel> existingNotificationChannels =
+          notificationChannelStore.getAllConfigData(requestContext);
       validator.validateUpdateNotificationChannelRequest(
-          requestContext, request, notificationChannelConfig);
+          requestContext, request, notificationChannelConfig, existingNotificationChannels);
       responseObserver.onNext(
           UpdateNotificationChannelResponse.newBuilder()
               .setNotificationChannel(

notification-channel-config-service-impl/src/main/java/org/hypertrace/notification/config/service/NotificationChannelConfigServiceRequestValidator.java

@@ -8,6 +8,7 @@
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.util.List;
+import javax.annotation.Nullable;
 import org.hypertrace.core.grpcutils.context.RequestContext;
 import org.hypertrace.notification.config.service.v1.AwsS3BucketChannelConfig;
 import org.hypertrace.notification.config.service.v1.AwsS3BucketChannelConfig.WebIdentityAuthenticationCredential;
@@ -16,6 +17,7 @@
 import org.hypertrace.notification.config.service.v1.EmailChannelConfig;
 import org.hypertrace.notification.config.service.v1.GetAllNotificationChannelsRequest;
 import org.hypertrace.notification.config.service.v1.GetNotificationChannelRequest;
+import org.hypertrace.notification.config.service.v1.NotificationChannel;
 import org.hypertrace.notification.config.service.v1.NotificationChannelMutableData;
 import org.hypertrace.notification.config.service.v1.SplunkIntegrationChannelConfig;
 import org.hypertrace.notification.config.service.v1.SyslogIntegrationChannelConfig;
@@ -31,11 +33,16 @@ public class NotificationChannelConfigServiceRequestValidator {
   public void validateCreateNotificationChannelRequest(
       RequestContext requestContext,
       CreateNotificationChannelRequest request,
-      Config notificationChannelConfig) {
+      Config notificationChannelConfig,
+      List<NotificationChannel> existingNotificationChannels) {
     validateRequestContextOrThrow(requestContext);
     validateNotificationChannelMutableData(request.getNotificationChannelMutableData());
     validateWebhookConfigExclusionDomains(
         request.getNotificationChannelMutableData(), notificationChannelConfig);
+    validateNonDuplicateNotificationChannelOrThrow(
+        null,
+        request.getNotificationChannelMutableData().getChannelName(),
+        existingNotificationChannels);
     validateWebhookHttpSupport(
         request.getNotificationChannelMutableData(), notificationChannelConfig);
   }
@@ -99,12 +106,17 @@ void validateWebhookConfigExclusionDomains(
   public void validateUpdateNotificationChannelRequest(
       RequestContext requestContext,
       UpdateNotificationChannelRequest request,
-      Config notificationChannelConfig) {
+      Config notificationChannelConfig,
+      List<NotificationChannel> existingNotificationChannels) {
     validateRequestContextOrThrow(requestContext);
     validateNonDefaultPresenceOrThrow(request, UpdateNotificationChannelRequest.ID_FIELD_NUMBER);
     validateNotificationChannelMutableData(request.getNotificationChannelMutableData());
     validateWebhookConfigExclusionDomains(
         request.getNotificationChannelMutableData(), notificationChannelConfig);
+    validateNonDuplicateNotificationChannelOrThrow(
+        request.getId(),
+        request.getNotificationChannelMutableData().getChannelName(),
+        existingNotificationChannels);
     validateWebhookHttpSupport(
         request.getNotificationChannelMutableData(), notificationChannelConfig);
   }
@@ -193,4 +205,21 @@ private void validateSyslogIntegrationChannelConfig(
         syslogIntegrationChannelConfig,
         SyslogIntegrationChannelConfig.SYSLOG_SERVER_INTEGRATION_ID_FIELD_NUMBER);
   }
+
+  private void validateNonDuplicateNotificationChannelOrThrow(
+      @Nullable String id,
+      String channelName,
+      List<NotificationChannel> existingNotificationChannels) {
+    for (NotificationChannel existingNotificationChannel : existingNotificationChannels) {
+      if (!existingNotificationChannel.getId().equals(id)
+          && existingNotificationChannel
+              .getNotificationChannelMutableData()
+              .getChannelName()
+              .equals(channelName)) {
+        throw Status.ALREADY_EXISTS
+            .withDescription("Notification Channel with the same name already exists.")
+            .asRuntimeException();
+      }
+    }
+  }
 }

notification-channel-config-service-impl/src/test/java/org/hypertrace/notification/config/service/NotificationChannelConfigServiceRequestValidatorTest.java

@@ -7,6 +7,7 @@
 import com.typesafe.config.ConfigFactory;
 import com.typesafe.config.ConfigValueFactory;
 import java.io.File;
+import java.util.List;
 import org.hypertrace.core.grpcutils.context.RequestContext;
 import org.hypertrace.notification.config.service.v1.NotificationChannelMutableData;
 import org.hypertrace.notification.config.service.v1.UpdateNotificationChannelRequest;
@@ -83,7 +84,8 @@ public void testValidateWebhookHttpsSupport() {
           notificationChannelConfigServiceRequestValidator.validateUpdateNotificationChannelRequest(
               RequestContext.forTenantId("tenant1"),
               getUpdateNotificationChannelRequestWithHttpUrl(),
-              notificationChannelConfig);
+              notificationChannelConfig,
+              List.of());
         },
         "RuntimeException was expected");
 
@@ -103,7 +105,8 @@ public void testValidateWebhookHttpsSupport() {
             .setId("id1")
             .setNotificationChannelMutableData(notificationChannelMutableDataWithHttpUrl)
             .build(),
-        updatedNotificationChannelConfig);
+        updatedNotificationChannelConfig,
+        List.of());
   }
 
   private static UpdateNotificationChannelRequest getUpdateNotificationChannelRequestWithHttpUrl() {