Skip to content

Commit cec635a

Browse files
Added the removed LabelApplicationRuleDataDeserializationConfig.java file (#189)
* Added the removed LabelApplicationRuleDataDeserializationConfig.java file * Added null check before switch case * Addressed review comments
1 parent 544b610 commit cec635a

3 files changed

Lines changed: 26 additions & 1 deletion

File tree

hypertrace-graphql-labels-schema-impl/src/main/java/org/hypertrace/graphql/label/dao/LabelApplicationRuleRequestConverter.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package org.hypertrace.graphql.label.dao;
22

3+
import static org.hypertrace.graphql.label.schema.rule.StringCondition.StringConditionValueType.VALUE;
4+
35
import java.util.List;
46
import java.util.Optional;
57
import java.util.stream.Collectors;
@@ -133,7 +135,9 @@ StringCondition convertStringCondition(
133135
StringCondition.Builder stringConditionBuilder =
134136
StringCondition.newBuilder()
135137
.setOperator(convertStringConditionOperator(stringCondition.operator()));
136-
switch (stringCondition.stringConditionValueType()) {
138+
final org.hypertrace.graphql.label.schema.rule.StringCondition.StringConditionValueType type =
139+
Optional.ofNullable(stringCondition.stringConditionValueType()).orElse(VALUE);
140+
switch (type) {
137141
case VALUES:
138142
return stringConditionBuilder
139143
.setValues(
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
package org.hypertrace.graphql.label.deserialization;
2+
3+
import org.hypertrace.core.graphql.deserialization.ArgumentDeserializationConfig;
4+
import org.hypertrace.graphql.label.schema.rule.LabelApplicationRuleData;
5+
6+
public class LabelApplicationRuleDataDeserializationConfig
7+
implements ArgumentDeserializationConfig {
8+
@Override
9+
public String getArgumentKey() {
10+
return LabelApplicationRuleData.ARGUMENT_NAME;
11+
}
12+
13+
@Override
14+
public Class<?> getArgumentSchema() {
15+
return LabelApplicationRuleData.class;
16+
}
17+
}

hypertrace-graphql-labels-schema-impl/src/main/java/org/hypertrace/graphql/label/deserialization/LabelApplicationRuleDeserializationModule.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ protected void configure() {
1010
Multibinder<ArgumentDeserializationConfig> deserializationConfigBinder =
1111
Multibinder.newSetBinder(binder(), ArgumentDeserializationConfig.class);
1212

13+
deserializationConfigBinder
14+
.addBinding()
15+
.to(LabelApplicationRuleDataDeserializationConfig.class);
16+
1317
deserializationConfigBinder.addBinding().to(LabelApplicationRuleDeserializationConfig.class);
1418

1519
deserializationConfigBinder

0 commit comments

Comments
 (0)