Fix #227: Class no longer available for code completion when file renamed

Author: dgrunwald

src/AddIns/BackendBindings/CSharpBinding/Project/Src/CSharpSemanticHighlighter.cs

@@ -256,7 +256,7 @@ HighlightedLine DoHighlightLine(int lineNumber, IDocumentLine documentLine, Cach
 			if (parseInfo == null) {
 				if (invalidLines != null && !invalidLines.Contains(documentLine)) {
 					invalidLines.Add(documentLine);
-					Debug.WriteLine("Semantic highlighting for line {0} - marking as invalid", lineNumber);
+					//Debug.WriteLine("Semantic highlighting for line {0} - marking as invalid", lineNumber);
 				}
 
 				if (cachedLine != null) {

src/Libraries/AvalonEdit/ICSharpCode.AvalonEdit/Rendering/TextView.cs

@@ -1027,7 +1027,7 @@ VisualLine BuildVisualLine(DocumentLine documentLine,
 			if (heightTree.GetIsCollapsed(documentLine.LineNumber))
 				throw new InvalidOperationException("Trying to build visual line from collapsed line");
 
-			Debug.WriteLine("Building line " + documentLine.LineNumber);
+			//Debug.WriteLine("Building line " + documentLine.LineNumber);
 
 			VisualLine visualLine = new VisualLine(this, documentLine);
 			VisualLineTextSource textSource = new VisualLineTextSource(visualLine) {

src/Main/SharpDevelop/Parser/ParserService.cs

@@ -194,6 +194,7 @@ public void AddOwnerProject(FileName fileName, IProject project, bool startAsync
 		{
 			if (project == null)
 				throw new ArgumentNullException("project");
+			//SD.Log.Debug("Add " + fileName + " to " + project);
 			var entry = GetFileEntry(fileName, true);
 			entry.AddOwnerProject(project, isLinkedFile);
 			if (startAsyncParse)
@@ -204,6 +205,7 @@ public void RemoveOwnerProject(FileName fileName, IProject project)
 		{
 			if (project == null)
 				throw new ArgumentNullException("project");
+			//SD.Log.Debug("Remove " + fileName + " from " + project);
 			var entry = GetFileEntry(fileName, false);
 			if (entry != null)
 				entry.RemoveOwnerProject(project);

src/Main/SharpDevelop/Parser/ParserServiceEntry.cs

@@ -214,8 +214,9 @@ ProjectEntry DoParse(ITextSource fileContent, IProject parentProject, bool fullP
 					return new ProjectEntry(parentProject, parseInfo.UnresolvedFile, parseInfo);
 				} else {
 					if (versionComparison == 0 && index >= 0) {
+						// Ensure we have parse info for the specified project (entry.UnresolvedFile is null for newly registered projects)
 						// If full parse info is requested, ensure we have full parse info.
-						if (!(fullParseInformationRequested && entries[index].CachedParseInformation == null)) {
+						if (entries[index].UnresolvedFile != null && !(fullParseInformationRequested && entries[index].CachedParseInformation == null)) {
 							// We already have the requested version parsed, just return it:
 							return entries[index];
 						}
@@ -271,6 +272,7 @@ ParseInformation ParseWithExceptionHandling(ITextSource fileContent, bool fullPa
 		#region ParseAsync
 		Task<ProjectEntry> runningAsyncParseTask;
 		ITextSourceVersion runningAsyncParseFileContentVersion;
+		IProject runningAsyncParseProject;
 		bool runningAsyncParseFullInfoRequested;
 
 		public async Task<ParseInformation> ParseAsync(ITextSource fileContent, IProject parentProject, CancellationToken cancellationToken)
@@ -312,15 +314,17 @@ Task<ProjectEntry> DoParseAsync(ITextSource fileContent, IProject parentProject,
 					int index = FindIndexForProject(parentProject);
 					int versionComparison = CompareVersions(fileContent.Version);
 					if (versionComparison == 0 && index >= 0) {
+						// Ensure we have parse info for the specified project (entry.UnresolvedFile is null for newly registered projects)
 						// If full parse info is requested, ensure we have full parse info.
-						if (!(requestFullParseInformation && entries[index].CachedParseInformation == null)) {
+						if (entries[index].UnresolvedFile != null && !(requestFullParseInformation && entries[index].CachedParseInformation == null)) {
 							// We already have the requested version parsed, just return it:
 							return Task.FromResult(entries[index]);
 						}
 					}
 					// Optimization:
 					// if an equivalent task is already running, return that one instead
 					if (runningAsyncParseTask != null && (!requestFullParseInformation || runningAsyncParseFullInfoRequested)
+					    && runningAsyncParseProject == parentProject
 					    && runningAsyncParseFileContentVersion.BelongsToSameDocumentAs(fileContent.Version)
 					    && runningAsyncParseFileContentVersion.CompareAge(fileContent.Version) == 0)
 					{
@@ -338,12 +342,14 @@ Task<ProjectEntry> DoParseAsync(ITextSource fileContent, IProject parentProject,
 							lock (this) {
 								runningAsyncParseTask = null;
 								runningAsyncParseFileContentVersion = null;
+								runningAsyncParseProject = null;
 							}
 						}
 					}, cancellationToken);
 				if (fileContent != null && fileContent.Version != null && !cancellationToken.CanBeCanceled) {
 					runningAsyncParseTask = task;
 					runningAsyncParseFileContentVersion = fileContent.Version;
+					runningAsyncParseProject = parentProject;
 					runningAsyncParseFullInfoRequested = requestFullParseInformation;
 				}
 			}

src/Main/SharpDevelop/Project/Build/BuildEngine.cs

@@ -30,15 +30,15 @@ sealed class BuildEngine
 		/// </summary>
 		/// <param name="project">The project/solution to build</param>
 		/// <param name="options">The build options that should be used</param>
-		/// <param name="realtimeBuildFeedbackSink">The build feedback sink that receives the build output.
+		/// <param name="buildFeedbackSink">The build feedback sink that receives the build output.
 		/// The output is nearly sent "as it comes in": sometimes output must wait because the BuildEngine
 		/// will ensure that output from two projects building in parallel isn't interleaved.</param>
 		/// <param name="progressMonitor">The progress monitor that receives build progress. The monitor will be disposed
 		/// when the build completes.</param>
 		public static Task<BuildResults> BuildAsync(IBuildable project, BuildOptions options, IBuildFeedbackSink buildFeedbackSink, IProgressMonitor progressMonitor)
 		{
 			if (project == null)
-				throw new ArgumentNullException("solution");
+				throw new ArgumentNullException("project");
 			if (options == null)
 				throw new ArgumentNullException("options");
 

src/Main/SharpDevelop/Project/ProjectService.cs

@@ -137,7 +137,7 @@ public bool OpenSolutionOrProject(FileName fileName)
 			if (!CloseSolution(allowCancel: true))
 				return false;
 			FileUtility.ObservedLoad(OpenSolutionInternal, fileName);
-				
+			
 			return currentSolution != null;
 		}
 
@@ -147,13 +147,6 @@ void OpenSolutionInternal(FileName fileName)
 			using (var progress = AsynchronousWaitDialog.ShowWaitDialog("Loading Solution...")) {
 
 				solution = LoadSolutionFile(fileName, progress);
-				//(openSolution.Preferences as IMementoCapable).SetMemento(solutionProperties);
-				
-//				try {
-//					ApplyConfigurationAndReadProjectPreferences();
-//				} catch (Exception ex) {
-//					MessageService.ShowException(ex);
-//				}
 
 				this.CurrentSolution = solution;
 			}
@@ -263,7 +256,7 @@ static void LoadProjectInternal(string fileName)
 		public event EventHandler<SolutionClosingEventArgs> SolutionClosing = delegate { };
 		public event EventHandler<SolutionEventArgs> SolutionClosed = delegate { };
 
-		public bool CloseSolution(bool allowCancel)
+		public bool CloseSolution(bool allowCancel = true)
 		{
 			SD.MainThread.VerifyAccess();
 			var solution = this.CurrentSolution;