Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

Commit 41cd4d6

Browse files
dgrunwalddgrunwald
committed
Adjust CSharpBinding.addin to NRefactory changes, and reactivate some useful uncategorized issues.
1 parent fe56625 commit 41cd4d6

5 files changed

Lines changed: 18 additions & 26 deletions

File tree

‎src/AddIns/BackendBindings/CSharpBinding/Project/CSharpBinding.addin‎

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -179,12 +179,9 @@
179179
<Class class = "CSharpBinding.Refactoring.CSharpSyntaxIssue" />
180180
<Class class = "CSharpBinding.Refactoring.SDRedundantUsingIssue" />
181181
<Class class = "ICSharpCode.NRefactory.CSharp.BaseMethodCallWithDefaultParameterIssue" />
182-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.AccessToDisposedClosureIssue" />
183-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.AccessToModifiedClosureIssue" />
184182
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.AccessToStaticMemberViaDerivedTypeIssue" />
185183
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.AdditionalOfTypeIssues" />
186184
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ArrayCreationCanBeReplacedWithArrayInitializerIssue" />
187-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.AutoAsyncIssue" />
188185
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.BaseMemberHasParamsIssue" />
189186
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.BaseMethodParameterNameMismatchIssue" />
190187
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.BitwiseOperatorOnEnumWithoutFlagsIssue" />
@@ -224,11 +221,8 @@
224221
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.CS1717AssignmentMadeToSameVariableIssue" />
225222
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.CS1729TypeHasNoConstructorWithNArgumentsIssue" />
226223
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.DelegateSubtractionIssue" />
227-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.DisposeMethodInNonIDisposableTypeIssue" />
228224
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.DoNotCallOverridableMethodsInConstructorIssue" />
229-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.DontUseLinqWhenItsVerboseAndInefficientIssue" />
230225
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.DoubleNegationOperatorIssue" />
231-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.DuplicatedLinqToListOrArrayIssue" />
232226
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.EmptyConstructorIssue" />
233227
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.EmptyDestructorIssue" />
234228
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.EmptyEmbeddedStatementIssue" />
@@ -248,7 +242,6 @@
248242
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ForStatementConditionIsTrueIssue" />
249243
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.FunctionNeverReturnsIssue" />
250244
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.InconsistentNamingIssue" />
251-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.IncorrectCallToObjectGetHashCodeIssue" />
252245
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.InvokeAsExtensionMethodIssue" />
253246
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.LocalVariableHidesMemberIssue" />
254247
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.LocalVariableNotUsedIssue" />
@@ -283,7 +276,6 @@
283276
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantAttributeParenthesesIssue" />
284277
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantBaseConstructorCallIssue" />
285278
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantBaseQualifierIssue" />
286-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantBlockInDifferentBranchesIssue" />
287279
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantBoolCompareIssue" />
288280
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantCaseLabelIssue" />
289281
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantCatchClauseIssue" />
@@ -305,7 +297,6 @@
305297
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantLambdaSignatureParenthesesIssue" />
306298
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantLogicalConditionalExpressionOperandIssue" />
307299
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantNameQualifierIssue" />
308-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantNotNullAttributeInNonNullableTypeIssue" />
309300
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantObjectCreationArgumentListIssue" />
310301
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantObjectOrCollectionInitializerIssue" />
311302
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RedundantOverridenMemberIssue" />
@@ -334,18 +325,20 @@
334325
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithOfTypeWhereIssue" />
335326
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSimpleAssignmentIssue" />
336327
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToAnyIssue" />
328+
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToAverageIssue" />
337329
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToCountIssue" />
338330
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToFirstIssue" />
339331
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToFirstOrDefaultIssue" />
340332
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToLastIssue" />
341333
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToLastOrDefaultIssue" />
342334
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToLongCountIssue" />
335+
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToMinIssue" />
336+
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToMaxIssue" />
343337
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToSingleIssue" />
344338
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToSingleOrDefaultIssue" />
339+
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithSingleCallToSumIssue" />
345340
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ReplaceWithStringIsNullOrEmptyIssue" />
346-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ResultOfAsyncCallShouldNotBeIgnoredIssue" />
347341
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.RewriteIfReturnToReturnIssue" />
348-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.SameGuardConditionExpressionInIfelseBranchesIssue" />
349342
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.SealedMemberInSealedClassIssue" />
350343
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.SimplifyConditionalTernaryExpressionIssue" />
351344
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.SimplifyLinqExpressionIssue" />
@@ -361,7 +354,6 @@
361354
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.SuggestUseVarKeywordEvidentIssue" />
362355
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.ThreadStaticAtInstanceFieldIssue" />
363356
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.UnassignedReadonlyFieldIssue" />
364-
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.UnmatchedSizeSpecificationInArrayCreationIssue" />
365357
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.UnreachableCodeIssue" />
366358
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.UnusedAnonymousMethodSignatureIssue" />
367359
<Class class = "ICSharpCode.NRefactory.CSharp.Refactoring.UnusedLabelIssue" />

‎src/Libraries/NRefactory/ICSharpCode.NRefactory.CSharp.Refactoring/CodeIssues/Uncategorized/ExceptionRethrowIssue.cs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,11 @@
3131

3232
namespace ICSharpCode.NRefactory.CSharp.Refactoring
3333
{
34-
// [IssueDescription("A throw statement throws the caught exception by passing it explicitly",
35-
// Description = "Finds throws that throws the caught exception and therefore should be empty.",
36-
// Category = IssueCategories.CodeQualityIssues,
37-
// Severity = Severity.Warning,
38-
// AnalysisDisableKeyword = "PossibleIntendedRethrow")]
34+
[IssueDescription("A throw statement throws the caught exception by passing it explicitly",
35+
Description = "Finds throws that throws the caught exception and therefore should be empty.",
36+
Category = IssueCategories.CodeQualityIssues,
37+
Severity = Severity.Warning,
38+
AnalysisDisableKeyword = "PossibleIntendedRethrow")]
3939
public class ExceptionRethrowIssue : GatherVisitorCodeIssueProvider
4040
{
4141
protected override IGatherVisitor CreateVisitor(BaseRefactoringContext context)

‎src/Libraries/NRefactory/ICSharpCode.NRefactory.CSharp.Refactoring/CodeIssues/Uncategorized/ExplicitConversionInForEachIssue.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525

2626
namespace ICSharpCode.NRefactory.CSharp.Refactoring
2727
{
28-
// [IssueDescription("Incorrect element type in foreach over generic collection",
29-
// Description= "Detects hidden explicit conversions in foreach loops.",
30-
// Category = IssueCategories.CodeQualityIssues,
31-
// Severity = Severity.Warning)]
28+
[IssueDescription("Incorrect element type in foreach over generic collection",
29+
Description= "Detects hidden explicit conversions in foreach loops.",
30+
Category = IssueCategories.CodeQualityIssues,
31+
Severity = Severity.Warning)]
3232
public class ExplicitConversionInForEachIssue : GatherVisitorCodeIssueProvider
3333
{
3434
protected override IGatherVisitor CreateVisitor(BaseRefactoringContext context)

‎src/Libraries/NRefactory/ICSharpCode.NRefactory.CSharp.Refactoring/CodeIssues/Uncategorized/UseOfMemberOfNullReference.cs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@
3434

3535
namespace ICSharpCode.NRefactory.CSharp.Refactoring
3636
{
37-
// [IssueDescription("Use of (non-extension method) member of null value will cause a NullReferenceException",
38-
// Description = "Detects when a member of a null value is used",
39-
// Category = IssueCategories.CodeQualityIssues,
40-
// Severity = Severity.Warning)]
37+
[IssueDescription("Use of (non-extension method) member of null value will cause a NullReferenceException",
38+
Description = "Detects when a member of a null value is used",
39+
Category = IssueCategories.CodeQualityIssues,
40+
Severity = Severity.Warning)]
4141
public class UseOfMemberOfNullReference : GatherVisitorCodeIssueProvider
4242
{
4343
static readonly ISet<NullValueStatus> ProblematicNullStates = new HashSet<NullValueStatus> {

‎src/Libraries/NRefactory/ICSharpCode.NRefactory.CSharp/Refactoring/Script.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -624,7 +624,7 @@ public virtual void CreateNewType(AstNode newType, NewTypeContext context = NewT
624624
}
625625
}
626626

627-
static class ExtMethods
627+
public static class ExtMethods
628628
{
629629
public static void ContinueScript (this Task task, Action act)
630630
{

0 commit comments

Comments
 (0)